diff mbox series

[v4,16/42] common/cnxk: use rte strerror

Message ID	20241023082852.2780488-17-huangdengdui@huawei.com (mailing list archive)
State	Changes Requested, archived
Delegated to:	Thomas Monjalon
Headers	From: Dengdui Huang <huangdengdui@huawei.com> To: <dev@dpdk.org> CC: <ferruh.yigit@amd.com>, <stephen@networkplumber.org>, <mb@smartsharesystems.com>, <david.marchand@redhat.com>, <iboukris@gmail.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <haijie1@huawei.com>, <liuyonglong@huawei.com> Subject: [PATCH v4 16/42] common/cnxk: use rte strerror Date: Wed, 23 Oct 2024 16:28:26 +0800 Message-ID: <20241023082852.2780488-17-huangdengdui@huawei.com> In-Reply-To: <20241023082852.2780488-1-huangdengdui@huawei.com> References: <20231114082539.1858594-44-huangdengdui@huawei.com> <20241023082852.2780488-1-huangdengdui@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace strerror \| [v4,00/42] replace strerror [v4,01/42] devtools: forbid use of strerror [v4,02/42] eal: use rte strerror [v4,03/42] eventdev: use rte strerror [v4,04/42] latency: use rte strerror [v4,05/42] node: use rte strerror [v4,06/42] pdump: use rte strerror [v4,07/42] power: use rte strerror [v4,08/42] vhost: use rte strerror [v4,09/42] bpf: use rte strerror [v4,10/42] bus/cdx: use rte strerror [v4,11/42] bus/dpaa: use rte strerror [v4,12/42] bus/fslmc: use rte strerror [v4,13/42] bus/pci: use rte strerror [v4,14/42] bus/vdev: use rte strerror [v4,15/42] bus/vmbus: use rte strerror [v4,16/42] common/cnxk: use rte strerror [v4,17/42] common/mlx5: use rte strerror [v4,18/42] crypto/caam_jr: use rte strerror [v4,19/42] dma/idxd: use rte strerror [v4,20/42] net/af_packet: use rte strerror [v4,21/42] net/bnxt: use rte strerror [v4,22/42] net/af_xdp: use rte strerror [v4,23/42] net/bonding: use rte strerror [v4,24/42] net/dpaa: use rte strerror [v4,25/42] net/dpaa2: use rte strerror [v4,26/42] net/enetfec: use rte strerror [v4,27/42] net/failsafe: use rte strerror [v4,28/42] net/i40e: use rte strerror [v4,29/42] net/ice: use rte strerror [v4,30/42] net/ixgbe: use rte strerror [v4,31/42] net/memif: use rte strerror [v4,32/42] net/mlx4: use rte strerror [v4,33/42] net/mlx5: use rte strerror [v4,34/42] net/qede: use rte strerror [v4,35/42] net/sfc: use rte strerror [v4,36/42] net/tap: use rte strerror [v4,37/42] net/vhost: use rte strerror [v4,38/42] net/virtio: use rte strerror [v4,39/42] raw/ifpga: use rte strerror [v4,40/42] vdpa/ifc: use rte strerror [v4,41/42] vdpa/mlx5: use rte strerror [v4,42/42] vdpa/sfc: use rte strerror

Checks

Context	Check	Description
ci/checkpatch	warning	coding style issues

Commit Message

huangdengdui Oct. 23, 2024, 8:28 a.m. UTC

The function strerror() is insecure in a multi-thread environment.
This patch uses rte_strerror() to replace it.

Cc: stable@dpdk.org

Signed-off-by: Dengdui Huang <huangdengdui@huawei.com>
Acked-by: Chengwen Feng <fengchengwen@huawei.com>
Acked-by: Morten Brørup <mb@smartsharesystems.com>
---
 drivers/common/cnxk/roc_dev.c   | 6 ++++--
 drivers/common/cnxk/roc_model.c | 4 +++-
 drivers/common/cnxk/roc_utils.c | 4 +++-
 3 files changed, 10 insertions(+), 4 deletions(-)

diff mbox series

Patch

diff --git a/drivers/common/cnxk/roc_dev.c b/drivers/common/cnxk/roc_dev.c
index c905d35ea6..94a4f62ce1 100644
--- a/drivers/common/cnxk/roc_dev.c
+++ b/drivers/common/cnxk/roc_dev.c
@@ -8,6 +8,8 @@ 
 #include <sys/mman.h>
 #include <unistd.h>
 
+#include <rte_errno.h>
+
 #include "roc_api.h"
 #include "roc_priv.h"
 
@@ -1323,7 +1325,7 @@  cn20k_pfvf_mbox_alloc(struct dev *dev, uint16_t max_vfs)
 
 	mz = plt_memzone_reserve_aligned(name, vf_mbox_region, 0, MBOX_SIZE);
 	if (!mz) {
-		plt_err("Memory alloc failed: %s", strerror(errno));
+		plt_err("Memory alloc failed: %s", rte_strerror(errno));
 		goto fail;
 	}
 
@@ -1445,7 +1447,7 @@  dev_lmt_setup(struct dev *dev)
 	 */
 	mz = plt_lmt_region_reserve_aligned(name, LMT_REGION_SIZE, LMT_REGION_SIZE);
 	if (!mz) {
-		plt_err("Memory alloc failed: %s", strerror(errno));
+		plt_err("Memory alloc failed: %s", rte_strerror(errno));
 		goto fail;
 	}
 
diff --git a/drivers/common/cnxk/roc_model.c b/drivers/common/cnxk/roc_model.c
index 6289461db4..da0664afdb 100644
--- a/drivers/common/cnxk/roc_model.c
+++ b/drivers/common/cnxk/roc_model.c
@@ -6,6 +6,8 @@ 
 #include <fcntl.h>
 #include <unistd.h>
 
+#include <rte_errno.h>
+
 #include "roc_api.h"
 #include "roc_priv.h"
 
@@ -157,7 +159,7 @@  cn10k_part_pass_get(uint32_t *part, uint32_t *pass)
 	dir = opendir(SYSFS_PCI_DEVICES);
 	if (dir == NULL) {
 		plt_err("%s(): opendir failed: %s", __func__,
-			strerror(errno));
+			rte_strerror(errno));
 		return -errno;
 	}
 
diff --git a/drivers/common/cnxk/roc_utils.c b/drivers/common/cnxk/roc_utils.c
index 9af2ae9b69..418cd6b477 100644
--- a/drivers/common/cnxk/roc_utils.c
+++ b/drivers/common/cnxk/roc_utils.c
@@ -2,6 +2,8 @@ 
  * Copyright(C) 2021 Marvell.
  */
 
+#include <rte_errno.h>
+
 #include "roc_api.h"
 #include "roc_priv.h"
 
@@ -245,7 +247,7 @@  roc_error_msg_get(int errorcode)
 		 * Handle general error (as defined in linux errno.h)
 		 */
 		if (abs(errorcode) < 300)
-			err_msg = strerror(abs(errorcode));
+			err_msg = rte_strerror(abs(errorcode));
 		else
 			err_msg = "Unknown error code";
 		break;