From patchwork Mon Oct 7 19:33:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Serhii Iliushyk X-Patchwork-Id: 145318 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F4A845AD8; Mon, 7 Oct 2024 21:35:32 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 743034065C; Mon, 7 Oct 2024 21:35:13 +0200 (CEST) Received: from egress-ip11b.ess.de.barracuda.com (egress-ip11b.ess.de.barracuda.com [18.185.115.215]) by mails.dpdk.org (Postfix) with ESMTP id 6BC3D4060C for ; Mon, 7 Oct 2024 21:35:10 +0200 (CEST) Received: from EUR05-AM6-obe.outbound.protection.outlook.com (mail-am6eur05lp2111.outbound.protection.outlook.com [104.47.18.111]) by mx-outbound18-114.eu-central-1b.ess.aws.cudaops.com (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Mon, 07 Oct 2024 19:35:09 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=ENN2I6hvRDN217tdkJ3Jr2noaXJpTn9jT7bP+jm1Fsd2nygiZea96RSugN1f05v5ksJrQO5U2xud7RByli3c2uhDno9RfRxzmZwcJopLcM7q1Pj76auTbmIBBx7H9XBYjdOBlHPoE4sDfkK8AQSJIV15LgqUJECGArWEXMXpd0gCI8IbJWjyXGiWH/PSR6lTkephIOyoefuCiavPXBr8HWEA1Xwo0EA3NdW3sgljM86rFdi68yRoxqXRZ+tLVfSprwm51DL7uoQZWKFuRdElxRSaIJP8XLzy0I/OI6NTXOFM/vderCLWImy6VlIs6EEjeF/qtlL3gI3tEn79ewtxnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=CCP8cSNkABk20YAdxFV/vjKLwMJ8dAG//nDFj5K1Rlk=; b=gD0WrNAZ1ObXUrgnU3oo1jzbBayOvE9eIxtt/E9THU7siVr0ARZ3GaZrWktiQb7u0wmIO9GLUM12NJjb0zU/KDtMBXmdrEk1IE658fNgauFcrIOrmbzHKBAtW/oCVATGuQidhL9Zk7GW3w9p68RcnxuWXOhlLQkW6rYfF2xLw5imoBL5hKvvgdv24sxMVrwAAC9+EVZus+eNB+FnmvLex1wFSVe/m2+um5Nt/JEc3/mQpobIb2MP87fSgEQ8nu50oOzyu59fkVgrDEOvr8/tTCuiV9zu0TsOOZvi08z3sTjm5l0Nd0YngQ0YWTqQ9YwJUPl3tE075w4LZCC4OBedHQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=fail (sender ip is 178.72.21.4) smtp.rcpttodomain=dpdk.org smtp.mailfrom=napatech.com; dmarc=fail (p=reject sp=reject pct=100) action=oreject header.from=napatech.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=napatech.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CCP8cSNkABk20YAdxFV/vjKLwMJ8dAG//nDFj5K1Rlk=; b=M/tTuAKzEo7fL9IpdJBCrm3FU5OGYoQ9bme51t7rE1hyc7syvb8vXdwQ1xfu2XTOfjraDqEjaYxsq26LQq/zoztA1Xu34fOwdINKvq911/qKPDEfsPv2h8QbHEO9eFxXbkzzmaRW2RNr4dInjcVqtARhHf4waceKjOO3ozwkrLg= Received: from DB9PR05CA0008.eurprd05.prod.outlook.com (2603:10a6:10:1da::13) by VI2P190MB2239.EURP190.PROD.OUTLOOK.COM (2603:10a6:800:278::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8026.22; Mon, 7 Oct 2024 19:35:05 +0000 Received: from DB1PEPF000509EC.eurprd03.prod.outlook.com (2603:10a6:10:1da:cafe::94) by DB9PR05CA0008.outlook.office365.com (2603:10a6:10:1da::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7982.34 via Frontend Transport; Mon, 7 Oct 2024 19:35:05 +0000 X-MS-Exchange-Authentication-Results: spf=fail (sender IP is 178.72.21.4) smtp.mailfrom=napatech.com; dkim=none (message not signed) header.d=none;dmarc=fail action=oreject header.from=napatech.com; Received-SPF: Fail (protection.outlook.com: domain of napatech.com does not designate 178.72.21.4 as permitted sender) receiver=protection.outlook.com; client-ip=178.72.21.4; helo=localhost.localdomain; Received: from localhost.localdomain (178.72.21.4) by DB1PEPF000509EC.mail.protection.outlook.com (10.167.242.70) with Microsoft SMTP Server id 15.20.8048.13 via Frontend Transport; Mon, 7 Oct 2024 19:35:04 +0000 From: Serhii Iliushyk To: dev@dpdk.org Cc: mko-plv@napatech.com, sil-plv@napatech.com, ckm@napatech.com, andrew.rybchenko@oktetlabs.ru, ferruh.yigit@amd.com, Oleksandr Kolomeiets Subject: [PATCH v2 04/50] net/ntnic: remove extra calling of the API for release port Date: Mon, 7 Oct 2024 21:33:40 +0200 Message-ID: <20241007193436.675785-5-sil-plv@napatech.com> X-Mailer: git-send-email 2.45.0 In-Reply-To: <20241007193436.675785-1-sil-plv@napatech.com> References: <20241006203728.330792-2-sil-plv@napatech.com> <20241007193436.675785-1-sil-plv@napatech.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DB1PEPF000509EC:EE_|VI2P190MB2239:EE_ X-MS-Office365-Filtering-Correlation-Id: 5b0f33f2-9975-4274-587f-08dce70724ef X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|376014|1800799024|36860700013|82310400026; X-Microsoft-Antispam-Message-Info: 8QSGLY0op353SJwLvs49NAxK4htRcxIoGr852048fcBKsY2aTTnS9x9yzYHm1xbCzEYMB4UgXlkHUlV1l/RLzEVWWFxYVh4F5RfiIgWYY5TAP3RFlUQDP8zwUHR0sN28Cbdr0gCtbjFrI8jUidwp68ExadtYOLVbcyOgP7Kjd9nJrqK5cW9t9hzAxJIInr4A6gYuiRuZce9VtNdKYgzB5GApbHQqLQsSwUvyz23dI12YjJW6cxCSMsQ5XrWvv7dSu5nYPR8+BoaVB9qoybgljqg4JZA26DeRFWbeaNLWoABQRbytZ1vEX0Ubr0jyqoKK3955n+11g0NCn92px7fiWbOa34DghomV8LS3FisVC76NPh1Jv56Zy61PYmX4aT3m0Ta+6GLtJEtWze4C6+p53tWbwTm2NUwDpQMp42punKrS8gxw7jNN1n9q9t8Qy6B5vVaYeJZYg1lr22qA0EsnWhJeXXtqaxe0rRWRTGjhI5/92GcEpZhK/QoYsJjyrNroyl+OyV/i+RZszw7vxGCpREzMdKTnmGAYohwi+m2JhdnpXlO+MnZvmh5KUblMZbpERiC2ebqGV28sITvYkkhSWRJRuW6W61h1/UbjqfNg2E6aDIHfAkWF9bEa9VJH856lVTCxnrW/di8oY1gdrMnTvQfSOhTfCvejNpO2VnYht/zL5p7xvqp7sc3rrTifZPqZAE6V6eflayYuYeJvjSCBz2ZC9Us5sYa5zXxIqWuiee4+zIy99O4XUrJF0Ejj1/vKrpur2mbiouRN+EP4nkQ5N0dgEuW0SXvwkZJTatrwsuHG4zhzAJ7MLmaCHgmAWunpMeeNjhHdOzI1EsCB2qU+oIhEGWV69HmqoJIW6Q22aXX/Zh6F1bK4XOwxcA1jfhf0I6MKVzNDhBCCxCPQC/zi2o85uzmsOICy8FwxqOeTjA5ZvBkmZUK2Bo83J2a0I9ZrC8F0alG4Paql8ktkUCKcB8X7H0tI1sWRUB7kM+TBuaZp44LUxpVPR4fmEX/2gjUeufk66GJ6ylXpf27UiaJ7H4TnGyqj0lGGJuURVH9iV4Kkmw4GpAqXsGo9b+pfGYI9a6AxJ14aUahKXpO9bB9p+GSzE/kzzxhkGAB0vgNC8fOXYLdMOh48VpfdOLphMvSYKuxwjP1AKa0GWXhBYZywZv1ARcKst8N1uNOVIYgqasXcaCUMiWP93R4xc7+qcGYjzW0MmqYdSdihTtTq3OxbvA7TwgV3ap4+tdS3AWCuz3tkIG11rQJtIjyhvyp4gyVm2Fw7D0S6L6vS/mN6C/3XWOye0aVZqcC3h7qP/sIde8MuV/ryH6b46yj+GE6wAKdXf3XbcsdMsqvDN5dnTplfj+vplz/ZKKxX/ys/y1ogg2I= X-Forefront-Antispam-Report: CIP:178.72.21.4; CTRY:DK; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:localhost.localdomain; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230040)(376014)(1800799024)(36860700013)(82310400026); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: WAHHCbEnbqCh2BwjbfNkT0iZsd6ItewpbVqcwR5wtZ3hnvSTqi9aT4ZOvG0hqLr+4RNnyQeCPtj9Ly9iAaKK0zC0xcsIVcd/8/FiLpFIlypQNN3DtKOQf9OLUKyczA7OzZr8SEMnO2I45K+2khwCpKWuSmG069f+f3oEXKdfaW0O6YgZfZ4PuZxwZs25UpD4Yw6sSDjeipcKJQGWIvubdXP+VpcJbUVt+kZEDYOLuorem4cHY8xOWHONI3lLAi4rg3J8W9y2ue5e9LO8Z9MCzS2V+QiZ5ase6CRCwSi3R/f5UhVOKX4NVuvqkAbqpQr1jkt+p5qPK8ZqDcdZRQTus0dmiCdCAcObiSxZUPwSOgbED2wtNZp89QSvMZsRRzlKTNb2sMOJaNDahlGd+r+tBYFT84JqSXCgj2Cp+VmVr1OTwDpfByH/+oWwOq+Lfq0urKRj13xrZ5ob+jJFyK2nam7+oL0JIFr859+DQk71lSReg+VPNAJ9R9up2FUdeQmxOO4gAN9o5GRpeNYla4Dl39s3f8klhU5z/aOiv8wBMEqgfsOPC+a4CYEp3K4Y/qOP4itYn6MLFuZJHPHJ3gJ4ul2SfUfzuZxwUDwfcSF21NCvj5TdRTmwbqfRh8Zf0j/IoWJCzO5691HEu0/gdo0D/A== X-OriginatorOrg: napatech.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Oct 2024 19:35:04.7408 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5b0f33f2-9975-4274-587f-08dce70724ef X-MS-Exchange-CrossTenant-Id: c4540d0b-728a-4233-9da5-9ea30c7ec3ed X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=c4540d0b-728a-4233-9da5-9ea30c7ec3ed; Ip=[178.72.21.4]; Helo=[localhost.localdomain] X-MS-Exchange-CrossTenant-AuthSource: DB1PEPF000509EC.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2P190MB2239 X-BESS-ID: 1728329708-304722-4001-4089-2 X-BESS-VER: 2019.1_20241004.2057 X-BESS-Apparent-Source-IP: 104.47.18.111 X-BESS-Parts: H4sIAAAAAAACA4uuVkqtKFGyUioBkjpK+cVKVoYmBoZAVgZQMMksySAtxdTEIs nQIiXZIDHR3NLY1CDNKDk51SDZwMhcqTYWAJG0Go5BAAAA X-BESS-Outbound-Spam-Score: 0.00 X-BESS-Outbound-Spam-Report: Code version 3.2, rules version 3.2.2.259566 [from cloudscan16-140.eu-central-1b.ess.aws.cudaops.com] Rule breakdown below pts rule name description ---- ---------------------- -------------------------------- 0.00 BSF_BESS_OUTBOUND META: BESS Outbound X-BESS-Outbound-Spam-Status: SCORE=0.00 using account:ESS113687 scores of KILL_LEVEL=7.0 tests=BSF_BESS_OUTBOUND X-BESS-BRTS-Status: 1 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Oleksandr Kolomeiets During rte_eth_dev_close execution, eth_dev_close function exported by ntnic is called, followed by a call to rte_eth_dev_release_port. Since there is no possible returns between the calls, calling rte_eth_dev_release_port from eth_dev_close is redundant and error-prone. Signed-off-by: Oleksandr Kolomeiets --- v2 * Update release notes --- doc/guides/rel_notes/release_24_11.rst | 1 + drivers/net/ntnic/ntnic_ethdev.c | 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/guides/rel_notes/release_24_11.rst b/doc/guides/rel_notes/release_24_11.rst index e85549c1e1..c808639ee9 100644 --- a/doc/guides/rel_notes/release_24_11.rst +++ b/doc/guides/rel_notes/release_24_11.rst @@ -102,6 +102,7 @@ New Features * Update supported version of the FPGA to 9563.55.49 * Fix Coverity issues + * Fix issues related to release 24.07 Removed Items ------------- diff --git a/drivers/net/ntnic/ntnic_ethdev.c b/drivers/net/ntnic/ntnic_ethdev.c index f351469d0a..52ca8f2844 100644 --- a/drivers/net/ntnic/ntnic_ethdev.c +++ b/drivers/net/ntnic/ntnic_ethdev.c @@ -383,7 +383,6 @@ eth_dev_close(struct rte_eth_dev *eth_dev) internals->p_drv = NULL; - rte_eth_dev_release_port(eth_dev); if (p_drv) { /* decrease initialized ethernet devices */ p_drv->n_eth_dev_init_count--;