From patchwork Tue Aug 6 13:42:18 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gagandeep Singh X-Patchwork-Id: 142957 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 587F34574D; Tue, 6 Aug 2024 15:42:55 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3E34242F65; Tue, 6 Aug 2024 15:42:40 +0200 (CEST) Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2057.outbound.protection.outlook.com [40.107.104.57]) by mails.dpdk.org (Postfix) with ESMTP id 6D9BB42F1B for ; Tue, 6 Aug 2024 15:42:38 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=F/D0f0PJJpyGvHZFsKUa65FbS54MeCH76lcpJWVRLUK3SMFL+uSaYPQnIVHh8YgbfF5Dp2tP1FdFrib5CUFsS959RsAoa8smZuIfUhZzdOJVGYrW91BdsQVtLnWZZXvquUf/kiY+hig6X/n8yy3ZnEAR8BnPTDKT54PTd0r1j4uq5VBcBAAk87KLC54bHhkKNJhDYpmJee7HeXTwXoq4xTNzJq5LDt+2Hx3k3q/TO/QqZL9W3+2D7SW/mv6bgjXYabxvhSO3mYyDFHU7WRpjYid2C7n9YrOWzIjTjtnfVsWe5n4oWDW5ewz8Ay3QXqBKsLFZo1RpEzNK8Ya9PxkPag== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=+8SymFCDZLjZGn/JObFCdRHf+9zWIwlkelPGrRIZ6nM=; b=wdlpQ6wZ6tboWExQxSGBig/DKyS85pU4HqrkUM4685thYuTFtSM9/MPFKrf7bNN4IsJl5Lznmy7udSW6pYJuRUnSfSLaBAUa5ueTsKKjUGXY1ZdA0zu0Bq4rRvPIVKf8U7mjISmJPe4pmmKnOzcRsnaUpMjaZLzgjF+81ICf7oBjvCwZQAc+VU8KdU9c6pGTsE9y6YU9fVEoYTdmqoW2W4r0M7i7b0ZAYVEB8X9c4URxL602Z/bDOvniGOhcrahMmfpOccTKipCLfz1Hy+WNMk24/FeWNyNgFJRyurVOI6zCB9MGFVd2+DoDeerIRVP18bOf6i/DBiqKSy537YBLhA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=+8SymFCDZLjZGn/JObFCdRHf+9zWIwlkelPGrRIZ6nM=; b=DFSyNHb5PrJOB5TCPsP9R9M+VX4sVbfjWIP+ramMGCtaG7fqoxYia2rXqJ7qXT+0vHZ9LExJYprvSp0bvNugSkvKLwjF53QBq3beHZh5KrXswYZahjWklNyYYsNQx+ZHBo00sR1nBUGFvG16hKnxGquCXKLxSB08GG0M17NYjWmNKOoX1BHYrRse10lAijWeVD9jWS/qHi+a/vkhTt8Gc7gw19YKQYViGW5RVdP/Dciykx9qXTfqeiqN0L0oV0FXlsGftmwqqt3uA7FWN/tmAbvxSTFUjSgchtVhdeEmjeeuF4m4QnZf0lhH5UdSU849+EcdT7P9TR7DlE19brvCcw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from AS8SPR01MB0024.eurprd04.prod.outlook.com (2603:10a6:20b:3d0::24) by DBBPR04MB7900.eurprd04.prod.outlook.com (2603:10a6:10:1e8::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7828.26; Tue, 6 Aug 2024 13:42:37 +0000 Received: from AS8SPR01MB0024.eurprd04.prod.outlook.com ([fe80::c634:479e:8f8a:a325]) by AS8SPR01MB0024.eurprd04.prod.outlook.com ([fe80::c634:479e:8f8a:a325%7]) with mapi id 15.20.7828.023; Tue, 6 Aug 2024 13:42:36 +0000 From: Gagandeep Singh To: dev@dpdk.org, Bruce Richardson Subject: [v1 3/3] meson: skip symlinks to PMDs script on no sub directory Date: Tue, 6 Aug 2024 19:12:18 +0530 Message-Id: <20240806134218.3619913-4-g.singh@nxp.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20240806134218.3619913-1-g.singh@nxp.com> References: <20240806134218.3619913-1-g.singh@nxp.com> X-ClientProxiedBy: SI2PR02CA0004.apcprd02.prod.outlook.com (2603:1096:4:194::14) To AS8SPR01MB0024.eurprd04.prod.outlook.com (2603:10a6:20b:3d0::24) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AS8SPR01MB0024:EE_|DBBPR04MB7900:EE_ X-MS-Office365-Filtering-Correlation-Id: 84c1a6f9-83e5-443f-61c2-08dcb61da1e8 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|52116014|376014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: mTzlPrRXkK83Y5x15VjMIaOUGTL2Chkt4OxflMy+adPKpllM3kh/K9nQ+txFj76mcmZtgFzxp/R05rZ1aU/okVi5uqMQw5CG78Crusm5F/F4LV3XTFYGtirZOvZFyQE1SdUHljpZhDK2RnlinETPmTW6ZxK194+COTKyWi8sX8+DadG3mhOi4W2DhTl0YEu6UJd4XF2gjFYA0wG1o0fhuCjniYNu6n1P/nVFkH+JYmYoe48j7Ax0BjabWNyoMNHHy+lq2tVyplpODi+km6eiItdtUXgGiRx2kh8lPbv4ePXx3V5SvioBaRuuIbyaC2Qu3dSf8io6aFlU1JtkZHEGwqm46cJBzcSA8bxty6Rl5MvYjHbSqpuJBiI4nqF2eq8n2hV+5noRn1hWr9+zKdkvqG7jJ1d3jTqS+aOmDVRoyjmSB9D5JV55Zy8HS0Mut6xIsRyENTcGxsxLvURv5b/HZY+qxmu+sAqUNUcpe1JBeZQ1Q/AvWEmLuOp1ysRfiEiUqNjzg9rAV24adgUoaO6tBhVnw+nzUAOwV/pkKI2CTNwq5hXZ5XRe1H43YVJ5ensIgfQuPxdC80YcD2yKRYgXxPiUrmEf1LRYqwokc+7Ml+5KxkPR8UWY9MGe3j9B8myt0oZfailcavTf2OY+58uyO7OgqFruc43oGwBNBi0QjsfkiT7NZ1QwF/18gC15TDilPNE8s22Hiz66RKqCtSS7f5xBspsSsgdD8OrBV9JDNUga6KHwS6e6Ncqa97fxtMFQwfkZV+FXl8VtYKvaeEXKy8FIoq+TirBvkbHpn4Iar2DNpDwQ3EPW4Ul8R10AgQzvmO3q1C+h9JCHqr67c6oPCWS7o4L1bxgow8WFWgY4SIiBTyvCMyZ6J/DjKty18l19GPwrxjDOXV1pRpRenUOL54luX1Q6r8uLHvBkhqNLAvdwZZdiU2VKmIcvEN+nD5bX0Ro4E1g5OKVopK0DFGq/RrRFMOdh4tpOw+0jOJoeMLDGhyrY1E0oFjDiu/WXSMPY2qcxiWLY3KYy0DT1fD+q6lWTfwkva0QNhmGNbADMl5L24jKEaOHRtv+wEavzq5N5rVWk9RzPXI7CCy7rw4q7faweuCswG2yex4Gy0yZ9ZTKVlq+vg8JqJAn4tQrIrYHavsDE2CBW/mF1z32HX8FHLrOdmiTLhHfX4m45Jdd1ebvHx37lX6T8mbdN54xWkoiL321gYzDKn0FiEh345OKYjdkFQ4jlFmcFju02ZvbfbccaSP3KAtEeKkTsHyZwIdq4nxgQ9c1OHUiqglE2UOvgIPbTZSvacRNG7FK7Urrfe8qeq2GLr3zo3Q860/xQ5eIjMwVJjC0LDKhjXBQqGlnzLjQGzG2u1/CHxgf8eutausoqp14ClFht9qsvweva5o+aY2Xd2npJsY+U2EaUkL3Yxw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:AS8SPR01MB0024.eurprd04.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(52116014)(376014)(366016)(1800799024)(38350700014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: KghA/3OkUbX5iZm05hzwisk2ivn36SijYiUGuWOw1jOliJd8BF1I96ccv3nzXbqat26Wgc6Vz23TLDrP+fgJhXQAPOzIek3kbpg0C0F5tcLfJR4RBjsgQiGpQNANuCjID5/6GGFTj4zLnh3FAjb6ntDpc2ggc7PzUdqYcgdclWEpPAUEfwu6PXrYMXyC34NexplOgzx7UGEc3ui7TP5AZztZq96bPQrKskt6JCPHnm7pO9U1jjiIZ3YDqV1U/vX0AZtvrYg46pXjdEEH7GDOo63xzQjWzLBQnok/rd4f3cZl+DWCaGfMkV3bzUHDAa49qHPuHf5HkxF8qerIZRObuNKtXOFaeP2TRs1A9YOek5+Yf3qV+9tiJ0C4wCEn0MpzdOY9r8OCZaneAFzUMxUMS9vD2rH6oY2vz1CRpvDf2i8FrPtFSv6s61Y7D5NlmeBWfyAGNOZHtZBZI4MaPI03P6OqWdJOvOVNG77PGCLnUCHRAGOIv7nI9AaanYKUv9xJLDEY8+GWrGuvdhYsJyzp4DoKfqSXeXZaBmFHsSVq5kxrm0M4Nv2cuIPUyoqBBsL8zS7EXRMiRQvjnGw1jTZRM62W56AiEO1rs5nXlazDh4U+NhBtj8/Ylkz6qolkQ5f8VtBcwoAq2efZ14eNpIUfpkDezivfWTJ4ifOEOan9N9ayBGDDpQRce6nXNo2Z4nwXkMrKAu4EtGUcICb84ffmLF5D+PXGViXaeWTns17SFXO6ZxDPn9foxhn9KQGMBnqG7AIszsuQHpucKNy990QOVWTNWP3mO0lOdliDk7fLUsk+aodGwpGmJ1jWDKoyJ1EtsLJV/lhdcvStlG43GMsg+GitBm/NygSgbW7o95yfA+rplWxlmnbSbg/QyjjorNav2P2E6DDSg22O6JQfOeISaP7vx2cYv/mPHQAAIJ9nA5L7nVjwp0cXfHsjb1WIxwYiqOUONJUlMWJ9F4/4dXKAo+k6gJGLr+jdHp5gQFUTQNq+2YuJcW7CKxJWnSFF8w4VM8F6wZHXVABJb+YP+QxNhKKCUhFGVp7/RPn2g35P4sVomh1MV+rXise1uPNB3GLABW3mQpnqESXOvJ5eIFBqkR0L5e+TA3dsbI3pndzZb1buEyFqcElfqPW5NTSU6CoGL3dDdfQ/r7DRWyCKaihqxMqycHX7dr/c59aLvdX3OlzSNNtf5zpWogMnXZoj3OTEv/GiPjTSNE7lSHYeUC+uInCxlreVlEt9cZKqBdUFixvmBlu8iyIgLkYt+oBE7ti2flCaDm7zO+t+itH0qXnQdndSF4DnIq6SyB63RN17tP9a5hhA152v2PKCsMwi01arttay1bFxEfwrNKulKaSSgPczq0dZegZibk3HxAYOxU8LogqoF9e6idHPcfLNcLM+iFD9MH6glgfhrJSX/+VjpK60/HtpXRiUuGMcswrONQ9uyaE3vwhmDSkhBFEarRrXMIUJ+5Fgezp1hvBzQT2R3Dc+cjGHYQzJNBZEcDnHoBXGfpepv7+Q5lvRnwzqM2z/IDbFcQlDtbDG6e6pjbElFfvJ6sYeNZQtmIJ17ah8JFM1r22G34dVILW9o8cZT8Ky X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 84c1a6f9-83e5-443f-61c2-08dcb61da1e8 X-MS-Exchange-CrossTenant-AuthSource: AS8SPR01MB0024.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Aug 2024 13:42:36.8442 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 9Fx0N5W8NADUptcsC0/3ZWEDV/mGVS2KYizdhbR9F3gJYqd5gXCiMROE2+pANFxD X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7900 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org if user gives option -Ddrivers_install_subdir= or -Ddrivers_install_subdir=. to install all the PMDs in parent directory, The post installation script "symlink-drivers-solibs.sh" can create invalid library file named 'librte_*.so*' or meson installation errors: ln: './librte_*' and './librte_*' are the same file FAILED: install script '/bin/sh /home/nxa12342/upstream/dpdk/config/. /buildtools/symlink-drivers-solibs.sh lib/x86_64-linux-gnu .' exit code 1, stopped FAILED: meson-install This patch removes this post-install script execution to symlink the PMDs libraries when no sub directory is given. Signed-off-by: Gagandeep Singh Acked-by: Bruce Richardson --- config/meson.build | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/config/meson.build b/config/meson.build index 8c8b019c25..4c1c6848ad 100644 --- a/config/meson.build +++ b/config/meson.build @@ -95,8 +95,11 @@ eal_pmd_path = join_paths(get_option('prefix'), driver_install_path) # e.g. ixgbe depends on librte_bus_pci. This means that the bus drivers need # to be in the library path, so symlink the drivers from the main lib directory. if not is_windows - meson.add_install_script('../buildtools/symlink-drivers-solibs.sh', - get_option('libdir'), pmd_subdir_opt) + # skip symlink-drivers-solibs.sh execution on no sub directory + if pmd_subdir_opt != '' and pmd_subdir_opt != '.' + meson.add_install_script('../buildtools/symlink-drivers-solibs.sh', + get_option('libdir'), pmd_subdir_opt) + endif elif meson.version().version_compare('>=0.55.0') # 0.55.0 is required to use external program with add_install_script meson.add_install_script(py3,