diff mbox series

[v5,2/3] dts: dynamic config conf schema

Message ID 20240724192129.29721-3-dmarx@iol.unh.edu (mailing list archive)
State Superseded
Delegated to: Juraj Linkeš
Headers
Series dts: refactored dynamic config test suite |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Dean Marx July 24, 2024, 7:21 p.m. UTC 
configuration schema to run dynamic configuration test suite.

Signed-off-by: Dean Marx <dmarx@iol.unh.edu>
---
 dts/framework/config/conf_yaml_schema.json | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Jeremy Spewock July 26, 2024, 7:35 p.m. UTC | #1 
On Wed, Jul 24, 2024 at 3:21 PM Dean Marx <dmarx@iol.unh.edu> wrote:
>
> configuration schema to run dynamic configuration test suite.
>
> Signed-off-by: Dean Marx <dmarx@iol.unh.edu>

Reviewed-by: Jeremy Spewock <jspewock@iol.unh.edu>
Luca Vizzarro Aug. 7, 2024, 3:56 p.m. UTC | #2 
Similar to my other reply.

Please follow contributing guidelines when writing your commit subject 
and body[1]. For example, an imperative subject:

   dts: add dynamic config test to conf schema

Moreover, is there a reason to split this from the test suite commit?

Thanks,

Luca

[1] 
https://doc.dpdk.org/guides/contributing/patches.html#commit-messages-subject-line
diff mbox series

Patch

diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json
index f02a310bb5..d7b4afed7d 100644
--- a/dts/framework/config/conf_yaml_schema.json
+++ b/dts/framework/config/conf_yaml_schema.json
@@ -187,7 +187,8 @@ 
       "enum": [
         "hello_world",
         "os_udp",
-        "pmd_buffer_scatter"
+        "pmd_buffer_scatter",
+        "dynamic_config"
       ]
     },
     "test_target": {