diff mbox series

[12/19] net/txgbe: correct valid MTU range

Message ID	20240618071150.21564-13-jiawenwu@trustnetic.com (mailing list archive)
State	Accepted, archived
Delegated to:	Ferruh Yigit
Headers	From: Jiawen Wu <jiawenwu@trustnetic.com> To: dev@dpdk.org Cc: Jiawen Wu <jiawenwu@trustnetic.com>, stable@dpdk.org Subject: [PATCH 12/19] net/txgbe: correct valid MTU range Date: Tue, 18 Jun 2024 15:11:43 +0800 Message-Id: <20240618071150.21564-13-jiawenwu@trustnetic.com> In-Reply-To: <20240618071150.21564-1-jiawenwu@trustnetic.com> References: <20240618071150.21564-1-jiawenwu@trustnetic.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Feedback-ID: bizesmtpsz:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz8a-1 Precedence: list Errors-To: dev-bounces@dpdk.org
Series	Wangxun fixes and supports \| [00/19] Wangxun fixes and supports [01/19] net/txgbe: fix to parse tunnel packets [02/19] net/txgbe: fix flow filters in VT mode [03/19] net/txgbe: fix Tx hang on queue disable [04/19] net/txgbe: restrict the configuration of VLAN strip offload [05/19] net/txgbe: reconfigure more MAC Rx registers [06/19] net/txgbe: fix VF promiscuous and allmulticast [07/19] net/ngbe: special config for YT8531SH-CA PHY [08/19] net/ngbe: keep PHY power down while device probing [09/19] net/ngbe: add WOL and NCSI capability [10/19] net/txgbe: fix hotplug remove [11/19] net/ngbe: fix hotplug remove [12/19] net/txgbe: correct valid MTU range [13/19] net/ngbe: correct valid MTU range [14/19] net/txgbe: fix memory leak [15/19] net/ngbe: fix memory leak [16/19] net/txgbe: fix Rx interrupt [17/19] net/ngbe: support Rx interrupt [18/19] net/txgbe: disable LLDP by default [19/19] net/ngbe: disable LLDP by default

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Jiawen Wu June 18, 2024, 7:11 a.m. UTC

The valid range of MTU is 68 to 9414. Set min_mtu and max_mtu in dev_info.

Fixes: 3926214fd80d ("net/txgbe: support MTU set")
Cc: stable@dpdk.org

Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>
---
 drivers/net/txgbe/txgbe_ethdev.c | 12 +++++-------
 drivers/net/txgbe/txgbe_ethdev.h |  2 +-
 2 files changed, 6 insertions(+), 8 deletions(-)

diff mbox series

Patch

diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 20fa0a5b05..c2df5a314b 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -2670,7 +2670,9 @@  txgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
 	dev_info->max_rx_queues = (uint16_t)hw->mac.max_rx_queues;
 	dev_info->max_tx_queues = (uint16_t)hw->mac.max_tx_queues;
 	dev_info->min_rx_bufsize = 1024;
-	dev_info->max_rx_pktlen = 15872;
+	dev_info->max_rx_pktlen = TXGBE_MAX_MTU + TXGBE_ETH_OVERHEAD;
+	dev_info->min_mtu = RTE_ETHER_MIN_MTU;
+	dev_info->max_mtu = TXGBE_MAX_MTU;
 	dev_info->max_mac_addrs = hw->mac.num_rar_entries;
 	dev_info->max_hash_mac_addrs = TXGBE_VMDQ_NUM_UC_MAC;
 	dev_info->max_vfs = pci_dev->max_vfs;
@@ -3694,12 +3696,8 @@  txgbe_dev_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)
 		return -EINVAL;
 	}
 
-	if (hw->mode)
-		wr32m(hw, TXGBE_FRMSZ, TXGBE_FRMSZ_MAX_MASK,
-			TXGBE_FRAME_SIZE_MAX);
-	else
-		wr32m(hw, TXGBE_FRMSZ, TXGBE_FRMSZ_MAX_MASK,
-			TXGBE_FRMSZ_MAX(frame_size));
+	wr32m(hw, TXGBE_FRMSZ, TXGBE_FRMSZ_MAX_MASK,
+		TXGBE_FRMSZ_MAX(frame_size));
 
 	return 0;
 }
diff --git a/drivers/net/txgbe/txgbe_ethdev.h b/drivers/net/txgbe/txgbe_ethdev.h
index 050acd967f..f0f4ced5b0 100644
--- a/drivers/net/txgbe/txgbe_ethdev.h
+++ b/drivers/net/txgbe/txgbe_ethdev.h
@@ -56,7 +56,7 @@ 
 #define TXGBE_5TUPLE_MAX_PRI            7
 #define TXGBE_5TUPLE_MIN_PRI            1
 
-
+#define TXGBE_MAX_MTU			9414
 /* The overhead from MTU to max frame size. */
 #define TXGBE_ETH_OVERHEAD (RTE_ETHER_HDR_LEN + RTE_ETHER_CRC_LEN)