From patchwork Tue May 14 08:41:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Loftus, Ciara" X-Patchwork-Id: 140051 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7558B4402A; Tue, 14 May 2024 10:43:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 448AC406BA; Tue, 14 May 2024 10:43:10 +0200 (CEST) Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.16]) by mails.dpdk.org (Postfix) with ESMTP id 6CC6A40691; Tue, 14 May 2024 10:43:07 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1715676188; x=1747212188; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=1MuK9jCMTS+LjUSE8ZpybKx+tMghi7MEWx2lV12za/M=; b=YaXntx7OIrYDzbH+IZfoTU5EofTYM760Ve4m2DUzNAelG6bXtkqDwSCE kzpNeZHE65HYj1zC78RBVVhcMdAwZLdmz+8DCdPTLHxIEyNSyiDQnNmjs eANMPTY+9emhFAgSVCRMc5NHjYFsBnX77R4GJvHvaVQEZ09I6ZZQBl/gB 0Ulkx9d6YavM2ZYv89afRQu+R743VVk1DZv3hVLU8spMCLxj/EdiZ5P0A Ljtrcj/zJJRpPcrQGsnS7dwth90+HGyZR1AfRq03ZDHqyVn/RsRVLPYPJ fP83AjbCbBpvYo8JJa4VpMhu4qmPh0nAysirFLGP1LVVFL7WczC3WOHL7 Q==; X-CSE-ConnectionGUID: OHgH2mrXS3eIFMpc9MEk0g== X-CSE-MsgGUID: g3UXUr+lRJeIDTg8X2oFTQ== X-IronPort-AV: E=McAfee;i="6600,9927,11072"; a="11513818" X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="11513818" Received: from fmviesa006.fm.intel.com ([10.60.135.146]) by fmvoesa110.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 May 2024 01:43:07 -0700 X-CSE-ConnectionGUID: 9XReDPuGTM2zVvFqSvdHbA== X-CSE-MsgGUID: xuU8MFpISYm6xpoSESxrEA== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.08,159,1712646000"; d="scan'208";a="30657443" Received: from silpixa00401177.ir.intel.com (HELO vm177..) ([10.55.128.139]) by fmviesa006.fm.intel.com with ESMTP; 14 May 2024 01:43:06 -0700 From: Ciara Loftus To: dev@dpdk.org Cc: Ciara Loftus , stable@dpdk.org, Stephen Hemminger Subject: [PATCH v2 4/4] net/af_xdp: remove unused local statistic Date: Tue, 14 May 2024 08:41:55 +0000 Message-Id: <20240514084155.50673-5-ciara.loftus@intel.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240514084155.50673-1-ciara.loftus@intel.com> References: <20240514084155.50673-1-ciara.loftus@intel.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The rx_dropped statistic is never incremented so its existence is pointless. Remove it. Fixes: f1debd77efaf ("net/af_xdp: introduce AF_XDP PMD") cc: stable@dpdk.org Reported-by: Stephen Hemminger Signed-off-by: Ciara Loftus --- drivers/net/af_xdp/rte_eth_af_xdp.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c index 193e3576bc..16b92ae775 100644 --- a/drivers/net/af_xdp/rte_eth_af_xdp.c +++ b/drivers/net/af_xdp/rte_eth_af_xdp.c @@ -123,7 +123,6 @@ struct xsk_umem_info { struct rx_stats { uint64_t rx_pkts; uint64_t rx_bytes; - uint64_t rx_dropped; uint64_t imissed_offset; }; @@ -876,7 +875,6 @@ eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats) stats->ipackets += stats->q_ipackets[i]; stats->ibytes += stats->q_ibytes[i]; - stats->imissed += rxq->stats.rx_dropped; stats->oerrors += txq->stats.tx_dropped; fd = process_private->rxq_xsk_fds[i]; ret = fd >= 0 ? getsockopt(fd, SOL_XDP, XDP_STATISTICS,