From patchwork Tue May 7 12:42:44 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139967 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 31F5343FC9; Tue, 7 May 2024 14:44:06 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 30DF5433AA; Tue, 7 May 2024 14:43:51 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2058.outbound.protection.outlook.com [40.107.243.58]) by mails.dpdk.org (Postfix) with ESMTP id 6E5834338E; Tue, 7 May 2024 14:43:45 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=iRfIXrzuYmxcyzZIrHVANg1rXCns3Cdqy3YEL6zefUCUQJ/HG/O9RLgk3MFV7zN8GIRragF5AExH2qHCoN+NY8aEowTuVvrbuNrHyJxCS4Sv21ODzrZqAbgo6hyuCvjTztEfQnUIadp7RBGKjtS02sthkVSS4nYsS6RO9evsLjBjHwwRlWIcoFnsaKy/3PzDwghMG2FAaUyFFyNk2QQ6yjwpXDAX1ud44nDH8Uufg4qc9p0XvLpf15BTShvAKWeEnMwa0cgD+lSDlMtFZuw9z+F4Bs6o1Tt6ClJUy7QMtc8WQXLMQwpCfoH5MS3/3VGhZulvVfJvCy3EUgQzv4rRdg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=s7B8pdwy9vsxWH4lBnKGLK6jSsKvN2cNFDAEx8XhfqU=; b=DVqaOxhUOTsYH/Ta4wQQCPgQ3bwg0Z5oDnOrIRL2hHSZ1mXjb54lqPyJIC3g05Hzn7dv4yO/lPbCYCqinMoi7ZRkfBgU6+iPYyNFGBZiyaedB0ka3zusNca1G7tA+mRoWxnDcoLktYMkyBxrdq+tiGr5vaSnXdkv9vTGNuV4d4EqL7IVhlzW+eOvzO0c3zXhdpfEH7wJEsCUtApFb7X4Ik8Zq9kMN2rRHbLTmwa7eh+Rod92BOXif1Q9lIOcfwqNmkGF8xVpHXc6oayaS2pP4GTyA/n7QCGxgz2wSjKR2Ik8h0rNVFHzswD9gtwIFAVqxfRaSd/Q9IaBe36XgMz5cw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=s7B8pdwy9vsxWH4lBnKGLK6jSsKvN2cNFDAEx8XhfqU=; b=RP9QnCb2hLeHTKPtaIDKWIumVxaOH0Y7p+k98Z2/f2nmmaeMo6ngqLiR74u685CB+RCcmOiJA5MeaMjwI9kJvTvTvzONVJFc5zjc8fzMPdOnQWUpwFzr9MNo6JCl6ChBMRfXeX/WyA8xKww4nJcX+zvOX3SD9HfX4VzE6gT15bY= Received: from PH7P220CA0041.NAMP220.PROD.OUTLOOK.COM (2603:10b6:510:32b::27) by SA1PR12MB8118.namprd12.prod.outlook.com (2603:10b6:806:333::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May 2024 12:43:43 +0000 Received: from SN1PEPF00036F43.namprd05.prod.outlook.com (2603:10b6:510:32b:cafe::37) by PH7P220CA0041.outlook.office365.com (2603:10b6:510:32b::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.43 via Frontend Transport; Tue, 7 May 2024 12:43:43 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF00036F43.mail.protection.outlook.com (10.167.248.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 12:43:43 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May 2024 07:43:40 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande , Subject: [PATCH v2 04/25] net/axgbe: update DMA coherency values Date: Tue, 7 May 2024 18:12:44 +0530 Message-ID: <20240507124305.2318-4-venkatkumar.ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240507124305.2318-1-venkatkumar.ande@amd.com> References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00036F43:EE_|SA1PR12MB8118:EE_ X-MS-Office365-Filtering-Correlation-Id: 90a2984c-677f-412a-a222-08dc6e935433 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|82310400017|1800799015|36860700004|376005; X-Microsoft-Antispam-Message-Info: qO2004onKFfPv0mYVWoNGT/22nTHfdmpRkEPH3HXqF+qy2lJ2fe2M6fpGaIAWLPD4/GCzgNDEEGO7CPy+u8ZPa2kdb0BrUrFjKSVP+8jFRyCx+H2B/dZ6k7kIs9OfO7RsCCGI0At4TToqi+2tQrrPB0vpUsbJg3OBRQfIQgtF72vGQQCnruhFp+QPS4iCl6c5lTcYKnyNGsiQQYXh4KBMdZqXI0Kt64NthRJZn7hDbpELFC3525d/S8hRiLElPhv8pF4H9pd9zMFi3++3lWXM/anLNn18fQjxAmuyfrSK0H8bqY85xDNN3trxM6Y85aNnVmNTwRrqTjE2PiS2j4S5IHmxRichj8Hc5rvoJ9sWu8o+Oaeb0QUE2uRCxO0zmodL2qmZkiuy3U+WwOCySOF1U2O7HgqQyQom/kBc0am4/6IzrG1emsk8/0m/937J/ywUgauDcBcOqIIdWfP/ssxpbXdfJj6XWysCVnDOypLPJ0sDjIOYzHqiSIkxpCLzRStYHu00yhGwLJm8RuNG1L+1UZJzHDPY/fq6u7TQ5STj1mVKwaYINEZfBQ0R/eO3asaaVDIoAd1bLV+RCQtXEzT45NFtPUsEttxXIc3vfMf/J1bQpCky5UhfGlSCUZ1wlIMqoMIKeqbzKtXIxvBiCYppweUC+qZezWp+O41mJARTY3/FdAf36ovd7DEr1vXepXzft9PdSjDAsQ5K0K4VMHnfnxGojXM5wIiq5En6F5c2KImO+wDgwm8/zH6EYAMsimuec2x+9I2RQkG2X5d2cgx8HzKSpLl8AcCRIf/P0GvnmJYK9VHhMKjR3KNmxERVBintWREgNsKtgiHpMigbP7tKBZAuDDEBEE5jd2BkW0w5aB5GyF84xDJeBlXTAsq/qOz2n2ZCEfdCWEeauk9JFDgptlHbdXVqy7nG8/tN6WvLs89qg7V1laIOzj42zSsaPHuMVKahZCNbzFv+G4rN/iHI6ClirlSnOSRteoL6FkE9TP/Yv2q8jdV0vsm1aNDH489ukwVkslv6vAT0sfij/h/4BXqWa7+M61JTvSYGfR6953NisAOyNYG+dUMockG09QmyXjiCHIENLfEwJY8u0wp2BAw/8flAXMWZ/q7T0rPWtkFnGpXD/1jj+i9wA7VszEGhgIicIYvjfubHxvg2M9vFuonc/nMcoiP8gGViD3AirssG/pIyLJDWaGPCp9j4cWoJ2fAhtigYbVb5RwI/kM0n1B+icXbOm3QYZmY3tAaiFT6riyAw7bGCDCkEC8o9ZnDzgjc1L5hqjoqtg3zEeYq9rTJTcEYdt+OUkOzZpwV9uYiD0TzJCvlXGiPk8S/YVDHbNhOAXnxCujHlb6vFMzJ8dWM2E3q8Ohq0PLIgIyBXwj5/n4hH2mV2ngOpLLgVBVi X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(82310400017)(1800799015)(36860700004)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 12:43:43.0904 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 90a2984c-677f-412a-a222-08dc6e935433 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00036F43.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB8118 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Based on the IOMMU configuration, the current cache control settings can result in possible coherency issues. The hardware team has recommended new settings for the PCI device path to eliminate the issue. Without the fix the user will get incorrect data in TSO functionality Fixes: 7c4158a5b592 ("net/axgbe: add DMA programming and start/stop") Cc: stable@dpdk.org Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_dev.c | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/drivers/net/axgbe/axgbe_dev.c b/drivers/net/axgbe/axgbe_dev.c index 3389954aa6..9b0073eea6 100644 --- a/drivers/net/axgbe/axgbe_dev.c +++ b/drivers/net/axgbe/axgbe_dev.c @@ -647,23 +647,21 @@ static void axgbe_config_dma_cache(struct axgbe_port *pdata) unsigned int arcache, awcache, arwcache; arcache = 0; - AXGMAC_SET_BITS(arcache, DMA_AXIARCR, DRC, 0x3); + AXGMAC_SET_BITS(arcache, DMA_AXIARCR, DRC, 0xf); + AXGMAC_SET_BITS(arcache, DMA_AXIARCR, TEC, 0xf); + AXGMAC_SET_BITS(arcache, DMA_AXIARCR, THC, 0xf); AXGMAC_IOWRITE(pdata, DMA_AXIARCR, arcache); awcache = 0; - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, DWC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RPC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RPD, 0x1); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RHC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RHD, 0x1); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RDC, 0x3); - AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RDD, 0x1); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, DWC, 0xf); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RPC, 0xf); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RHC, 0xf); + AXGMAC_SET_BITS(awcache, DMA_AXIAWCR, RDC, 0xf); AXGMAC_IOWRITE(pdata, DMA_AXIAWCR, awcache); arwcache = 0; - AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, TDWD, 0x1); - AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, TDWC, 0x3); - AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, RDRC, 0x3); + AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, TDWC, 0xf); + AXGMAC_SET_BITS(arwcache, DMA_AXIAWRCR, RDRC, 0xf); AXGMAC_IOWRITE(pdata, DMA_AXIAWRCR, arwcache); }