From patchwork Tue May 7 12:43:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139988 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2D23443FC9; Tue, 7 May 2024 14:46:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6A84C433B9; Tue, 7 May 2024 14:44:53 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2060.outbound.protection.outlook.com [40.107.93.60]) by mails.dpdk.org (Postfix) with ESMTP id 3A08D43414 for ; Tue, 7 May 2024 14:44:52 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jDlK+rQpRjMcYyFNB6s8v8PwvWEnk10S8hVovoGfwLdLHjAF78AlZPGVhWLHcaKj1DnvKvi35YF+fMT4wAZRgRQSxUTgs47smctlOe4BANZ0jmHRf0BXLuOZps6RjfADiZ/sBj5xE/or+fT0M3nGZzfW5Y19Txw8l22w7y++0X8scZFji3Ky8T4IQvrXucA/LGSQnkO7j8kiiNSQmAy9A7KzWkNICh+VUzAF+coetWk/mqWaTxpMwhkvFeDh7VXL7HOZOZeVXhiEhu6tWke6tnMUHnEZbqyQUEZVD32brbyMxiaLpbDSF12s29L8hzoz7Se/IvhViAkq/4KO21NTyQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xvwl2nsTQHEPhUIX2vr5y+aYe8AVUNPIHq4x/8dgbfg=; b=kQ4Hdb8llI1tuVMUGGxVAzihquMI0PKjYVsYqlgJJFrBMxY4TNiglQLP8C0R5GuwzzGjHihQCycwwycfZDdGQvo0BG8tyfDPLU9bPzVeBoXHyFSKHA/+g40QlqirrMdlDVh7bPmfOeF8PhDjd8KcUTlKU22NUZwC/+oL2yvm+kw/qfTkGlJ6pTxnfInxezwCVkYT6THV+AODZvtz0uuquDLpghCX3dr81XLrysdDfezRINOG1sHlhat241Lr+i0SGAbYpvfA+Nw/JvDzvoTPvXNv4Wgx3/35EDByufSnUEbaNzOjyH13bukJmElBUcM+8dP75/3JJD7WnY9JuJmB2g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xvwl2nsTQHEPhUIX2vr5y+aYe8AVUNPIHq4x/8dgbfg=; b=2C31wofd8JClHKdkyTplfIyVt4grRRIvWsposOuMzCuDQxLCzIlrVTvCIQQoch1kYqoc5TPb9HzOphRZ28cbX0A9QdGukaPmg75AsGjSgbhzJ6KRsedzTi6VSDpAzYSMLaS/eK1yq5a8zkox8Hfv24IL+GTkoGgTgbpOC3hhLVA= Received: from PR2P264CA0010.FRAP264.PROD.OUTLOOK.COM (2603:10a6:101::22) by BY5PR12MB4305.namprd12.prod.outlook.com (2603:10b6:a03:213::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42; Tue, 7 May 2024 12:44:47 +0000 Received: from SN1PEPF00036F42.namprd05.prod.outlook.com (2603:10a6:101:0:cafe::4) by PR2P264CA0010.outlook.office365.com (2603:10a6:101::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.42 via Frontend Transport; Tue, 7 May 2024 12:44:46 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by SN1PEPF00036F42.mail.protection.outlook.com (10.167.248.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7544.18 via Frontend Transport; Tue, 7 May 2024 12:44:45 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Tue, 7 May 2024 07:44:39 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande Subject: [PATCH v2 25/25] net/axgbe: modify debug messages Date: Tue, 7 May 2024 18:13:05 +0530 Message-ID: <20240507124305.2318-25-venkatkumar.ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240507124305.2318-1-venkatkumar.ande@amd.com> References: <20240412125013.10498-1-VenkatKumar.Ande@amd.com> <20240507124305.2318-1-venkatkumar.ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SN1PEPF00036F42:EE_|BY5PR12MB4305:EE_ X-MS-Office365-Filtering-Correlation-Id: 624ef8a7-245d-4dc7-2357-08dc6e93798b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|36860700004|82310400017|376005|1800799015; X-Microsoft-Antispam-Message-Info: u9q3PbbVgNLpQZ33Nppw/IeDH6lF39oCVcz4HJF9bLRlPdhET3RigCNq85ZC4o0+lO9ZBo+DjlIc84g9qqhUBNoC0Knod5EnOohAW2y6ffAb4bQDQQHTrtGWJeBNCgJUojHDxtKdsJb6OonWoZN4p0B1NDQ+dY1KFEtLkdtv4WNUw4gNsJ7QiT4m9VxqhXj4v1YM7CDSNS8Sl7YtUCn7H/LC9BYOLvkS/KWrzwHex85gnAelIAg6lbNZMchWMvZUXp5M9BcOJOfGrdiI4x8ZVlV6gcusQoeikEGqXXE11mdcE76fHeF1cj6SB1XxdMT9LSVp3CcWwLc0Amwu4mp5GhLDuM7XF1pO4pkPsy1hZJXiI0jEU9hFkr87UPl7mk/hVDH4HYNmhB4/QzboKS2Dwp5wYTzsRlDY7SHju4UvEs/CYN5CwczCniccWNDJMXjERKsl+DOJEpwkCHurAJwxlmQr7zH48BggTzSF3b4d7M9JZvzAyjgUfEj15WZol0qQIJtdCgpArS1qgl9SNcjiLTkLxxOhKGq43x/SSRNdOx+IBpH7Gx566pUJEMcA5UX9Fst12zzSL/V/vBfTeESf7C8GEnS7+iCLCBE0nlHJ2kn2dsHMwqwJgmngSdDjzw1NRREKb4XMB9Fio5UPEIhMSgi/1o3PcauJ4a5cuHYNr5kiTFFsPymBk5u+g23kfy2wZMWaHx2WIs7ZCLqtBFmsDOJGaJSax0kvH8xgakcR2RXXE3Ez9/+zSB3Y1JD3n+JzYwKjZIe4eamPL0awbBA/juRWUhzfm2o0sgU/mdwMM7saalvT6gtoGuQymqoJ1Qj5TWuQBhmsz9cKOFliU1dwbkouPmr/MOaAZpf4Ezwy0Yb8AqCa2J4RpcIe0S3UfGSq8Lcu04oqKFv3Q67aYYoq8q5rBr9qqIOOq6HppH597WziTeDlO+Ym7K/pf5JU7jSK/c8HHtA9i7QE+/HuTWuipzBdoVgm91zasUDfb0R8vsrxrDlhf6/n1D7WNKSeRKaIuYD+i2IHPgo0v3dyGsNgO5lI/p7HEyod7J1LjmZ7lq4x7D+0FXB/eApDQCQFHXIgd0++vNnwKx6M7BgpRfY3z+vRrwbuJpAZALzJlGg/2TPsDoWs7nLVBJbM+zS6GGX6DCRrXNRuEuNzCgLODxnpFfxdGaivWpGqxkAkzpfLOZnjbc69AbDKkR7ZNagYYXZuEvGEoBJ5hLgZy+ZvDJ/7a9pxGk9A9FhDYtkqL/Ah7DH1dZkxBFta4gQap2PIkgRCu2ryPb8BO+SLFzd+slb6iBG50pfuVIy2F+6InMBqR3nRJNs/Ucqt2yAOzxtxfhLrVlTk40zOUOr29m85iWLuRBm0DRFxfkRBbLyMZSjhuZ22NzbtrxsRkWn6P0W7EkSc X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(82310400017)(376005)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 May 2024 12:44:45.7396 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 624ef8a7-245d-4dc7-2357-08dc6e93798b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: SN1PEPF00036F42.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4305 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Modify debug messages to get better information from debug logs Signed-off-by: Venkat Kumar Ande Acked-by: Selwin Sebastian Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_ethdev.c | 4 ++-- drivers/net/axgbe/axgbe_phy_impl.c | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index 86c2ec64e0..8b1f3b2742 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -783,8 +783,8 @@ axgbe_dev_link_update(struct rte_eth_dev *dev, link.link_autoneg = !(dev->data->dev_conf.link_speeds & RTE_ETH_LINK_SPEED_FIXED); ret = rte_eth_linkstatus_set(dev, &link); - if (ret == -1) - PMD_DRV_LOG(ERR, "No change in link status\n"); + if (ret == 0) + PMD_DRV_LOG(ERR, "Link status changed\n"); return ret; } diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index d41c6e9bc7..0af1a7cac5 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1375,8 +1375,6 @@ static void axgbe_phy_perform_ratechange(struct axgbe_port *pdata, if (cmd != AXGBE_MB_CMD_POWER_OFF && cmd != AXGBE_MB_CMD_RRC) axgbe_phy_pll_ctrl(pdata, true); - - PMD_DRV_LOG(NOTICE, "firmware mailbox command did not complete\n"); } static void axgbe_phy_rrc(struct axgbe_port *pdata)