From patchwork Sun May 5 08:37:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Mattias_R=C3=B6nnblom?= X-Patchwork-Id: 139869 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 30DB343FAE; Sun, 5 May 2024 10:48:22 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1EDD4402E7; Sun, 5 May 2024 10:48:05 +0200 (CEST) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05on2047.outbound.protection.outlook.com [40.107.20.47]) by mails.dpdk.org (Postfix) with ESMTP id AFE064028C for ; Sun, 5 May 2024 10:47:59 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=JxY07GRHYrtMsU+kENXt/L6b5oVqff8jnexTIL7aceb/HDjMsyollIPLFoh8h7GV52d9hcMY4RVQww6hHB6ZXss14p0oBN4cBLttiLETJnqEHVmVQc3q5glRW3eeJzhNNPvkqA9CY0Ib7ePE5c2CuD3ybkqejsceajs/oH/6dwLGcSiHQ9Bs/6WsMdJvl8dHce4ZCuGxui6C/hKt8wKWoTqf+Y/EnFritOTtfznhOqhpfrBnDnq+T+RK18MspFvngl1W9ePLuobxdx+3+frgxShE7M9+3zjGsHDcFOykz8gUHE/4VXQquPsf3un8CtE7aEi6b3z+8YWTF+xU6O83RQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=2NtFc/85D5XqMWuHibOU2UGt9NdiuGqxaSS34YzRHUc=; b=cjvMoYsAvskAQyyrfCh/jHsWNQnUDrIth1xNXbdT06VKRkwQQ04WXfk+HoVrFI07FFbBnoDn37tlddkG6bcl17a+Dc9D7guw9UyW9fuJkblG8lx1CkSyFqWjgWL2IY3yIR6KXtj1IaRvd2SM29DsI//4TFkto4F+YMEFyT/l3gKi+HkzqF6xZZyR0ZTfE3UJu5Ukwr6jVT292u8pQQmOhvrr21klSzE2FDKbvphmbyoZJphhozFcblg/VAlWW8UiT7iXjRtoX4cnI6y46M6JhlQBjzlfq3gBOhHXttrvAZnmdEluQTGI8tp3JfVy68AkgVVt/iZ1ROtQ+zRRrsiC1Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2NtFc/85D5XqMWuHibOU2UGt9NdiuGqxaSS34YzRHUc=; b=mTGL1TPLYV6/KV7F/Xm0/+QC1sdsSdcA0uGzGlHtvG894M6wbFRUdFCNDGNNSuSfIlfbXRTqskGu3izZ3OulTP4STBTApO4dZtxAaq+Lg8V49ckAoqRtStoJ0NX9XwqcH2WX62hvQxPhDSix/3BjZWsi+LhSc86X1RcCfXgBU6HbYTYKXUsbXe8fv8mpv3Vi7HSC/e0poH+U5X3mpVaojhF5lyTLiV9KTlx/fxDRKzePLpPTXi55nwOY7/DpwyKg7XMLeCf65POydy4sEMc6DFdHhYhiyegbIgqEg8GsqQN25LF0n9E7FZvw0FGd5exIPgJUKI+4Y/agq1Vf1x1lzw== Received: from DB7PR05CA0042.eurprd05.prod.outlook.com (2603:10a6:10:2e::19) by PAXPR07MB8793.eurprd07.prod.outlook.com (2603:10a6:102:244::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.40; Sun, 5 May 2024 08:47:58 +0000 Received: from DU2PEPF0001E9C1.eurprd03.prod.outlook.com (2603:10a6:10:2e:cafe::42) by DB7PR05CA0042.outlook.office365.com (2603:10a6:10:2e::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7544.39 via Frontend Transport; Sun, 5 May 2024 08:47:58 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by DU2PEPF0001E9C1.mail.protection.outlook.com (10.167.8.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.19 via Frontend Transport; Sun, 5 May 2024 08:47:58 +0000 Received: from seliicinfr00049.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.64) with Microsoft SMTP Server id 15.2.1544.9; Sun, 5 May 2024 10:47:57 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id 7E85038007A; Sun, 5 May 2024 10:47:57 +0200 (CEST) From: =?utf-8?q?Mattias_R=C3=B6nnblom?= To: CC: , Heng Wang , "Stephen Hemminger" , Tyler Retzlaff , =?utf-8?q?Morten_Br=C3=B8rup?= , =?utf-8?q?Mattia?= =?utf-8?q?s_R=C3=B6nnblom?= Subject: [RFC v7 3/6] eal: add exactly-once bit access functions Date: Sun, 5 May 2024 10:37:34 +0200 Message-ID: <20240505083737.118649-4-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240505083737.118649-1-mattias.ronnblom@ericsson.com> References: <20240502055706.112443-2-mattias.ronnblom@ericsson.com> <20240505083737.118649-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU2PEPF0001E9C1:EE_|PAXPR07MB8793:EE_ X-MS-Office365-Filtering-Correlation-Id: cf9d5499-03d0-42a5-bc26-08dc6ce0104f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|36860700004|82310400017|1800799015; X-Microsoft-Antispam-Message-Info: =?utf-8?q?BiBF+zXfZaCAZV3hSUNijRZyEHNvsUO?= =?utf-8?q?Eo7UVXWyL1JGUmTWix1YRvbLM7GcoAVBEB2YuT4bnu/wZS04qQIT2KGbW/Omm1nK5?= =?utf-8?q?QXslJYWuiY2B8yi5jyTlmuhClr0a3UyI00F00XNN65bTxTeJtr/esSgspznwX4lM9?= =?utf-8?q?S6rcZgzrMXfokGLMZffrys+ZGzrdeNhPR/WJZUQzt1cJU+xBoySShp76jrVh7TUGd?= =?utf-8?q?wi/qHzJZq6CZGnuBENTKxrDd3ABE1JSKGTvDmsybBymNK8l5DZSmA6o2ghQhDoHDc?= =?utf-8?q?bd/8w6pIXU8q0JiQ5Hexx9rpS6611QnTF6koFkQbJHlRR3CY3tcVMGqH2cLQTVQTW?= =?utf-8?q?ReUifPQmg1aVo52QJ+GRmEfvlw9L6DPnEJKUtp+CLb0I9DmaAGTx7zgi9C5HvoNla?= =?utf-8?q?JrXTu2AYXS7LUgXr/petkeLYQoIyueMh1joBLOmVhjIQGKnAHm2aTIi5gyWFyz9LZ?= =?utf-8?q?c+JUmvd7rDCnbYUfMGiEhrJXENDPEYnFm2a/uqWAO1RI9vvtx8UcGHsxdNvq9aDkH?= =?utf-8?q?CONy8P/MSOK76bKdrYYPh5ArEjp69VAYAhSLp2XV4/9SAtByV8eH1NlFu3FgxoqZr?= =?utf-8?q?ndU3XG2Ab1xWzDeYVsOTVduXe0OT2UKij5/jWneTTjyikPxBmHIIqOCnRxKm2Lrj1?= =?utf-8?q?FfqTSIYcoPefTz7apumBx3dFEt2axpeVUdXlk1a6CpryT3P667D4J6E5ZdkJXh9Ut?= =?utf-8?q?6pREdbEmU5SS+zwZAJoY6dDDMLn/7H8IRaiXhj//duwkAx5D/mbxdGhhiD12qr7Oc?= =?utf-8?q?x6tUampJM+DYAMxSRGOX21UEZ5dVeIDcu6EJlTKwE7xIAusQHmp7U1NEyDIonIWbi?= =?utf-8?q?rhpsBxj0a2Ql/umzEXfzAK0NE4n8myJ3XzSQ7S9qIQljZAzNkk4JqFdqeZYd2+6uT?= =?utf-8?q?5BmBkx8QT5m0Mt8brvWVSGFQ92JJI22YwMAqzog33+A2CpULEbMEVunW+/a3ORTKy?= =?utf-8?q?NPBpCIS7EQ0uf/5gLo0yYv30hID92ExzRVau292nUbBX0wSfCYZA16JaNHZV+JqjK?= =?utf-8?q?bgWIEFg02QjHJ9WfhC8JioObpmCSm96usCGUOy2M3oDQRdsxv1nt01i2Qgq/9gfZI?= =?utf-8?q?hFLLKrPwggXew0Bb7SOnWlFQr5m0EVwbqayp3yB8adNEUUqyjx4iWck+fatzrjPoB?= =?utf-8?q?+BLFUTO3lrpnawpkly3/CuLxyCFtM+mAg/cG0Y7GlcDPU9Hcytn57STGE7FqxF60b?= =?utf-8?q?CpVSiPYSlvPMBbxkBXZU4lXxKNRBk/rXPQpkq+eWCnE0/kaXDfZLVKd2ydM3cZdvn?= =?utf-8?q?exlo6AOuf0okjE4HIAdnz93aXhrBc5NF+t5r2T4k3YG82WfX1PY7ieWDl+U8WCNfv?= =?utf-8?q?dCbQXsLHAjQx?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230031)(376005)(36860700004)(82310400017)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 May 2024 08:47:58.1121 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: cf9d5499-03d0-42a5-bc26-08dc6ce0104f X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: DU2PEPF0001E9C1.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR07MB8793 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Add test/set/clear/assign/flip functions which prevents certain compiler optimizations and guarantees that program-level memory loads and/or stores will actually occur. These functions are useful when interacting with memory-mapped hardware devices. The "once" family of functions does not promise atomicity and provides no memory ordering guarantees beyond the C11 relaxed memory model. RFC v7: * Fix various minor issues in documentation. RFC v6: * Have rte_bit_once_test() accept const-marked bitsets. RFC v3: * Work around lack of C++ support for _Generic (Tyler Retzlaff). Signed-off-by: Mattias Rönnblom Acked-by: Morten Brørup Acked-by: Tyler Retzlaff --- lib/eal/include/rte_bitops.h | 201 +++++++++++++++++++++++++++++++++++ 1 file changed, 201 insertions(+) diff --git a/lib/eal/include/rte_bitops.h b/lib/eal/include/rte_bitops.h index 3297133e22..3644aa115c 100644 --- a/lib/eal/include/rte_bitops.h +++ b/lib/eal/include/rte_bitops.h @@ -226,6 +226,183 @@ extern "C" { uint32_t *: __rte_bit_flip32, \ uint64_t *: __rte_bit_flip64)(addr, nr) +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Generic selection macro to test exactly once the value of a bit in + * a 32-bit or 64-bit word. The type of operation depends on the type + * of the @c addr parameter. + * + * rte_bit_once_test() is guaranteed to result in exactly one memory + * load (e.g., it may not be eliminate or merged by the compiler). + * + * \code{.c} + * rte_bit_once_set(addr, 17); + * if (rte_bit_once_test(addr, 17)) { + * ... + * } + * \endcode + * + * In the above example, rte_bit_once_set() may not be removed by + * the compiler, which would be allowed in case rte_bit_set() and + * rte_bit_test() was used. + * + * \code{.c} + * while (rte_bit_once_test(addr, 17); + * ; + * \endcode + * + * In case rte_bit_test(addr, 17) was used instead, the resulting + * object code could (and in many cases would be) replaced with + * the equivalent to + * \code{.c} + * if (rte_bit_test(addr, 17)) { + * for (;;) // spin forever + * ; + * } + * \endcode + * + * rte_bit_once_test() does not give any guarantees in regards to + * memory ordering or atomicity. + * + * The regular bit set operations (e.g., rte_bit_test()) should be + * preferred over the "once" family of operations (e.g., + * rte_bit_once_test()) if possible, since the latter may prevent + * optimizations crucial for run-time performance. + * + * @param addr + * A pointer to the word to query. + * @param nr + * The index of the bit. + * @return + * Returns true if the bit is set, and false otherwise. + */ + +#define rte_bit_once_test(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_test32, \ + const uint32_t *: __rte_bit_once_test32, \ + uint64_t *: __rte_bit_once_test64, \ + const uint64_t *: __rte_bit_once_test64)(addr, nr) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Set bit in word exactly once. + * + * Generic selection macro to set bit specified by @c nr in the word + * pointed to by @c addr to '1' exactly once. + * + * rte_bit_once_set() is guaranteed to result in exactly one memory + * load and exactly one memory store, *or* an atomic bit set + * operation. + * + * See rte_bit_test_once32() for more information and uses cases for + * the "once" class of functions. + * + * This macro does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + */ + +#define rte_bit_once_set(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_set32, \ + uint64_t *: __rte_bit_once_set64)(addr, nr) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Clear bit in word exactly once. + * + * Generic selection macro to set bit specified by @c nr in the word + * pointed to by @c addr to '0' exactly once. + * + * rte_bit_once_clear() is guaranteed to result in exactly one memory load + * and exactly one memory store, *or* an atomic bit clear operation. + * + * See rte_bit_test_once() for more information and uses cases for + * the "once" class of functions. + * + * This macro does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + */ +#define rte_bit_once_clear(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_clear32, \ + uint64_t *: __rte_bit_once_clear64)(addr, nr) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Assign a value to bit in a word exactly once. + * + * Generic selection macro to set bit specified by @c nr in the word + * pointed to by @c addr to the value indicated by @c value exactly + * once. + * + * rte_bit_once_assign() is guaranteed to result in exactly one memory + * load and exactly one memory store, *or* an atomic bit clear + * operation. + * + * This macro does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + * @param value + * The new value of the bit - true for '1', or false for '0'. + */ +#define rte_bit_once_assign(addr, nr, value) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_assign32, \ + uint64_t *: __rte_bit_once_assign64)(addr, nr, value) + +/** + * @warning + * @b EXPERIMENTAL: this API may change without prior notice. + * + * Flip bit in word, reading and writing exactly once. + * + * Generic selection macro to change the value of a bit to '0' if '1' + * or '1' if '0' in a 32-bit or 64-bit word. The type of operation + * depends on the type of the @c addr parameter. + * + * rte_bit_once_flip() is guaranteed to result in exactly one memory + * load and exactly one memory store, *or* an atomic bit flip + * operation. + * + * See rte_bit_test_once() for more information and uses cases for the + * "once" class of functions. + * + * This macro does not give any guarantees in regards to memory + * ordering or atomicity. + * + * @param addr + * A pointer to the word to modify. + * @param nr + * The index of the bit. + */ +#define rte_bit_once_flip(addr, nr) \ + _Generic((addr), \ + uint32_t *: __rte_bit_once_flip32, \ + uint64_t *: __rte_bit_once_flip64)(addr, nr) + #define __RTE_GEN_BIT_TEST(family, fun, qualifier, size) \ __rte_experimental \ static inline bool \ @@ -298,6 +475,18 @@ __RTE_GEN_BIT_CLEAR(, clear,, 64) __RTE_GEN_BIT_ASSIGN(, assign,, 64) __RTE_GEN_BIT_FLIP(, flip,, 64) +__RTE_GEN_BIT_TEST(once_, test, volatile, 32) +__RTE_GEN_BIT_SET(once_, set, volatile, 32) +__RTE_GEN_BIT_CLEAR(once_, clear, volatile, 32) +__RTE_GEN_BIT_ASSIGN(once_, assign, volatile, 32) +__RTE_GEN_BIT_FLIP(once_, flip, volatile, 32) + +__RTE_GEN_BIT_TEST(once_, test, volatile, 64) +__RTE_GEN_BIT_SET(once_, set, volatile, 64) +__RTE_GEN_BIT_CLEAR(once_, clear, volatile, 64) +__RTE_GEN_BIT_ASSIGN(once_, assign, volatile, 64) +__RTE_GEN_BIT_FLIP(once_, flip, volatile, 64) + /*------------------------ 32-bit relaxed operations ------------------------*/ /** @@ -993,6 +1182,12 @@ rte_log2_u64(uint64_t v) #undef rte_bit_assign #undef rte_bit_flip +#undef rte_bit_once_test +#undef rte_bit_once_set +#undef rte_bit_once_clear +#undef rte_bit_once_assign +#undef rte_bit_once_flip + #define __RTE_BIT_OVERLOAD_SZ_2(fun, qualifier, size, arg1_type, arg1_name) \ static inline void \ rte_bit_ ## fun(qualifier uint ## size ## _t *addr, \ @@ -1042,6 +1237,12 @@ __RTE_BIT_OVERLOAD_2(clear,, unsigned int, nr) __RTE_BIT_OVERLOAD_3(assign,, unsigned int, nr, bool, value) __RTE_BIT_OVERLOAD_2(flip,, unsigned int, nr) +__RTE_BIT_OVERLOAD_2R(once_test, const volatile, bool, unsigned int, nr) +__RTE_BIT_OVERLOAD_2(once_set, volatile, unsigned int, nr) +__RTE_BIT_OVERLOAD_2(once_clear, volatile, unsigned int, nr) +__RTE_BIT_OVERLOAD_3(once_assign, volatile, unsigned int, nr, bool, value) +__RTE_BIT_OVERLOAD_2(once_flip, volatile, unsigned int, nr) + #endif #endif /* _RTE_BITOPS_H_ */