From patchwork Thu May 2 21:31:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 139816 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BACFE43F6C; Thu, 2 May 2024 23:36:52 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4FCC9402F1; Thu, 2 May 2024 23:36:35 +0200 (CEST) Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) by mails.dpdk.org (Postfix) with ESMTP id 60CCC402D4 for ; Thu, 2 May 2024 23:36:31 +0200 (CEST) Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-6f074520c8cso8043298b3a.0 for ; Thu, 02 May 2024 14:36:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1714685790; x=1715290590; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=GUoyvITfAbqz6shfD2kP+kicd5cGIJOvY1LKoP46A53V4mvg+y5t+0AJds9UQeb0dr zOOdDDGZFnATc6x1jxiPDmH4YeH7e80+8IDjMiWrJq9JLWt2D3Yno0Ku/x0dPDQIX/Uz W56GyNaNzOS3EdH6RQyJJwC6VHUTz+6Y7BAWDStXPvZ3DGcUI4Ga+2rFhG/u6i1cIvbD M0P+DUDLHafUrNinTR9gnKOJXaNqn41FvGpqNMTE83bwRlW+8KY/SurOSozWOo+EfHUQ IPYYR3x00HCJTzFd8LLc2/PXO7XtIo/g1PCIzS+CjZtMik1k9fS8+stwq/al0ggWS4xq QFAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714685790; x=1715290590; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=nQflKhToqXQy5/HFwbUg/VVDegoBYmRvbf0vhBIdcqA=; b=bZapP9lMwBQR0i5aGzQPwiUL2+FNljqH7Gm2H2iNQ5fa/bi5miM74w1r75ccbceqfh SpnLmnB6tFtyCWKo4lQIulG1BCcjAqPuhyXHF1oJ8eFFQiRLby3av/YSzNfAc2qY950w BpaQD/qNB1i8XkLXB6veIire+qsMEoZx5DDN6et3Ip9a12pqwgzhr1IzZc4P36QccXRb a3gdm418tgokCi8ZrVG63iQ6fzKsUN0l1VMFHb5usHjHa/zUKDuU7Ruu2qh0Irj37QgZ TSAsB2+tn2a/n4I2Ql4+q/kvmtBUIlrhEWgmDfsRyRCXDXreviTml7JNv+cpligSUuMl dhKA== X-Gm-Message-State: AOJu0Yy2SodBzvHZ1v46+isqkLPjBxXCOXo8c2S195n5v77w37n4p/NL 19W47QFOrQy04uJkU8GnuqvRxdgalhnPQy5OXF8Jwi+//TuKCtKlctYUWyUZAH7agtx4zQhVXfN S/LwwbA== X-Google-Smtp-Source: AGHT+IFODuUhEp7rU5ighHnx+T8nDBTyBOYvYeRcqOZkCoEyJ0cW+A0+AZJSfaNUi8e0306zaw5rbA== X-Received: by 2002:a05:6a00:2e88:b0:6ed:6f25:f361 with SMTP id fd8-20020a056a002e8800b006ed6f25f361mr968379pfb.29.1714685790449; Thu, 02 May 2024 14:36:30 -0700 (PDT) Received: from hermes.local (204-195-96-226.wavecable.com. [204.195.96.226]) by smtp.gmail.com with ESMTPSA id f14-20020a056a001ace00b006f3eee787d5sm1804829pfv.18.2024.05.02.14.36.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 02 May 2024 14:36:30 -0700 (PDT) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH v12 03/12] net/tap: remove unused fields Date: Thu, 2 May 2024 14:31:39 -0700 Message-ID: <20240502213618.11391-4-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240502213618.11391-1-stephen@networkplumber.org> References: <20240130034925.44869-1-stephen@networkplumber.org> <20240502213618.11391-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver doesn't support these other hash types, and there is no reason to implement these in future. The rss_flows list was set but never used. Signed-off-by: Stephen Hemminger --- drivers/net/tap/rte_eth_tap.h | 4 +--- drivers/net/tap/tap_flow.c | 1 - drivers/net/tap/tap_rss.h | 6 ------ 3 files changed, 1 insertion(+), 10 deletions(-) diff --git a/drivers/net/tap/rte_eth_tap.h b/drivers/net/tap/rte_eth_tap.h index dc8201020b..1bcf92ce80 100644 --- a/drivers/net/tap/rte_eth_tap.h +++ b/drivers/net/tap/rte_eth_tap.h @@ -77,14 +77,12 @@ struct pmd_internals { int ioctl_sock; /* socket for ioctl calls */ int nlsk_fd; /* Netlink socket fd */ int flow_isolate; /* 1 if flow isolation is enabled */ - int flower_support; /* 1 if kernel supports, else 0 */ - int flower_vlan_support; /* 1 if kernel supports, else 0 */ int rss_enabled; /* 1 if RSS is enabled, else 0 */ int persist; /* 1 if keep link up, else 0 */ /* implicit rules set when RSS is enabled */ int map_fd; /* BPF RSS map fd */ int bpf_fd[RTE_PMD_TAP_MAX_QUEUES];/* List of bpf fds per queue */ - LIST_HEAD(tap_rss_flows, rte_flow) rss_flows; + LIST_HEAD(tap_flows, rte_flow) flows; /* rte_flow rules */ /* implicit rte_flow rules set when a remote device is active */ LIST_HEAD(tap_implicit_flows, rte_flow) implicit_flows; diff --git a/drivers/net/tap/tap_flow.c b/drivers/net/tap/tap_flow.c index a78fd50cd4..8fccd599f0 100644 --- a/drivers/net/tap/tap_flow.c +++ b/drivers/net/tap/tap_flow.c @@ -1958,7 +1958,6 @@ static int rss_enable(struct pmd_internals *pmd, errno, strerror(errno)); return err; } - LIST_INSERT_HEAD(&pmd->rss_flows, rss_flow, next); } pmd->rss_enabled = 1; diff --git a/drivers/net/tap/tap_rss.h b/drivers/net/tap/tap_rss.h index dff46a012f..8766ffc244 100644 --- a/drivers/net/tap/tap_rss.h +++ b/drivers/net/tap/tap_rss.h @@ -21,12 +21,6 @@ enum hash_field { HASH_FIELD_IPV4_L3_L4, /* IPv4 src/dst addr + L4 src/dst ports */ HASH_FIELD_IPV6_L3, /* IPv6 src/dst addr */ HASH_FIELD_IPV6_L3_L4, /* IPv6 src/dst addr + L4 src/dst ports */ - HASH_FIELD_L2_SRC, /* Ethernet src addr */ - HASH_FIELD_L2_DST, /* Ethernet dst addr */ - HASH_FIELD_L3_SRC, /* L3 src addr */ - HASH_FIELD_L3_DST, /* L3 dst addr */ - HASH_FIELD_L4_SRC, /* TCP/UDP src ports */ - HASH_FIELD_L4_DST, /* TCP/UDP dst ports */ }; struct rss_key {