[v2] cmdline: increase input buffer size
Checks
Commit Message
DPDK defines cmdline input buffer size to 512 characters.
That buffer size can be too small for long application input.
For example, the following flow template API testpmd command is 444
bytes long:
```
flow queue 0 create 0 template_table 1000 \
pattern_template 0 actions_template 0 postpone no \
pattern eth / ipv4 / udp / end \
actions modify_field op set dst_type tag dst_level 0 dst_offset 0 \
src_type value src_value 0x31 width 32 / \
modify_field op set dst_type ipv4_src src_type value \
src_value 10101010 width 32 / modify_field op add dst_type \
ipv4_ttl dst_level 0 dst_offset 0 src_type value \
src_value ff width 8 / count / jump group 100 / end
```
The patch increases cmdline input buffer size to the LINE_MAX value.
Signed-off-by: Gregory Etelson <getelson@nvidia.com>
---
v2: set RDLINE_BUF_SIZE to LINE_MAX
change the patch subject
---
lib/cmdline/cmdline_private.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--
2.43.0
Comments
+CC: Bruce, Stephen
> From: Gregory Etelson [mailto:getelson@nvidia.com]
> Sent: Wednesday, 1 May 2024 19.18
>
> DPDK defines cmdline input buffer size to 512 characters.
> That buffer size can be too small for long application input.
> For example, the following flow template API testpmd command is 444
> bytes long:
> ```
> flow queue 0 create 0 template_table 1000 \
> pattern_template 0 actions_template 0 postpone no \
> pattern eth / ipv4 / udp / end \
> actions modify_field op set dst_type tag dst_level 0 dst_offset 0 \
> src_type value src_value 0x31 width 32 / \
> modify_field op set dst_type ipv4_src src_type value \
> src_value 10101010 width 32 / modify_field op add dst_type \
> ipv4_ttl dst_level 0 dst_offset 0 src_type value \
> src_value ff width 8 / count / jump group 100 / end
> ```
>
> The patch increases cmdline input buffer size to the LINE_MAX value.
+ ... , which typically is 2048.
>
> Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> ---
With or without suggested patch description change,
Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
On Wed, May 01, 2024 at 08:26:54PM +0200, Morten Brørup wrote:
> +CC: Bruce, Stephen
>
> > From: Gregory Etelson [mailto:getelson@nvidia.com]
> > Sent: Wednesday, 1 May 2024 19.18
> >
> > DPDK defines cmdline input buffer size to 512 characters.
> > That buffer size can be too small for long application input.
> > For example, the following flow template API testpmd command is 444
> > bytes long:
> > ```
> > flow queue 0 create 0 template_table 1000 \
> > pattern_template 0 actions_template 0 postpone no \
> > pattern eth / ipv4 / udp / end \
> > actions modify_field op set dst_type tag dst_level 0 dst_offset 0 \
> > src_type value src_value 0x31 width 32 / \
> > modify_field op set dst_type ipv4_src src_type value \
> > src_value 10101010 width 32 / modify_field op add dst_type \
> > ipv4_ttl dst_level 0 dst_offset 0 src_type value \
> > src_value ff width 8 / count / jump group 100 / end
> > ```
> >
> > The patch increases cmdline input buffer size to the LINE_MAX value.
>
> + ... , which typically is 2048.
>
> >
> > Signed-off-by: Gregory Etelson <getelson@nvidia.com>
> > ---
>
> With or without suggested patch description change,
> Reviewed-by: Morten Brørup <mb@smartsharesystems.com>
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
@@ -17,7 +17,7 @@
#include <cmdline.h>
-#define RDLINE_BUF_SIZE 512
+#define RDLINE_BUF_SIZE LINE_MAX
#define RDLINE_PROMPT_SIZE 32
#define RDLINE_VT100_BUF_SIZE 8
#define RDLINE_HISTORY_BUF_SIZE BUFSIZ