From patchwork Fri Apr 26 09:05:02 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Mattias_R=C3=B6nnblom?= X-Patchwork-Id: 139701 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 66C6843F13; Fri, 26 Apr 2024 11:15:30 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 70EBA43CEC; Fri, 26 Apr 2024 11:15:29 +0200 (CEST) Received: from EUR01-VE1-obe.outbound.protection.outlook.com (mail-ve1eur01on2048.outbound.protection.outlook.com [40.107.14.48]) by mails.dpdk.org (Postfix) with ESMTP id 086B340289; Fri, 26 Apr 2024 11:15:27 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=WMsEzUykLTRu2TB5asT6HPqSD2+GjcQu9A6McTaPJKO+0f78hMcs3NtgIIpJNkzVOa7+F8WxJyiduqC+SDRbu50i9cfjcjIJZ8p0D1srreQ9m3QdrdXgj+0szL8K5XBT1gGccbnrDDpO14vJTbFn0u76AaJqLrzoA3vB8naMorj0Tl2hBwCgZJTl3bt3XV67oRCxgLDEUWqzRX9VQlxiQ6f6o4H1r712o908AWN3zj+z/d3obCdwsGVEG1BQwtqUNslLsKZ5iqj4L2GyaWTGaLPxd8OZg1RIFTE9rfVKw1cSu/CSvrTNhj+Tf5qeBQzWwg9kEenIS8r1lv+KqXTBDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=5uZB59glz7vmq0yAbr3ViVcHIYbxEhtkSl6UluLZxqc=; b=PpQaKwCA6g8kFn0q95RKvrM+bKH1I1f7VgH91BvCj4j2fK399Zn2J4Yhju3JwvmBnXEzBIGXo1RLJgu39NEtZW3aEqP/z88TE8vs5YLevNZfwmZE8539FMPaNqWKsbafvd2HS7Eve363o3kHoIzENLnN2fOcS2KDCSlUql2KGfdShcBBdSA85HrVfCbtvhKYZDQT2ySVmdB7WB995RR73SRnT6+284LvRIAp6DB7SqyiAvAiV7c/HlBNGspUB8jeMaX933YKmxSj/EErp0qxHMd23jvhmIaIg/oIJBU7F+GMbFiho17R1NP1DSSTGIpouQFrcHYJKdgbjN/zJxqmDg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 192.176.1.74) smtp.rcpttodomain=amd.com smtp.mailfrom=ericsson.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=5uZB59glz7vmq0yAbr3ViVcHIYbxEhtkSl6UluLZxqc=; b=lvIAz3TG3+KMvrVSZ9SI1M5/WTy2KpWYjjwQlggg2YaTAEr/3FqWHCQL4CjhAMjB8QwOEBkpM/a7oYmKyhrlqH+BNz5H3HyZ0/MaR0ITCqZ9yYRqIwnIIbjU7q9JFVr0fSHgzKCL8GzQldBviaxDlWJ6bnYeUS4g2E5x3u2GK7Ozms9GC5LTNVrX8CP/QfKvChVI4V9gUVhYmS/XEbCCqiH93CCDdc9ZU+gvWCH2dkG6zw8IFr5wKWYDDIRIWdBx8J6U+5w5lA2e3mueGQRO5kIVGwJH8xLTDLW7n+lifF4AtAgN4REQLUEgw4U+j+LDloQrt6VfdiLc/g1syKm79w== Received: from AS4P190CA0063.EURP190.PROD.OUTLOOK.COM (2603:10a6:20b:656::14) by DU0PR07MB9242.eurprd07.prod.outlook.com (2603:10a6:10:42d::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.22; Fri, 26 Apr 2024 09:15:26 +0000 Received: from AMS0EPF000001AB.eurprd05.prod.outlook.com (2603:10a6:20b:656:cafe::6d) by AS4P190CA0063.outlook.office365.com (2603:10a6:20b:656::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.25 via Frontend Transport; Fri, 26 Apr 2024 09:15:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 192.176.1.74) smtp.mailfrom=ericsson.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=ericsson.com; Received-SPF: Pass (protection.outlook.com: domain of ericsson.com designates 192.176.1.74 as permitted sender) receiver=protection.outlook.com; client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C Received: from oa.msg.ericsson.com (192.176.1.74) by AMS0EPF000001AB.mail.protection.outlook.com (10.167.16.151) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7519.19 via Frontend Transport; Fri, 26 Apr 2024 09:15:25 +0000 Received: from seliicinfr00050.seli.gic.ericsson.se (153.88.142.248) by smtp-central.internal.ericsson.com (100.87.178.69) with Microsoft SMTP Server id 15.2.1258.12; Fri, 26 Apr 2024 11:15:25 +0200 Received: from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100]) by seliicinfr00050.seli.gic.ericsson.se (Postfix) with ESMTP id 935F81C006A; Fri, 26 Apr 2024 11:15:25 +0200 (CEST) From: =?utf-8?q?Mattias_R=C3=B6nnblom?= To: CC: , =?utf-8?q?Morten_Br=C3=B8rup?= , Stephen Hemminger , Thomas Monjalon , "John W . Linville" , Ferruh Yigit , =?utf-8?q?Mattias_R=C3=B6nnblom?= , Subject: [PATCH v3] net/af_packet: cache align Rx/Tx structs Date: Fri, 26 Apr 2024 11:05:02 +0200 Message-ID: <20240426090502.100487-1-mattias.ronnblom@ericsson.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240426073824.100386-1-mattias.ronnblom@ericsson.com> References: <20240426073824.100386-1-mattias.ronnblom@ericsson.com> MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: AMS0EPF000001AB:EE_|DU0PR07MB9242:EE_ X-MS-Office365-Filtering-Correlation-Id: 299acc7e-44d9-4f1c-3088-08dc65d168cb X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230031|376005|82310400014|1800799015|36860700004; X-Microsoft-Antispam-Message-Info: =?utf-8?q?MUrifqSh0hmLZVNyt9xh3ggZ6G/Hmk2?= =?utf-8?q?1dhrnvLDCEye8hlib0hvOpHBU9FLRw/Cr5iBzHVkq49gT1fdberf7fSXqUShqcxob?= =?utf-8?q?yU2bBFno1DkpYmLmBKnD07fGqKhxNDpg6Q1yl8ISgpNObO6TSu3vl5voRmOR2jdk5?= =?utf-8?q?9SAvHF2+2HiUJQXfeFBaaNP3L21D5n/9oidWk/sk9mjUgAeql/0CbwlsDhQkx7BKQ?= =?utf-8?q?IbZPSyIs3JrQY8MyOYFWiqskN395dBpJODwQJfBPhdet/dwJutO1XHEnXbQClHuee?= =?utf-8?q?mVj4pmsRGJNU38xI7MjKUy5N3pnEwh7w1Qe7A2rGiUEs+P7+o7HWiW8CxiasczPKK?= =?utf-8?q?lyvsmZyJBUpljU6sIBldiA7hRLe3NqEXjXL+xJSOEtJoMyNReMf66nhuSbcMrkxxO?= =?utf-8?q?UtNkQ3btIJBLrfTEespNjccdYOpUmNsx8dneyf7aU6xgEoME86z9ssAploduVmdrI?= =?utf-8?q?cP+itwgBFdpHqfJH+80CGkoZZWpdT3LvXufjz+RFf2qIFyAnptFA/IwOocmPOvovq?= =?utf-8?q?Pv6ThdTbduYHiC/Ppo2tif/3axVFXNe3QpmXjFntUFnfSCz2M7tEQkc5cE99hKvkm?= =?utf-8?q?HCA7RHXrYqZDZDay0Ao65Kh9IW7et92HPVCQIGzdureQtjLwkj9vaDvvJA3dxi51u?= =?utf-8?q?2c2VC5o/B6imA84C0Fs6GNBLr3wH0zVmq1gDFQ5dyOD+3B6ROM0IfSk1EPAE2vsDU?= =?utf-8?q?TYMSLOnBa0F/YXnE+wx/dnRAdNK3SZLYsKcw7Hog50RLcqypzGLgsfxs1iAoH482i?= =?utf-8?q?uY3svk5ZDDIHV/tqpOOIAbvth8yNAo8KaqBPGxuNFWvlw7nxqYgTSrF8YlcgS3Sr4?= =?utf-8?q?fTuSjIYQvHTtHMcWwAINklo0ASFyHBojcog32UXu7Rf74hRe6ZGRUaoIWz+krYuQK?= =?utf-8?q?DIQrfJjYGkJdZzmXMokAGDYPhBkkeY320dj/V3qlbeFCBoEwTcViNY8ZY053YfBLC?= =?utf-8?q?2X9LxJXggiVG5CuQb+wgqW376nAjUBbtczJgr77K6/ghROO4fIzxkuxC1jznlWOF2?= =?utf-8?q?H+IOkxMuxpBToPmfWk6+5Yxy06i6EVzyFBruUS1KslI/sHa0hBgQxeJocv2nPRIdE?= =?utf-8?q?qC+rSwaJpYqx1xSn7g5GO4Q61EU4dmueSenm9TaL6KEaUOUQOtEqGxMXi/0e4+CvK?= =?utf-8?q?+562kPY+y8fNZ+FzYLsous6JEO7RV+M9GTZIEw3T7fccbu8yXn4N8ldhuyigVUPlj?= =?utf-8?q?GP1eWoz+Sa8dR0XLnJ1RSEdB92avw/jl+NGxGw1zinu/ISFC8LAU27Op0rRsORKYA?= =?utf-8?q?unwIjqVSjB5anBu4dBEw7ZIMYTYgCPXsQLFtlC5/VT7T0DmfWf2A+8yY5q5hXS9Sd?= =?utf-8?q?YStDurphVfYZ?= X-Forefront-Antispam-Report: CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net; CAT:NONE; SFS:(13230031)(376005)(82310400014)(1800799015)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: ericsson.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 26 Apr 2024 09:15:25.9859 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 299acc7e-44d9-4f1c-3088-08dc65d168cb X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74]; Helo=[oa.msg.ericsson.com] X-MS-Exchange-CrossTenant-AuthSource: AMS0EPF000001AB.eurprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DU0PR07MB9242 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Cache align Rx and Tx queue struct to avoid false sharing. The RX struct happens to be 64 bytes on x86_64 already, so cache alignment has no effect there, but it does on 32-bit ISAs. The TX struct is 56 bytes on x86_64. Both structs keep counters, and in the RX case they are updated even for empty polls. v3: Move __rte_cache_aligned directive to a MSVC-compatible location. Fixes: 364e08f2bbc0 ("af_packet: add PMD for AF_PACKET-based virtual devices") Cc: stable@dpdk.org Signed-off-by: Mattias Rönnblom Reviewed-by: Morten Brørup Acked-by: Stephen Hemminger Acked-by: Tyler Retzlaff --- drivers/net/af_packet/rte_eth_af_packet.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c index 397a32db58..6b7b16f348 100644 --- a/drivers/net/af_packet/rte_eth_af_packet.c +++ b/drivers/net/af_packet/rte_eth_af_packet.c @@ -6,6 +6,7 @@ * All rights reserved. */ +#include #include #include #include @@ -39,7 +40,7 @@ #define DFLT_FRAME_SIZE (1 << 11) #define DFLT_FRAME_COUNT (1 << 9) -struct pkt_rx_queue { +struct __rte_cache_aligned pkt_rx_queue { int sockfd; struct iovec *rd; @@ -55,7 +56,7 @@ struct pkt_rx_queue { volatile unsigned long rx_bytes; }; -struct pkt_tx_queue { +struct __rte_cache_aligned pkt_tx_queue { int sockfd; unsigned int frame_data_size;