From patchwork Fri Apr 12 12:52:34 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139257 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4CA9043E52; Fri, 12 Apr 2024 14:54:16 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2B90A410EA; Fri, 12 Apr 2024 14:54:11 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2055.outbound.protection.outlook.com [40.107.237.55]) by mails.dpdk.org (Postfix) with ESMTP id A4A6741156 for ; Fri, 12 Apr 2024 14:54:09 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tr4UFSpmESUdYH5YSSURI3Rxz6XgECzKregSjHKRXfKLWEyUhRY+nG1mDRir0vBJRKeO+VzfRoQpgrx6lCD1Ya/YuhUMUqeZ+Bc/k/gdm+/C3dBR6E5I51hzqPYg6JWFkHlRaqXPm72WXYtmTpTPo7e06inDYXG1ZhBV6sT3Tk/ShplX17ky1znKdLk33eIwXCoN786utQ94Ks8XQNbDNbUaLZq99P1wSM90DpoKyFrXAFEZ96b7jjAbqECbq2rR5rM1z7jHevJ/ErrI+L22Lsf8AN/6LwE9rcYr7Nc0Z+z2YJN5/3jO7AcgB+WAE/EHhoZ2r84yLzxFb44lALHc1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=fNB1b7SJecYdKIebCXU75EI5K5FU9d4cDURpyhBaWBA=; b=mjMhOYpmrHOrRjj4QmNxc+zeoh851sigjo1YPSa2YYe4ZUPAI+ByjS7HDkLb803hiti+8uPjbhfuhtwDayhUehoN/s1QrLZZXjsLZCcuUeYGaOfsj1RynFBdTSuXGL5L7gi95bHqk3zG5mFKM6gRwB1o5sdwJOOW6/U2HkZypML8nE7+XKRNR0rThSvF+xy1T1TEJ+jUplZ5Df8b0HWqz9nyeaoVMtScHcL6JiVby6zDeFpZr1tOADHmdTzy7/eLzesPNY99LXJK3MzUywwxTMeWtZhHYJJPGR7XGJNtSUxko+bLPHjnnaCzu4nVvAozW9iCP0IA815XvgpmDxObjg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=fNB1b7SJecYdKIebCXU75EI5K5FU9d4cDURpyhBaWBA=; b=FQ/8UytSKlKN3qyiZPKiK0cNf0+EKl7olOvtpKoj0TT5S6/6/W0k6khl2TndG0FU9FEZJhFd4PQFXeMDP0ggtr6kyyPdMwjtp0gQOZ1lgJuAyfOBVibEbaiAAGcebFT4mivHErquKLGHeMnFFnsj6j5fkKY75xoUV/qcM53klOU= Received: from MN2PR22CA0018.namprd22.prod.outlook.com (2603:10b6:208:238::23) by IA1PR12MB7663.namprd12.prod.outlook.com (2603:10b6:208:424::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 12:54:07 +0000 Received: from BL6PEPF00020E5F.namprd04.prod.outlook.com (2603:10b6:208:238:cafe::a9) by MN2PR22CA0018.outlook.office365.com (2603:10b6:208:238::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend Transport; Fri, 12 Apr 2024 12:54:07 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:54:07 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 07:53:53 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande Subject: [PATCH 09/24] net/axgbe: disable interrupts during device removal Date: Fri, 12 Apr 2024 08:52:34 -0400 Message-ID: <20240412125249.10625-9-VenkatKumar.Ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> References: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E5F:EE_|IA1PR12MB7663:EE_ X-MS-Office365-Filtering-Correlation-Id: f8efd960-08a7-47cb-342d-08dc5aefa3fe X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: qW7dsoFV+V9X8hoYki18WFxWHHsH0YTSJJ4u0r+WJ1e01aCOS614kJFQUgEikoioOj27G6jPp4P0pkWWgAR55k5Gak2mC4kmBVruIfIlafW5zVwgbE/yArNPZJBzAzEFt6O32itEfnOzkqActtdELcsz0FUQk23+WN11h/h1urxYL3wPazhPS1fSAspuhgyAcU9ChScz2DqEmbU3EUM2QxwkmdThvsTH6Llb4XuyxfwPMnZvEhVLLcehe1VXISE1LDsSnyUefVJkaVq98OpkiWD8IVgrKgdQXDgsYaBOC7CUb6XQ8JTlzLDilP9UqVVasbvjMtCT1t2P8kNb+4Pos1pCEx+VT+ssCkXcuXWp32sDKEYOjLl3iia+oTiaVBbaCyzAzCj+xhKFffjWbAR/KNIVKy9rJZ9o2LYcVj+P1kD5Bgo7M+VSMJVP11VhuKUXYYnlLknkKNCefr4Z3qPjdd8eM6k6l9FtdoEtIoPRpci/s/+7fMEFmwNZCybhxcdTDAA/UfnN9a+2Jxksgl6r63bDOm2nWXPd+LyaAGzRiGxrPAxi1j/psF/fqp5nHu4CJpw0j8x8uveqG9kOcDbDK1hRlIg1GCBwn7WUQPO6IcyTbJSniLUVHaKxB7N+yWoNHLPsx3XYAOJAUyFDMb9Wswgk83SmkD/tpeljmQ4Jjb3R1WMS3V50rzdtqdYFyc2kOG7zXzn+OlS2hZC8Ntm2Q7BOvOmolrmkJYyX2eYNoAbBQEv03nmwwDwtLRkaoT8P X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(1800799015)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 12:54:07.4328 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f8efd960-08a7-47cb-342d-08dc5aefa3fe X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E5F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB7663 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Hardware interrupts are enabled during the init, however, they are not disabled during close. Disable all hardware interrupts during close operation to avoid any issues. Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_ethdev.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c index dd681f15a0..e5d8f7db02 100644 --- a/drivers/net/axgbe/axgbe_ethdev.c +++ b/drivers/net/axgbe/axgbe_ethdev.c @@ -2411,12 +2411,14 @@ static int axgbe_dev_close(struct rte_eth_dev *eth_dev) { struct rte_pci_device *pci_dev; + struct axgbe_port *pdata; PMD_INIT_FUNC_TRACE(); if (rte_eal_process_type() != RTE_PROC_PRIMARY) return 0; + pdata = eth_dev->data->dev_private; pci_dev = RTE_DEV_TO_PCI(eth_dev->device); axgbe_dev_clear_queues(eth_dev); @@ -2426,6 +2428,9 @@ axgbe_dev_close(struct rte_eth_dev *eth_dev) axgbe_dev_interrupt_handler, (void *)eth_dev); + /* Disable all interrupts in the hardware */ + XP_IOWRITE(pdata, XP_INT_EN, 0x0); + return 0; }