From patchwork Fri Apr 12 12:52:32 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139256 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 45E0A43E52; Fri, 12 Apr 2024 14:54:09 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id AD9EE4113C; Fri, 12 Apr 2024 14:54:06 +0200 (CEST) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2044.outbound.protection.outlook.com [40.107.100.44]) by mails.dpdk.org (Postfix) with ESMTP id 5BCFD410F2 for ; Fri, 12 Apr 2024 14:54:05 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Rr0o2e3k7NMZ9fHu5021JTLteqYJFkNCNdKmmUM5KSShMtGY1hTt8Su1IZRgdvCkJuh6wuoaZsMezquQLQ2KFyDQ0YdEXu534mVAJdnjreCkIT/Vr4tf/3QtLkBu8AL5JlTb8zPk18y/YhRXJ4LpTk2N/r0DqJT7UhWnlS8FkAeFS9G6SSc51V5ups7LappxHFr1cItlE05r2wVL2aI19rLy5swEX1KZBBhlwNJYWPfUC3nIhm4XtXNYLpHZ1BS7pBfl5N7Lb2HgdOroEOPxdHjTc/1Ey94+T1ndgR8sEljKdaDqZg7ylTPjR+0MUmMG7NmNIvkzN/jDuyw+wy6wvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=xfKZS1CNXUtDVzi3Wm6+/otF0/UI0+My7pvfZhpczM8=; b=b0eOw6VkiQKH/3AT/JB5vNP/O3uLf9xx4TJx6LSzuiK8KTLdnc3YoojcxqqH4ovV2JgVLqDdWGB2i7XBmECNLr6S+IJt8Qet+NHmPXo91+iIpuGhdDa91ayYO2VxCKZnTNYlWqmptBMi8pQKE/eta2Tn7eyjw6d+s16B4rN6Zoo0mt0/SulqOyzWe3skMiom8/crecsZuZITs4WEq3v4IUcrYHC+JsSrFWFxr851dpua9w+4IcdJ10SGsYeDBEfM3upvRtZxtUSMHnqMf1C9N9zoQzdGlhjDa9qXgkInFFBo6QvU+HXCpWFWvIkVH2eWZO4IEja9CchY+1/hUtmUEw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=xfKZS1CNXUtDVzi3Wm6+/otF0/UI0+My7pvfZhpczM8=; b=AV9MrSTaVhRbLCgjmsaHl94vxVcX9FWbrFRINC124Ir3Fh4Dcp95UO90zhdJQ3Acp64XknGIDukqyFOkNiHAgvz9P7QHSAsfrf2B0mw7igmIl+Lj07qr8TJoy5LhL6jm91UA54R44Nljf2oyQ89aLBGkh3U48oRDrem5DaPBerE= Received: from MN2PR22CA0020.namprd22.prod.outlook.com (2603:10b6:208:238::25) by CYYPR12MB8732.namprd12.prod.outlook.com (2603:10b6:930:c8::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 12:54:02 +0000 Received: from BL6PEPF00020E5F.namprd04.prod.outlook.com (2603:10b6:208:238:cafe::b9) by MN2PR22CA0020.outlook.office365.com (2603:10b6:208:238::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend Transport; Fri, 12 Apr 2024 12:53:57 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:53:57 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 07:53:48 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande Subject: [PATCH 07/24] net/axgbe: check fluctuations for 1G BELFUSE SFP Date: Fri, 12 Apr 2024 08:52:32 -0400 Message-ID: <20240412125249.10625-7-VenkatKumar.Ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> References: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E5F:EE_|CYYPR12MB8732:EE_ X-MS-Office365-Filtering-Correlation-Id: 7c64d552-a646-4ee1-a645-08dc5aef9df7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ZcAkMEKMmBVIbEMeISbN5L0CqlqVSzOA6UtWlH/YbKX3S7iQEc0P8oenAz/FyCaH49+mnIhgRUkLr2f7pfuAF8eUQnF2vmyd0FhRvlqgEYs7AkWWgSUMpSubHma4cHNUk29xPPuJOYWZN6p7s4XSrH4aeqF1JszrC4rkv3w9wHY2vQg4haXaCviyOeMpPf9jHfyKXSDjoCsBNA/UMUIw9tmmUlnt9q4yoreR3bmaolQJxkpOZR+8HdFDizNWVlfxndsZbZrmEPmUk5Fi+EaKujhIkiL+rezfFfhoLudenF54gpyzRByg7J+OCzVbKLzG7gJURSnkTOfQOuNc4k58mqlnyB+GICUMW0Pco6qq+HvmHI8USMZn9ZFNujhkLHHHDSTcv2YgDxz+Kfund7yzedl9m2JIYLOvPpPA8evIf1CTyjMesFKJf4t1IuxMkMtXqnJTO2kgA/QRQKeaeNctSnaJstWRysz1DaLLB+dnz+9XZfFLFtfH//fgkjJr/S1V8ISag5meBZLen5Etjy7XXyg2C/MEVVA2+cOeINO3ZVng5ziFQkKkjSdNHA0nRbe9ltI+uIjjXTYqFwvAd/hJyUtb7qpineK5wcZ2pQDm80i6jcGma6O7FMK3a7eNXDMFsywpGMBlLhxchV8M6TTuu7W09eb5EPGQa+1tDcNPUElucQTFQgKTyUt4VXK5LFq6+OtUQ7ga2oT3YiTBqnn3wQ+fx5qqhJUnrrKBBfFuy5wokYCsiUMctbtLzsuC2s3v X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(376005)(36860700004)(1800799015)(82310400014); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 12:53:57.3235 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7c64d552-a646-4ee1-a645-08dc5aef9df7 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E5F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8732 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Frequent link up/down events can happen when a Bel Fuse SFP part is connected to the amd-xgbe device. Try to avoid the frequent link issues by resetting the PHY as documented in Bel Fuse SFP datasheets. Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_phy_impl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 968ff1f867..1ccb95334e 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -563,6 +563,9 @@ static bool axgbe_phy_belfuse_parse_quirks(struct axgbe_port *pdata) /* For Bel-Fuse, use the extra AN flag */ pdata->an_again = 1; + /* Reset PHY - wait for self-clearing reset bit to clear */ + pdata->phy_if.phy_impl.reset(pdata); + if (!memcmp(&sfp_eeprom->base[AXGBE_SFP_BASE_VENDOR_PN], AXGBE_BEL_FUSE_PARTNO, strlen(AXGBE_BEL_FUSE_PARTNO))) { phy_data->sfp_base = AXGBE_SFP_BASE_1000_SX;