From patchwork Fri Apr 12 12:52:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139271 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7685F43E52; Fri, 12 Apr 2024 14:55:57 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 57B4A402A2; Fri, 12 Apr 2024 14:55:04 +0200 (CEST) Received: from NAM10-DM6-obe.outbound.protection.outlook.com (mail-dm6nam10on2078.outbound.protection.outlook.com [40.107.93.78]) by mails.dpdk.org (Postfix) with ESMTP id 1B705410EA for ; Fri, 12 Apr 2024 14:55:03 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=T6fUENtozsAZ6T5ak21xg1k1ASPgEXqZkkeNXCOPrs8x5i1V4M6JIz/IG06Cb9OC5CuhcbfSR7Wv9+355H0RR88mx1uO9/9qG3Yij8F/kJQ2u/y5W1me6A5+pu1TONMzkFEm66fbK+zBAGGINf0jg5sGDHzPzjIcB6MWDi7lTC63XAPJ7z5UewYA/iEvwmp1mHnSiu/JLd5IXGDVo/IuqusUwGMt3yODo3zXmsO9mh/53cIF39jCGteGYoqWFq+RPnhRUdGICApCp4UYHn5NyElj7dX+uUaito2JKbBNvsDiHa3wgxIeQp1k98KRbLZ9dCI3NkTnjgnVqH12K28xxg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=0HNWjSgXrs6CB/1c97svEBsVYDj5CKuakmGXyvktvXw=; b=VxnoFwodJ0Al/VIzdTpQUJe/NYiU8WTtn9X9UwPCaNldKx2xTdURtbVvOEuO7YXTyqvtHSzqG/1m9l10GtF6K4zsHp8cKDYU4v145p7N6qqZuxVKBdOUzBDkDbPM+ODBffEwdHkiOcSZxcX7srM4CLYPzl4Z/XChS+vNbDi1Z5Ifdv1FODMWLUEwy0e/sw36yghzUWm/P3D06x8yXQPQa+uoZCEE0hYv5KNL9mA68It+2t14qSdsOn213yhcGUw1uoYjuSYIonyQLFG25gAK8t15MmLvUZFLcqi48YpW12MC6BL3b+Exttu5gK4i4FNerq3tPHAh0LYLHarcnfhkPg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=0HNWjSgXrs6CB/1c97svEBsVYDj5CKuakmGXyvktvXw=; b=Lk/TC6ftwytTJ1x2XAv3Gm3C98wUpXtHmeRHIB6kCbKvb3jwJm9UTkVI3Hn4o0a5dGEXbms3s3WozITqEsgYkU8sbd9Wu0tnFQTTSLtyH0e+pbhmM87bxB2PV9Da6GQ9zhsuCrlyY7e5POpgHAJ19OZZJsN96k+XhztbFbUMBXw= Received: from DM5PR08CA0041.namprd08.prod.outlook.com (2603:10b6:4:60::30) by CYYPR12MB8655.namprd12.prod.outlook.com (2603:10b6:930:c4::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 12:55:01 +0000 Received: from DS1PEPF00017093.namprd03.prod.outlook.com (2603:10b6:4:60:cafe::63) by DM5PR08CA0041.outlook.office365.com (2603:10b6:4:60::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.22 via Frontend Transport; Fri, 12 Apr 2024 12:55:01 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017093.mail.protection.outlook.com (10.167.17.136) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:55:01 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 07:54:27 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande Subject: [PATCH 23/24] net/axgbe: improve the false linkup in axgbe PHY status Date: Fri, 12 Apr 2024 08:52:48 -0400 Message-ID: <20240412125249.10625-23-VenkatKumar.Ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> References: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017093:EE_|CYYPR12MB8655:EE_ X-MS-Office365-Filtering-Correlation-Id: 7fcf8acd-23d4-4e6a-9138-08dc5aefc425 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: w4N1giZzrA/Fm5tBCkLrKtgvn410iCR4yNaXHcJZUL8dqe/QLoDHW75fOolMwLo48KRA0WZVIVEvwxc2okR1cEQbUW+wT5yKi7sAsMABg+3+uTSthncguXFfQGWhZriGqp2ivS9Q2H3XwGyQntDGDrVAMkUIaer6PIo3hNtptsCGoRO/FswFd4LiUh+RQlsf6x9ihEUNEmHzNI9cUxGe04b5DAJOxyz8aOKnEayP5HKGx9fudN8CXvA+vLR/a+m/esPIKUTyJ73Q0Pr69O/4MG1iJHgcbKBTYufk3L5KwcLC18QCN+77+yk9lCK9boDFbObIs4Y3cta+JsDT15gwhSmzbFcrDqLOUhI6+KICzi0g9ZjuNurH8NPUdRsr8giTxZnAvGpQ6AgKZ5ry8YJLHkYOW73BcW3OTkJuFbu103Wd4aeLtuvkP9XOL7zkRefhl0iEVvAqVpi1rsVtWVtZehYlEB0LQy0r4PNZJqZFVY70Av0whfCYFtno6aYTWa5wCidRKBsAE3FdQJEBSWN4tfsy7lESo7J80kWxDgBXkwle8/++TUy8tIpxzdhmjsl/7g6cpWlD6omjGCfguGKiauFbZbSm67aJpHML5EV+yJxArRPGtyA6exgZ/cngyongPtXHdRqGSjjfBlhrdmzN9HhpwtQMymYm9a7wpmW5isL6UJnHlnVMz/p0R2B0unVdY5co69jevExDhwBnALi0SPllwjhSk3bcUmOmhE7+EpAbVQf11fcYAUM7BCMTO2H6 X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(36860700004)(1800799015)(82310400014)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 12:55:01.3466 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7fcf8acd-23d4-4e6a-9138-08dc5aefc425 X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017093.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CYYPR12MB8655 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In the event of a change in AXGBE mode, the current auto-negotiation needs to be reset and the AN cycle needs to be re-triggerred. However, the current code ignores the return value of axgbe_set_mode(), leading to false information as the link is declared without checking the status register. Fix this by propagating the mode switch status information to axgbe_phy_status(). Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_mdio.c | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/net/axgbe/axgbe_mdio.c b/drivers/net/axgbe/axgbe_mdio.c index 9fe30e83bc..130a67479e 100644 --- a/drivers/net/axgbe/axgbe_mdio.c +++ b/drivers/net/axgbe/axgbe_mdio.c @@ -1028,7 +1028,7 @@ static enum axgbe_mode axgbe_phy_status_aneg(struct axgbe_port *pdata) return pdata->phy_if.phy_impl.an_outcome(pdata); } -static void axgbe_phy_status_result(struct axgbe_port *pdata) +static bool axgbe_phy_status_result(struct axgbe_port *pdata) { enum axgbe_mode mode; @@ -1065,8 +1065,13 @@ static void axgbe_phy_status_result(struct axgbe_port *pdata) pdata->phy.duplex = DUPLEX_FULL; - if (axgbe_set_mode(pdata, mode) && pdata->an_again) + if (!axgbe_set_mode(pdata, mode)) + return false; + + if (pdata->an_again) axgbe_phy_reconfig_aneg(pdata); + + return true; } static int autoneg_time_out(unsigned long autoneg_start_time) @@ -1133,7 +1138,10 @@ static void axgbe_phy_status(struct axgbe_port *pdata) return; } } - axgbe_phy_status_result(pdata); + + if (axgbe_phy_status_result(pdata)) + return; + if (rte_bit_relaxed_get32(AXGBE_LINK_INIT, &pdata->dev_state)) rte_bit_relaxed_clear32(AXGBE_LINK_INIT, &pdata->dev_state);