From patchwork Fri Apr 12 12:52:27 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139252 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9F35043E52; Fri, 12 Apr 2024 14:53:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8DD9C410EA; Fri, 12 Apr 2024 14:53:27 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2045.outbound.protection.outlook.com [40.107.94.45]) by mails.dpdk.org (Postfix) with ESMTP id 0F087410E8 for ; Fri, 12 Apr 2024 14:53:26 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lTDeBg3ugMpdlvhCVmt9C5BZ/8IP/UNFJ1ATHroN2bGAQa1a7h4Kz0I4SK4ZV83cfg+J81x5Xk25C0Te+P9iYLuYuMQbyRkPjkZCEf2DoDsYGEHScNmUGvTQHeJMkvkws5gvtT+XNo1O9v0Gut3/VEktieeIR+4wDFk0cArLqo6FodmF2+rbKcpIRS5qyiXKwL8s/jhvV0xLl06HefzldNRn30QsFtQyDgUGSZVNVG9r1pSJc/uUY6g5neRnemYyugQKPLFMmqMD7byLYUWEXoX9JWchYFBJ4v+deutAzcnRjZeyql9C1t6e9fjiZGXUQyEv46XhxeDph6Dkye3vDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=3deEJNjXTjoA0mdRdPf5pfTdaVfXk5kH92Oju3WV4ao=; b=DvC9Yk45kCDPrsNMDH+Xaq7BATkNxa4wi4mA06/a0MQXQeK8tapDnXCtWnho8QbMJnkkmfBZrK/GihsxJn4Xr9zez9K6LB88A6Ijp8iL/KGBqOAYHvVEYEExOF5HW+Tr9WCbXZlfnddlBjunCbg+tXMnsbmp9y/j+/xq6T6mrqnAE3Jnlxmm/63fDTJw9viNTEIQUfXwzvChjzdUdaI8cscMn/4B6d+eeHVff7FPEsgZpuhu2Bt3ZEIXP1xCXFCs/4Cho+r4ZENILsJFd1G2FTqj+bB4lfxMLD2XVKWeqLMObR1Jigm47Rz+6I6sjdSjj2AG5oP4a8TmbbPTcK7Saw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=3deEJNjXTjoA0mdRdPf5pfTdaVfXk5kH92Oju3WV4ao=; b=ZZrSi7p7T27KEGvK3egmmCHec+v29TWB47+JZAhZnpqX4F8E4eb+k/DxGFq3WGtSr19KrXbLfgTx4W0pkfNC7Ab8RN1FmX963YjQh3U5IyGw86poyNc+ktSlxa2MusHhk/5G+4te9zL/1LsKPMyjh2jaM8I1loTj9fXmXjszwho= Received: from BL1P223CA0002.NAMP223.PROD.OUTLOOK.COM (2603:10b6:208:2c4::7) by DS0PR12MB7874.namprd12.prod.outlook.com (2603:10b6:8:141::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 12:53:23 +0000 Received: from BL6PEPF00020E64.namprd04.prod.outlook.com (2603:10b6:208:2c4:cafe::4) by BL1P223CA0002.outlook.office365.com (2603:10b6:208:2c4::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7452.26 via Frontend Transport; Fri, 12 Apr 2024 12:53:23 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF00020E64.mail.protection.outlook.com (10.167.249.25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:53:23 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 07:53:21 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande Subject: [PATCH 02/24] net/axgbe: remove field of SFP diagnostic support Date: Fri, 12 Apr 2024 08:52:27 -0400 Message-ID: <20240412125249.10625-2-VenkatKumar.Ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> References: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E64:EE_|DS0PR12MB7874:EE_ X-MS-Office365-Filtering-Correlation-Id: 08e2b9dd-6bee-4d8d-14c7-08dc5aef899f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dpO4JFSkPczAXhdRTlKTxMrEvJbtOTNgwoqm//yAw+VoFi0KY4utDC8Af5IU40lbPY62bto5F+3RZnz7dCflIuJrSrfx3zUKqHK7Nwx1s/+5NWNeOIlNrmrza7Dv8XRH6b+q86DXTaW497YMSnPHxtvQuK4dSulvUXJhhX/RzYIrhFn0ODASrRYPuCQGZ+n9QI80bzWK1DKP0sGNBKHmX+03OoecR3UNExJy16PD0pEcR2rKpyI1ABeL5VCIojkAAM5lmD5h1ArOP1/h3IqrRdYFHyKBt/+we+K/HLJKrCr5B/y0Bjr0N/2taQL/FvPc9PHymIPiUaQiD36H+Eutt8VFuOBY9WC2WKWz8JawFh0ooc1KUZuP+10wP39CIvsZQfdxPQXhqdrgx+trnrYH9E9MJUmwbAgj35yPf6D+HOCsBguJ5MErusqN4XlVvcMtNYGJs8yxvwZuFemdTGQqUySucm1r0l14+jgeZqyw3dyDbmCVaG56pWchYefvF9RNBtzggfBWoKNNIQnFjeWSj2dISVhUqKAO7M2TXGsWghstR6fOmk3aTChLQhsxIBkZQbaxk/JoPlYCtWIr2VKUKRZODz9UGKFfn7cKGqvG5HIZOOO8SHYD6OYAl5zs2g4jco9SVbJaAXmU2zfB02FrHUJPghoRZqzd23ehd+UR4wPgsLgMuNbdj49E9kh8aKU2ydED5edlhgJcQpWf1MOHJXEWqoZf6gdivGAwMUvdH6fXIcvPrbWdf9a8Bu+S4EhT X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(376005)(1800799015); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 12:53:23.1886 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 08e2b9dd-6bee-4d8d-14c7-08dc5aef899f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E64.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS0PR12MB7874 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The driver currently sets an indication of whether the SFP supports, and that the driver can obtain, diagnostics data. This isn't currently used by the driver. Remove this field and the logic supporting it. Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_phy_impl.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 70e7c56439..e1b926d48a 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -220,7 +220,6 @@ struct axgbe_phy_data { unsigned int sfp_rx_los; unsigned int sfp_tx_fault; unsigned int sfp_mod_absent; - unsigned int sfp_diags; unsigned int sfp_changed; unsigned int sfp_phy_avail; unsigned int sfp_cable_len; @@ -701,14 +700,6 @@ static int axgbe_phy_sfp_read_eeprom(struct axgbe_port *pdata) if (memcmp(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom))) { phy_data->sfp_changed = 1; memcpy(&phy_data->sfp_eeprom, &sfp_eeprom, sizeof(sfp_eeprom)); - - if (sfp_eeprom.extd[AXGBE_SFP_EXTD_SFF_8472]) { - uint8_t diag_type; - diag_type = sfp_eeprom.extd[AXGBE_SFP_EXTD_DIAG]; - - if (!(diag_type & AXGBE_SFP_EXTD_DIAG_ADDR_CHANGE)) - phy_data->sfp_diags = 1; - } } else { phy_data->sfp_changed = 0; } @@ -769,7 +760,6 @@ static void axgbe_phy_sfp_reset(struct axgbe_phy_data *phy_data) phy_data->sfp_rx_los = 0; phy_data->sfp_tx_fault = 0; phy_data->sfp_mod_absent = 1; - phy_data->sfp_diags = 0; phy_data->sfp_base = AXGBE_SFP_BASE_UNKNOWN; phy_data->sfp_cable = AXGBE_SFP_CABLE_UNKNOWN; phy_data->sfp_speed = AXGBE_SFP_SPEED_UNKNOWN;