From patchwork Fri Apr 12 12:52:40 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139265 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 5C97843E52; Fri, 12 Apr 2024 14:55:18 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D3EF442D26; Fri, 12 Apr 2024 14:54:25 +0200 (CEST) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2047.outbound.protection.outlook.com [40.107.223.47]) by mails.dpdk.org (Postfix) with ESMTP id 1DA9E42D66 for ; Fri, 12 Apr 2024 14:54:24 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kkQ3B+yMbZVFZelQnOPQHkHWWbGA4XJwiAaEKKwnYO0QuVfOCFrvIKOFwQuqbSALG/uHrZrBuKtqVfJFer98SAjZwfmv9kChADUaL0iuoRgav7wgLEnCaazxt3VRM1V1PDSNG8BWrGJMXix//jh+FyPlBHdq+ZoePVjXs3oCNOHJG/2ZvPdIgc6vhaZI0O9ZIEvHAoTIMnIhLVNs67MSWGnP+r5G34hrE16cccrwua2ibC2v5xyU4ENB623s1A/A8SZiJuRWbBt6CbMYgsN9XfwVXhtS7Ekf/X9immqHjk9/gbkYJNgHLUP8Y9Rwyi8NKHnbjoSHYCBINsj4tejlHw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=v/W6hg5/chTdlMxbhWM1XQ1OleLuvg2ljXH5WQzlqQI=; b=gpHSeoSElphkLsMByOXzTs6xAyrsugjXC0qP64h0hTTJOwGszf4dCDQUQ5Fktl3fX8PWVEvd/cIhs2vdDdRI6L+RsDVikHhc5RMnpcXR/CrdL+M1ZjxN3YfmRXyNbCLvM5UYzp2tLXAJi+NJDSo/8AHfqNT7eo2Jf2ITD5FIUWBAaCEcZACkmrM3nwg+q3JhAmJt0O2oSs35smEw7B18LNVFL9KMBeTTjr2SxYcvKEq4aYqUXFcnsciyuCgXQq4brzG5Sys0kRsCKnSq9nvy6ukWdwL2Mv5HLdTkRVn4byB8OIpEYX4EJjwRCqI/ts88Dvaaq5fUBb89ZARw7TItkQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=v/W6hg5/chTdlMxbhWM1XQ1OleLuvg2ljXH5WQzlqQI=; b=L5zlrTLUxFetx4a5HdZRuPgtDvwDnFGH9ZEWvKEL5Cu+q7wnCQbfsOZKtPdGTKqAmEMtnmSVl47WOyLvB7mqxDF6YqlValyMEDshnGXK+v0MZET3tG92VCr9b1SSMa63Aefn02K+w4/MzNDzy5ch9E28ovYsRlez8oudO/rWv+E= Received: from BL0PR05CA0020.namprd05.prod.outlook.com (2603:10b6:208:91::30) by IA1PR12MB8309.namprd12.prod.outlook.com (2603:10b6:208:3fe::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 12:54:18 +0000 Received: from BL6PEPF00020E5F.namprd04.prod.outlook.com (2603:10b6:208:91:cafe::97) by BL0PR05CA0020.outlook.office365.com (2603:10b6:208:91::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.13 via Frontend Transport; Fri, 12 Apr 2024 12:54:18 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:54:18 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 07:54:07 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande Subject: [PATCH 15/24] net/axgbe: check only the minimum speed for cables Date: Fri, 12 Apr 2024 08:52:40 -0400 Message-ID: <20240412125249.10625-15-VenkatKumar.Ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> References: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E5F:EE_|IA1PR12MB8309:EE_ X-MS-Office365-Filtering-Correlation-Id: 822937e5-f724-4d82-a610-08dc5aefaaab X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: TBNLDIGtEUCnhjlGo8NqUHvqpxARNg7RRGjwRml06DNTUdlIQ8YGC8x80GN1Znm7tiU6gn1Y14+VVstrFx80umt8h3bup0lbjzaU3Mj+rV6QDrMBtHD4NUGKeGgnARChxNSh0fMWjr3UDF1/qhNe7k5yluQbP/oYazTrxE1+OMOwspV+GoUDI+/+Tw8otYXe/4VPHTuw1loIJ6jbVQL+HTWbPOH0Af4vmoxCdJUNcgI8Vp93dQwgUmVP8D/jaDsDLMFzx5uE87HwBV/rEMUJcgygdFadQ213wA5/1eSuAsBvlBE2kMrqDg9uXapZWg5diJVRqS8OirLXfWVYp42yqPN3um/ma5LfIZUn5aPyb9ufGQp5EneH7T5/Vm/A1fWakPVlq4rR1Zp3eLA6KTPBnu86vMggm+O5ABUv7/ShBcKuu9Pveh6mareBNWEUo1cCAPky7ZchOtAXsaok2p7bE/0eHloFdMvfSlpHYBow4Ynm+un+n1/TetSZBeT5AOJD+Ep7kRLQtO5L76Eo87Ey/vScuvoJeGa3sBgbNurlJcIW5w6zIGejrVCw+4OKx451VwMuD3a/UKOSyrDfitb/fK7mLgsFSTINaf8glaYEfCFzAnregQXJ/HCVBR4Q4+XK5sMDl8f7F2BLvWzHT4IaFf+EqPMZFJIjy6N9lyDUBAP7yRGIqz2pTkaLZvxYdHE87WpX0wXeV/pJFwDeXD9M8ejYmByFCBNTt+hYjS1XnJX5TCei4H5ngx4liL96nE0H X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(376005)(82310400014)(1800799015)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 12:54:18.6516 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 822937e5-f724-4d82-a610-08dc5aefaaab X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E5F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB8309 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org There are cables that exist that can support speeds in excess of 10GbE. The driver, however, restricts the EEPROM advertised nominal bitrate to a specific range, which can prevent usage of cables that can support, for example, up to 25GbE. Rather than checking that an active or passive cable supports a specific range, only check for a minimum supported speed. Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_phy_impl.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 693590da53..67a18e7c55 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -117,9 +117,7 @@ enum axgbe_sfp_speed { #define AXGBE_SFP_BASE_BR 12 #define AXGBE_SFP_BASE_BR_1GBE_MIN 0x0a -#define AXGBE_SFP_BASE_BR_1GBE_MAX 0x0d #define AXGBE_SFP_BASE_BR_10GBE_MIN 0x64 -#define AXGBE_SFP_BASE_BR_10GBE_MAX 0x68 #define AXGBE_SFP_BASE_CU_CABLE_LEN 18 @@ -519,25 +517,22 @@ static void axgbe_phy_sfp_phy_settings(struct axgbe_port *pdata) static bool axgbe_phy_sfp_bit_rate(struct axgbe_sfp_eeprom *sfp_eeprom, enum axgbe_sfp_speed sfp_speed) { - u8 *sfp_base, min, max; + u8 *sfp_base, min; sfp_base = sfp_eeprom->base; switch (sfp_speed) { case AXGBE_SFP_SPEED_1000: min = AXGBE_SFP_BASE_BR_1GBE_MIN; - max = AXGBE_SFP_BASE_BR_1GBE_MAX; break; case AXGBE_SFP_SPEED_10000: min = AXGBE_SFP_BASE_BR_10GBE_MIN; - max = AXGBE_SFP_BASE_BR_10GBE_MAX; break; default: return false; } - return ((sfp_base[AXGBE_SFP_BASE_BR] >= min) && - (sfp_base[AXGBE_SFP_BASE_BR] <= max)); + return sfp_base[AXGBE_SFP_BASE_BR] >= min; } static void axgbe_phy_sfp_external_phy(struct axgbe_port *pdata)