From patchwork Fri Apr 12 12:52:39 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139263 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BCBC743E52; Fri, 12 Apr 2024 14:55:02 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4602742B71; Fri, 12 Apr 2024 14:54:22 +0200 (CEST) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2048.outbound.protection.outlook.com [40.107.243.48]) by mails.dpdk.org (Postfix) with ESMTP id A96514113D for ; Fri, 12 Apr 2024 14:54:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=oIj1kpz22poJSL89FraPI/p7YRuCXnu7fgAH9eiYjh761+DYOQvIeK7k3nnl35kfdT3w10om7PmfOicPlAlDf+dXM/46xnYsJHLp4BC+ZeibdElhDW3TcKKznKjmVv3MD75IL7pWAuV/G068q6GhFW7Sh816wwq5nbPHmCFwAwNfidUOCr3Jr51NTfL871V3bxjvjPJCVeUhUcjNZ+LDFYfqeptkAIGWGA4TpYwXbBX3ENO1LxxeBa5eRQqEtx3o/FoWbNeropJ3B9wdOCn4akrg7f5CCn3S3noF3nbwT3kUhHa8QV0Ln0cHJ0a11wHnE/WWCDnz4jQa7tqPdNS9tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=8q318KTNcCFmozCYb8NPVHO2lBHfzFAcA0rX1jY/sRY=; b=PQzWkP3wVd4eRHu1k9nRvEws53HB+YbmUeRbJxvW2rjLZQ0WlxspfHHAyGvBet78K9GZFphW+sQxOESN3EY4sICNxNGKkgePG1mI1nahrlzKBLhL7jcYRJF15HlT6iMt77dYL8vr+3QM4xyKKLVjeNPtYBhmAKYzdKyChOPsaScGh1Rt6BiXS7mEVVdZ7VbrEgC7xY429170nvOYHeE7aqJDZzoTuVLDBZ4j2faRK7ZvS6PXziOLAqXoW6uQ8I129OlROnewQYcthC8WmhcMsymtTuEvXhYYmPOW/F2oCvG2dfisa7QDjdFu+QjMFNHDH7mS6SV9a0nMirA8X1EnUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=8q318KTNcCFmozCYb8NPVHO2lBHfzFAcA0rX1jY/sRY=; b=lEPsjTj6czgjy4X9bBGvAMVFKvdu8mlTr62f4D+sXwyj4Ncg21wjzFWmM+nHGLhN7lDxGHsF+3l5GhakIJtVYXpjVc0OqlGB6wWd1ro9HAk5WZzUwPkCghxCyxDiuTnf8+qdp3h+YDWk1bAWB+r6ZAODoFX9/eHGcjp/1Q24uco= Received: from BL0PR05CA0023.namprd05.prod.outlook.com (2603:10b6:208:91::33) by DM4PR12MB7696.namprd12.prod.outlook.com (2603:10b6:8:100::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.46; Fri, 12 Apr 2024 12:54:17 +0000 Received: from BL6PEPF00020E5F.namprd04.prod.outlook.com (2603:10b6:208:91:cafe::7) by BL0PR05CA0023.outlook.office365.com (2603:10b6:208:91::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7495.11 via Frontend Transport; Fri, 12 Apr 2024 12:54:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:54:12 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 07:54:05 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande Subject: [PATCH 14/24] net/axgbe: improve logic around active and passive cables Date: Fri, 12 Apr 2024 08:52:39 -0400 Message-ID: <20240412125249.10625-14-VenkatKumar.Ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> References: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E5F:EE_|DM4PR12MB7696:EE_ X-MS-Office365-Filtering-Correlation-Id: d546e2a6-309b-4790-86a4-08dc5aefa6dc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GfPqq+HxX+1ra14itfxMwAiQ/iA0K1lhIZpnZr8wvUmK6isLYVEbONYBR4XF3fsTfgukiswEP7bVvgxwG/weE36HrRO6Gbha2pf98oSFf84cc/h3X1J80sR7KAQnQc9lenhTDJqrRQwM9zhJs+X2B7uurewHcy7ysQRd/13M09gbtTTOpjF7F8OjurV2sRczi2zovayZcF2mWCzWQMWe6pI9QM+34ADhiaxw8KKsj0JNPu7KZ8Fj4+3tqoDJoIVjQ1CPy7NYZk7cnx/aen6nuPlgNut+Iw3gmCJO7LTEDh9S9pYXItTkWep1/fLAR2AOgv6lzmzBWimul61qyavfs1f8K5Op36zKN15WuYjvqf7INX/BYYyK0+xgWHmVRDC+i1zmgdSm2elwsilldM7CMZu9UXC8SBPKFoU/bYLGniyNr+WmTBt0WG7IjipMjz1Bv+6LAqCUod/hiDIVDERLeHqeohCLft9sHDBRxKIJpv78sBthHBuujino0T8ca+Av/bJ/D90sy1KyBNVy+BeIq+gSlWDINzxgBHmaTY3XSC+Ym1B2iwr8yUQqrF8A6gSjshAbdoPxCQ+Vrle1oD4ACF6ZCusrrDDnMa3fJ/iyJYcGC8VNmY7/+K9PnJyRPK3QmT1ma9tpt9NzcHPLJoZs5UyGJRXE0Q4wXNBoWWu/9IH22exs4DwfEUPRksvJ2PUl14QPK/kvHSNJ9nV+wW5H4vevad8bFvSCHDAd8dRZ9Pyi/eJRFe3YSdiP1jfusz7N X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(82310400014)(36860700004)(1800799015)(376005); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 12:54:12.2609 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d546e2a6-309b-4790-86a4-08dc5aefa6dc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E5F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7696 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org SFP+ active and passive cables are copper cables with fixed SFP+ end connectors. Due to a misinterpretation of this, SFP+ active cables could end up not being recognized, causing the driver to fail to establish a connection. Introduce a new enum in SFP+ cable types, XGBE_SFP_CABLE_FIBER, that is the default cable type, and handle active and passive cables when they are specifically detected. Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_phy_impl.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index b5b962151d..693590da53 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -69,6 +69,7 @@ enum axgbe_sfp_cable { AXGBE_SFP_CABLE_UNKNOWN = 0, AXGBE_SFP_CABLE_ACTIVE, AXGBE_SFP_CABLE_PASSIVE, + AXGBE_SFP_CABLE_FIBER, }; enum axgbe_sfp_base { @@ -601,16 +602,18 @@ static void axgbe_phy_sfp_parse_eeprom(struct axgbe_port *pdata) axgbe_phy_sfp_parse_quirks(pdata); - /* Assume ACTIVE cable unless told it is PASSIVE */ + /* Assume FIBER cable unless told otherwise */ if (sfp_base[AXGBE_SFP_BASE_CABLE] & AXGBE_SFP_BASE_CABLE_PASSIVE) { phy_data->sfp_cable = AXGBE_SFP_CABLE_PASSIVE; phy_data->sfp_cable_len = sfp_base[AXGBE_SFP_BASE_CU_CABLE_LEN]; - } else { + } else if (sfp_base[AXGBE_SFP_BASE_CABLE] & AXGBE_SFP_BASE_CABLE_ACTIVE) { phy_data->sfp_cable = AXGBE_SFP_CABLE_ACTIVE; + } else { + phy_data->sfp_cable = AXGBE_SFP_CABLE_FIBER; } /* Determine the type of SFP */ - if (phy_data->sfp_cable == AXGBE_SFP_CABLE_PASSIVE && + if (phy_data->sfp_cable != AXGBE_SFP_CABLE_FIBER && axgbe_phy_sfp_bit_rate(sfp_eeprom, AXGBE_SFP_SPEED_10000)) phy_data->sfp_base = AXGBE_SFP_BASE_10000_CR; else if (sfp_base[AXGBE_SFP_BASE_10GBE_CC] & AXGBE_SFP_BASE_10GBE_CC_SR)