From patchwork Fri Apr 12 12:52:37 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Venkat Kumar Ande X-Patchwork-Id: 139261 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1FEC943E52; Fri, 12 Apr 2024 14:54:48 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E860B427E3; Fri, 12 Apr 2024 14:54:16 +0200 (CEST) Received: from NAM10-BN7-obe.outbound.protection.outlook.com (mail-bn7nam10on2076.outbound.protection.outlook.com [40.107.92.76]) by mails.dpdk.org (Postfix) with ESMTP id C554D427D8 for ; Fri, 12 Apr 2024 14:54:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QQllXD1bVGwzLsgHT4AYoJX7Ex7JyIilXfoZQEh3GvCvdgk/XXjn0KNdtPFCqvd0xPId/P7IJnRQrqwpkUqtn3jgm0vjNNguOtk3hdfrFuxXp7k2EVH4rwMu5JMDvhkg5NRsDbtcjarrLFfTarctZrceO5esABWjzWOpi7Qb25CVkkw2fXeClO0OvoIAcsjxaC7zduruoPzCIW5WTxzai3hv2qfk6dh5J96UOlbyv1aRjDf2d2Ihi4vxl4uz+OdWBcF/7DI6wYkPPKIjVJ3CKyteMLzIMLM7Lco7JThwUPAu3h3VQbP74nq3QqDp4R53RtpyRZKtv09vZzO+Vr/VAg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=tq4DwHOQRSLZDe15jci8KhHbgEOv7xEReSGK0+6khsE=; b=Z2Zr0lnWwppulDHFHOkB+okJUaVYVqG58fAdVNmzsGzfAfE4YZj6hWJtaHVYG+5nNfYqLYoL4iVvRTdIeXEJsq3cPU8Z/bjVQ1rLT0fZ5OTqikbbwDYfIvXor3xUIXbCa5XTpR/7UYdNTnkHfft+djLTXA+NdtM4SIG//MeSP4y4rfJF0rTqreWabkjUMPHKsUtOCJYgLQ03zaGGH/rckmouLUCSL99/MkIGoEn+deMZqIWnExC4kJ71xa9K6YgAfIIdJISXIViymC8vk+ANbMuiGPPoljtqN8YA2KvxzDuQMO8Q8+k1Eg95SFJMxHttxBOe355J+50sHeGFTmhbng== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=tq4DwHOQRSLZDe15jci8KhHbgEOv7xEReSGK0+6khsE=; b=pwKm6+g1gwXp7WlcEmI01nScVMvIzTwu/PGCwxljQ6NGLxvE+tKmIZWZ6JmiO52aFVofsFRTGsia4KWPiZdORT+4EF658QjL8yxi31I10zKVstLRozB81VNciRYmLs1XFmywTgs4dojBi8UC3Kry51DRbyES6yHmOBXrZtjBUyY= Received: from MN2PR22CA0014.namprd22.prod.outlook.com (2603:10b6:208:238::19) by MN0PR12MB5836.namprd12.prod.outlook.com (2603:10b6:208:37b::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.55; Fri, 12 Apr 2024 12:54:10 +0000 Received: from BL6PEPF00020E5F.namprd04.prod.outlook.com (2603:10b6:208:238:cafe::76) by MN2PR22CA0014.outlook.office365.com (2603:10b6:208:238::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7472.26 via Frontend Transport; Fri, 12 Apr 2024 12:54:10 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by BL6PEPF00020E5F.mail.protection.outlook.com (10.167.249.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7452.22 via Frontend Transport; Fri, 12 Apr 2024 12:54:10 +0000 Received: from cae-Lilac-RMB.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.35; Fri, 12 Apr 2024 07:54:00 -0500 From: Venkat Kumar Ande To: CC: , Venkat Kumar Ande Subject: [PATCH 12/24] net/axgbe: enable PLL control for fixed PHY modes only Date: Fri, 12 Apr 2024 08:52:37 -0400 Message-ID: <20240412125249.10625-12-VenkatKumar.Ande@amd.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> References: <20240412125249.10625-1-VenkatKumar.Ande@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL6PEPF00020E5F:EE_|MN0PR12MB5836:EE_ X-MS-Office365-Filtering-Correlation-Id: ef993339-1587-45ec-0ab0-08dc5aefa5bc X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: oMn6RZNHNQ3npifFvjcUwNgF6ZBiWmp04J6Wm85rI7Gpr+oDVM0DKXmhcwoCY3xLZBnoiGjkWyGw6v3UVtaJJ3HB6Ib54vfUoyzktognjW/IP9Mxire17KckGPV5DVvnEv4DXinNh9ooq5oSamF0lrpoZgAZJ7NMX8hK4MvJxqN7e+kt/bQqAMAGlL4wq6p0eW7AtC4Ka8AVhm2nhAAvwLQ5S3Dt+drUplKREApZTPIKDlVDUp6higjc9GAmEj9kDPGLTJSopyyVKGBCsr6A0HUhKKt726iQlJMi9PRgnRb3LHWpXz+TAGs5Z39FY7Hoo5y611A+gIhed9vq5B4XrN7o5Ada9/wGh1LB33UoVucX8ibAtZRHu3YLbrWHAWLLPipJFfx+AgcXkt8aAvzj/6OvO53fF6Y3oonhliDl1kFxkUi39iGe61WY0V7ZFh4zT0VJpzngXo9buj0d38EcGIpsYLmWWK4jk/U6j++8+J79aW5XHBAnlBhf7eVtZKoNR0/FrxGOAG/q0Gx9qw/HVpdCC+6o9uFIa91cvcyD8Gu5l7YWU43D1kl4oPmMCBnWuWpqEpqT9kzC3zjzWavPcqCrwTwm1Ur6Ej6tXXNs9LrO1d3ECwT5o2bPN+67NGeRwyo2bAGUOtY/ifozDaSSF5mvmFOAGJEyTJOh5vb2CMXWKB7sK8EGWfaOMvS5l1Es3RBRmgArEpED0CO4d2ccCadPpb+3fIuAr0uaxvKOsu+r+bs4/WdjCg3EE2gXRmDO X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(1800799015)(376005)(82310400014)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Apr 2024 12:54:10.3546 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: ef993339-1587-45ec-0ab0-08dc5aefa5bc X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: BL6PEPF00020E5F.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN0PR12MB5836 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org PLL control setting(RRC) is needed only in fixed PHY configuration to fix the peer-peer issues. Without the PLL control setting, the link up takes longer time in a fixed phy configuration. Driver implements SW RRC for Autoneg On configuration, hence PLL control setting (RRC) is not needed for AN On configuration, and can be skipped. Also, PLL re-initialization is not needed for PHY Power Off and RRC commands. Otherwise, they lead to mailbox errors. Added the changes accordingly. Signed-off-by: Venkat Kumar Ande --- drivers/net/axgbe/axgbe_phy_impl.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/net/axgbe/axgbe_phy_impl.c b/drivers/net/axgbe/axgbe_phy_impl.c index 8cc99d3a6b..ceff36df3d 100644 --- a/drivers/net/axgbe/axgbe_phy_impl.c +++ b/drivers/net/axgbe/axgbe_phy_impl.c @@ -1207,6 +1207,10 @@ static void axgbe_phy_rx_reset(struct axgbe_port *pdata) static void axgbe_phy_pll_ctrl(struct axgbe_port *pdata, bool enable) { + /* PLL_CTRL feature needs to be enabled for fixed PHY modes (Non-Autoneg) only */ + if (pdata->phy.autoneg != AUTONEG_DISABLE) + return; + XMDIO_WRITE_BITS(pdata, MDIO_MMD_PMAPMD, MDIO_VEND2_PMA_MISC_CTRL0, XGBE_PMA_PLL_CTRL_MASK, enable ? XGBE_PMA_PLL_CTRL_SET @@ -1251,8 +1255,10 @@ static void axgbe_phy_perform_ratechange(struct axgbe_port *pdata, axgbe_phy_rx_reset(pdata); reenable_pll: - /* Re-enable the PLL control */ - axgbe_phy_pll_ctrl(pdata, true); + /* Enable PLL re-initialization, not needed for PHY Power Off and RRC cmds */ + if (cmd != AXGBE_MB_CMD_POWER_OFF && + cmd != AXGBE_MB_CMD_RRC) + axgbe_phy_pll_ctrl(pdata, true); PMD_DRV_LOG(NOTICE, "firmware mailbox command did not complete\n"); }