diff mbox series

pmdinfogen: avoid empty string in ELFSymbol()

Message ID 20240405110929.3279775-1-sebastian.brzezinka@intel.com (mailing list archive)
State Not Applicable
Delegated to: Thomas Monjalon
Headers
Series pmdinfogen: avoid empty string in ELFSymbol() |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-compile-arm64-testing success Testing PASS

Commit Message

Sebastian Brzezinka April 5, 2024, 11:09 a.m. UTC 
  From: Tomasz Zawadzki <tomasz.zawadzki@intel.com>

Starting with Clang 17 the list of pmds could
contain empty string. Please see:
https://bugs.dpdk.org/show_bug.cgi?id=1313

This is a fix proposed by alialnu@nvidia.com in the
issue above.

Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>
---
 buildtools/pmdinfogen.py | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

David Marchand April 5, 2024, 11:31 a.m. UTC | #1 
On Fri, Apr 5, 2024 at 1:09 PM Sebastian Brzezinka
<sebastian.brzezinka@intel.com> wrote:
>
> From: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
>
> Starting with Clang 17 the list of pmds could
> contain empty string. Please see:
> https://bugs.dpdk.org/show_bug.cgi?id=1313
>
> This is a fix proposed by alialnu@nvidia.com in the
> issue above.
>
> Signed-off-by: Tomasz Zawadzki <tomasz.zawadzki@intel.com>
> Signed-off-by: Sebastian Brzezinka <sebastian.brzezinka@intel.com>

Duplicate of https://patchwork.dpdk.org/project/dpdk/patch/20240320155814.617220-1-alialnu@nvidia.com/
diff mbox series

Patch

diff --git a/buildtools/pmdinfogen.py b/buildtools/pmdinfogen.py
index 2a44f17bda..2b29872649 100755
--- a/buildtools/pmdinfogen.py
+++ b/buildtools/pmdinfogen.py
@@ -71,7 +71,9 @@  def find_by_prefix(self, prefix):
         for i in range(self._symtab.num_symbols()):
             symbol = self._symtab.get_symbol(i)
             if symbol.name.startswith(prefix):
-                yield ELFSymbol(self._image, symbol)
+                elf_symbol = ELFSymbol(self._image, symbol)
+                if elf_symbol.string_value:
+                    yield elf_symbol
 
 
 class COFFSymbol: