From patchwork Fri Mar 22 16:14:06 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 138750 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 58FCE43D0E; Fri, 22 Mar 2024 17:14:36 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 48CAC42EAF; Fri, 22 Mar 2024 17:14:36 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 4983C42EA3 for ; Fri, 22 Mar 2024 17:14:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1711124073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RgioOIHIPqSlbTt5PFS5uKK6OD3clqy4NM3NrhIrv3E=; b=DTtN0ksdCcOMhXvGdw2qogfxWVbrlFw48c1enJFrd8mimCVkU3LwYyDK763+FN16tjqwHB jVoFs0bPU7MBopU+9GnuCTpbAKyKAwLKCAu/LXZmpslGxYKUviAmI9aazMrqRFcJLP5Vv9 3x5qLGdSXMsnfPkJOvKcVl0rbANCiRw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-93-Y_zO9n1wOGCk5rZU2KKTVA-1; Fri, 22 Mar 2024 12:14:31 -0400 X-MC-Unique: Y_zO9n1wOGCk5rZU2KKTVA-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 39C93185A781; Fri, 22 Mar 2024 16:14:31 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.28]) by smtp.corp.redhat.com (Postfix) with ESMTP id 82E75200E1BB; Fri, 22 Mar 2024 16:14:30 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: Thomas Monjalon Subject: [PATCH 2/2] devtools: check that maintainers are listed in mailmap Date: Fri, 22 Mar 2024 17:14:06 +0100 Message-ID: <20240322161406.996890-2-david.marchand@redhat.com> In-Reply-To: <20240322161406.996890-1-david.marchand@redhat.com> References: <20240322161406.996890-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org When a maintainer changes its mail address, check that the associated entry in .mailmap knows this address, otherwise there is a chance .mailmap points at an obsolete address. Signed-off-by: David Marchand --- devtools/check-maintainers.sh | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/devtools/check-maintainers.sh b/devtools/check-maintainers.sh index 71697bb352..8a786e14a9 100755 --- a/devtools/check-maintainers.sh +++ b/devtools/check-maintainers.sh @@ -85,6 +85,18 @@ check_fx () # done } +# Check that every maintainer mail is known of .mailmap: +check_mailmap () # +{ + sed -n -e 's/^M: \(.*<.*\)$/\1/p' $1 | sort -u | while read line; do + name=${line%% <*} + mail='<'${line##* <} + if ! grep -q "^$name <" $2 || ! grep -iq "^$name.*$mail" $2; then + echo $name mail address $mail is not in $2 + fi + done +} + # Add a line to a set of lines if it begins with right pattern add_line_to_if () # { @@ -129,4 +141,10 @@ echo '# wrong patterns' echo '##########' check_fx MAINTAINERS +echo +echo '##########' +echo '# wrong mailmap' +echo '##########' +check_mailmap MAINTAINERS .mailmap + # TODO: check overlaps