[2/2] net/ice: Tx path check mbuf sub-segment

Message ID 20240315102409.1079521-3-mingjinx.ye@intel.com (mailing list archive)
State Accepted, archived
Delegated to: Bruce Richardson
Headers
Series Tx path check mbuf sub-segment |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/github-robot: build success github build: passed
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Mingjin Ye March 15, 2024, 10:24 a.m. UTC
  Add check mbuf sub-segment to Tx diagnostic path.

Fixes: 2a0244d611b4 ("net/ice: support mbuf checks in Tx path")
Cc: stable@dpdk.org

Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
---
 drivers/net/ice/ice_rxtx.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Li, HongboX March 21, 2024, 2:10 a.m. UTC | #1
> -----Original Message-----
> From: Mingjin Ye <mingjinx.ye@intel.com>
> Sent: Friday, March 15, 2024 6:24 PM
> To: dev@dpdk.org
> Cc: Ye, MingjinX <mingjinx.ye@intel.com>; stable@dpdk.org
> Subject: [PATCH 2/2] net/ice: Tx path check mbuf sub-segment
> 
> Add check mbuf sub-segment to Tx diagnostic path.
> 
> Fixes: 2a0244d611b4 ("net/ice: support mbuf checks in Tx path")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Mingjin Ye <mingjinx.ye@intel.com>
> ---
>  drivers/net/ice/ice_rxtx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c index
> 13aabe97a5..31a3a35c1d 100644
> --- a/drivers/net/ice/ice_rxtx.c
> +++ b/drivers/net/ice/ice_rxtx.c
> @@ -3713,7 +3713,7 @@ ice_xmit_pkts_check(void *tx_queue, struct
> rte_mbuf **tx_pkts, uint16_t nb_pkts)
>  		ol_flags = mb->ol_flags;
> 
>  		if ((adapter->devargs.mbuf_check &
> ICE_MBUF_CHECK_F_TX_MBUF) &&
> -		    (rte_mbuf_check(mb, 0, &reason) != 0)) {
> +		    (rte_mbuf_check(mb, 1, &reason) != 0)) {
>  			PMD_TX_LOG(ERR, "INVALID mbuf: %s\n", reason);
>  			pkt_error = true;
>  			break;
> --
> 2.25.1

Tested-by: Li, HongboX <hongbox.li@intel.com>
  

Patch

diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c
index 13aabe97a5..31a3a35c1d 100644
--- a/drivers/net/ice/ice_rxtx.c
+++ b/drivers/net/ice/ice_rxtx.c
@@ -3713,7 +3713,7 @@  ice_xmit_pkts_check(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
 		ol_flags = mb->ol_flags;
 
 		if ((adapter->devargs.mbuf_check & ICE_MBUF_CHECK_F_TX_MBUF) &&
-		    (rte_mbuf_check(mb, 0, &reason) != 0)) {
+		    (rte_mbuf_check(mb, 1, &reason) != 0)) {
 			PMD_TX_LOG(ERR, "INVALID mbuf: %s\n", reason);
 			pkt_error = true;
 			break;