From patchwork Thu Mar 14 07:40:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chaoyong He X-Patchwork-Id: 138348 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4168D43CAE; Thu, 14 Mar 2024 08:41:13 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B7D6442E65; Thu, 14 Mar 2024 08:40:52 +0100 (CET) Received: from NAM11-BN8-obe.outbound.protection.outlook.com (mail-bn8nam11on2100.outbound.protection.outlook.com [40.107.236.100]) by mails.dpdk.org (Postfix) with ESMTP id 3C4B042E48; Thu, 14 Mar 2024 08:40:50 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ZRERu2NsMrZA6KoGP7pI9KoG/mXosMJV7imYXQpWVrF574ljrtY+soNoOaz4R3vN12l7I1U9X/cLZcFizGg+CE4OxtpJKljAhzTwhzl3HyqfVVE9eH/Oc16zOtwgXfNXBnEFTsifyyVPYzGChJN/0B4z+5oc95l590C0SISiYFQ/50fSqBjXZa6tdPlPi/WO7rpwy4RtZkI147YuDwuqE6GlW8s9ZCxTudXzeFZJpKfTv3dGTeuIwhBppU1OnB5aPd+S0iehw5KOYYwjuSQM6cv1fnZtPlwspYOdme2O1sUQl+peXji7b8/IPtSvQn17jmlNWc5+wPsekRJcWfBEIw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lYyea+SHyUtstUQBTNwuiaui4P6HKzoY2nH6zaWhB4k=; b=YEXW5MQUYKTKG4eaOm8yVSgm7WtV69iRwUSY0yHJM+qpsnCTFb7LqW+XxDo+sRzzlislk9SVD1AR6PgNCHfd7J34+/NvEDWZXJbdVqwgRKXnQo8rZ3HcKEmqEnFGr7y/LwACA+Ajham5RGGUc6cJjrNeYp6KebhZjaBXAUIOakgKFjhOPau84FhLw56N3DbKDSxcD0vemD1tEl6NmFGiggxLlM8z+o0QCLgnYIFwMnVAI6WLTpFSDywmpzniuVGH/i2BrtvQaQREE+Z3NkHamhr+PsDRr7Naiosjy7N7VSSIFVtMxX0xUrHeSxGWsxExC4Bplljp5kBfNZOTDBmF6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com; dkim=pass header.d=corigine.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lYyea+SHyUtstUQBTNwuiaui4P6HKzoY2nH6zaWhB4k=; b=W9YhWULxHfY9KyqGlVgb2c/FobyltHNoYZXKP7lxXW9Tic6N9eLxeb9uAQESBbxwgKNcpvNDDVvoC+W4EBl+h0XfbpPF/8f0jC7tgPFgz4yRhJ9shPrS2yYcidlEBEgDIKHDh+DuMnn+U/rkcq3vCGcnZqSm2GFZhs8napPr6DI= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=corigine.com; Received: from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) by BY5PR13MB3617.namprd13.prod.outlook.com (2603:10b6:a03:21b::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7386.19; Thu, 14 Mar 2024 07:40:49 +0000 Received: from SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e]) by SJ0PR13MB5545.namprd13.prod.outlook.com ([fe80::ec12:7411:559a:850e%5]) with mapi id 15.20.7362.035; Thu, 14 Mar 2024 07:40:49 +0000 From: Chaoyong He To: dev@dpdk.org Cc: oss-drivers@corigine.com, Chaoyong He , stable@dpdk.org, Long Wu , Peng Zhang Subject: [PATCH v2 3/8] net/nfp: fix unreachable control flow Date: Thu, 14 Mar 2024 15:40:19 +0800 Message-Id: <20240314074024.3199555-4-chaoyong.he@corigine.com> X-Mailer: git-send-email 2.39.1 In-Reply-To: <20240314074024.3199555-1-chaoyong.he@corigine.com> References: <20240314070536.3169210-1-chaoyong.he@corigine.com> <20240314074024.3199555-1-chaoyong.he@corigine.com> X-ClientProxiedBy: BYAPR11CA0107.namprd11.prod.outlook.com (2603:10b6:a03:f4::48) To SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR13MB5545:EE_|BY5PR13MB3617:EE_ X-MS-Office365-Filtering-Correlation-Id: 9b0de7db-c7c3-40e1-f923-08dc43fa1122 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: dqnh7OElMrM3s97OLFnTW/jYeEVZGDr7mxz137nt6jM+jupjTZpP8IpbW/UYRFv0UHDGeFZ2XWPskXW0TBrk9TYk5DiHdSSlsymj/JbdDJ7BNqIotAMrMrSZ9UqprEXSlVR3ZsEPl0fhS04FXfZwwWSP8wZOGr3sv1IJtx2ONhmrnAfW6M+Kl3OI/5FqmccZg5Llj4RE/3iAF17wT1gLSt/TP27sdwuC1QXq8ezZfqwLc2sTaCxOL/Gwz9+Nt8ms7+2qq/ZpFMKki6evECIlfAe0gp1oWDpEVkbyPovRnjbxeIphu8lx/aw/02oZcCJb+63Hyhxo5bnbcpRLycbw/1Ao0qaQHE65n6h4WjqR+bh21LBi/D9MYTvS14Zwfb4PEJ++f/LZIAhrcWG6tSSz01vY/3j4UZS7aGqXtmrbkwrrguRLxXDlqVfOrdEespFt/fHq3g3QKy7725LlgfqvOASCVwyoQqA3jb11eNTQmrU78/tAI136X7Az7cGf3viAo0GkPclMphBkClgU8WYjL3lSSG/w0YXEgzgveKYNmomW5v2yS17titaCmC6C8QN9nxcc3SbSo7Jzje+rNIBZptCb5dcQPlgnB4purAwPbHyUvwogNGyUduYsdLjdQ3F40AKxP7VcpVipx62JmEjf8QMq7zLCH5xtIQb1Vgj2t/O3SzoVtr+Zo5mGTKO6oTMBHh7B7SEbGUohct2nsrlwXQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(1800799015)(52116005)(376005)(38350700005); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: JOl2ealmIUDPrbzZFVNU9vDbtiTDNxIjsAbZThh0mCot65Tj/c1KwR8QPm1091IQcjDQ0ymDQ98JRfAonVehVgXgxdZg/YtUBmyKOCIbSin/tP4KYD+zGlIUSJAHGXmmVzrm6+w8iZsA/S4dQn3K5vtN5ZqyoXkLJC65PwQoCH7qKsk8DQVdD6JHJB4Cciv8D+oU3mCojOXWPxWYnqRtRDmbhqIDpwtz7/+Ezvc/LpJ2y8ou9hR4EeZYLi9s4HPGpWL8ZbmQYQ+I0ucrN7iD3ULwKnh8ZyogT4Ccwnpuhu1OEzJwNbx0HZtVeKm3YZTT07a7+g3SlCZCQj5G7GMOixX2QIZz4i0BcGyGZ2RUeZLdB9fpEAPX0iZPLNvxBZsUrb4nAozhyP82LW/DdsJhwHRlH8zRWY41X+Jfq1oNI6JAcgK1JfuSMfzdeqa0VIQREsonVVBzU2S5jh2muz5Sdeaxwh9xU2U/aAQ0/eW4D72QYNloVs6YhGUHjZYI1KjQPduJGAavV8Z0THUYP5dmv3PkDz42XhlmlLbKTdGWDvwz2ZsyHywYnQZxytWdto4cgu0u4eN72x0ADFn0BxzxNcQ1ovWdIJHsaQv5fxlT2sTNALibk+n0o+SJwgMgM0LxWH+7HslOoHgBXwyZl8yMxT0s440m5vCNfbcgO1CSdDF1CyLtQW4C6ughWeVcPmduNX9gXCS8OWkGjB0tFe/4DaPly1zPCsR/Y9hyVV7Zllpdiubl07yW1oLUgAJzOwdGewhN7INPSWHB+xJXtjpRYZJNFtqA/jummlYJutQSh/CAJ2eRAyWFg/4wVpxmQF/qq/vjdeR1XBQQ/p1onMat5o6aUfwPez0fB6lHrqhNHzqTBdTlxYtxFgKqBamxG0LO76ZH4ijknKfCWxBXa7APHTMy9mW88mv3D1+gJwC9O3TtqnTaTeAj7ryzows9C+zvvWruUCct+l6VxRF4nCLcg/bydriwNYvMucggTk9KkL/o4e5TcSGoIaAfZDVsP5LNJ7mO5YdHK8k6yWYXpphTpl+r57KpAImRi4twjoLZteOQ8TUfWKCsjpRgT0uRy0Yq4oeIPZ/NYEKzfdAE8pce3tdnGcIprsqX8q2gYrACrNhvblS6GxWtw70HEHpsK5Bguiq0csYcZcn+38WjqMMZQTQnnTxep0CF7SvfK56AgfVadxsYDJv5TxeN1YKaEFkV5Db73lUrI3rteJcEEBv4wpAWqcFidxNT2b74IzOy2ni5EPcwLgp+BQlyjrKBWhwO18ICplRWK6IVTATJdqiMoOGRRIsEwO6uQ3xjnwS0UJLEITMGOkbQI/bljKyxHJIL7b3q0jTy9jC75jOA5nv1NWXvn/Gs60Fv2RYW09YQdMLzK9CR0+8RBcx9B2ziNeKyannv4l/Pg2ZZLyMqIYggtzz+shTkLiWcf0L4r9xmPAztaaMVGerJNF7I1vt35wnT3Szhuu/6jvHkryk6fwu1EB49Wbz5DNWuDn2+Z1FeLK45RzIEeMlnX3Q2t9IGL7j6wdMFVjjADMKa7rj6Mk6ZIcvBzwjCuCnZslXy67834VhGZnUZzKXFD437EpUlT+xhFwiP6rcs9gHUI9EHeTDGUw== X-OriginatorOrg: corigine.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9b0de7db-c7c3-40e1-f923-08dc43fa1122 X-MS-Exchange-CrossTenant-AuthSource: SJ0PR13MB5545.namprd13.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Mar 2024 07:40:49.0960 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: fe128f2c-073b-4c20-818e-7246a585940c X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 7KKxoZ0YlbqTk0PZsBX+beTi/RZLOFIi8d2gn8oJ7ykpX5HoP2VtUGnsE0PD7N3yAM7kBX3j18C9C651wKjhSEYa7PNcUKUV1uaAmUoFets= X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR13MB3617 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org CI found there has unreachable control flow, fix it by remove the missing delete 'return' statement. Coverity issue: 414938 Fixes: 369945667251 ("net/nfp: fix resource leak for device initialization") Cc: stable@dpdk.org Signed-off-by: Chaoyong He Reviewed-by: Long Wu Reviewed-by: Peng Zhang --- drivers/net/nfp/nfp_ethdev.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c index 31c54a595c..568de1d024 100644 --- a/drivers/net/nfp/nfp_ethdev.c +++ b/drivers/net/nfp/nfp_ethdev.c @@ -936,7 +936,6 @@ nfp_net_init(struct rte_eth_dev *eth_dev) err = nfp_net_tlv_caps_parse(eth_dev); if (err != 0) { PMD_INIT_LOG(ERR, "Failed to parser TLV caps"); - return err; goto free_area; }