diff mbox series

[4/8] net/nfp: fix check return value

Message ID 20240314070536.3169210-5-chaoyong.he@corigine.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series fix some coverity issues |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Chaoyong He March 14, 2024, 7:05 a.m. UTC 
  CI found in 'nfp_service_disable()', not check the return value of API
'rte_service_map_lcore_set()'.

Coverity issue: 414939
Fixes: 600f6d2c7704 ("net/nfp: add service module")
Cc: long.wu@corigine.com
Cc: stable@dpdk.org

Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
Reviewed-by: Long Wu <long.wu@corigine.com>
Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
---
 drivers/net/nfp/nfp_service.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)
diff mbox series

Patch

diff --git a/drivers/net/nfp/nfp_service.c b/drivers/net/nfp/nfp_service.c
index f49fa6addf..24d60857ac 100644
--- a/drivers/net/nfp/nfp_service.c
+++ b/drivers/net/nfp/nfp_service.c
@@ -90,6 +90,7 @@  nfp_service_enable(const struct rte_service_spec *service_spec,
 int
 nfp_service_disable(struct nfp_service_info *info)
 {
+	int ret;
 	uint32_t i;
 	const char *service_name;
 
@@ -107,10 +108,16 @@  nfp_service_disable(struct nfp_service_info *info)
 			break;
 		rte_delay_ms(1);
 	}
+
 	if (i == NFP_SERVICE_DISABLE_WAIT_COUNT)
 		PMD_DRV_LOG(ERR, "Could not stop service %s", service_name);
 
-	rte_service_map_lcore_set(info->id, info->lcore, 0);
+	ret = rte_service_map_lcore_set(info->id, info->lcore, 0);
+	if (ret != 0) {
+		PMD_DRV_LOG(DEBUG, "Could not unmap flower service");
+		return -ENOENT;
+	}
+
 	rte_service_component_unregister(info->id);
 
 	return 0;