config/arm: add fallback march for Neoverse V2

Message ID 20240307080627.177-1-anoobj@marvell.com (mailing list archive)
State Accepted, archived
Delegated to: Thomas Monjalon
Headers
Series config/arm: add fallback march for Neoverse V2 |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS

Commit Message

Anoob Joseph March 7, 2024, 8:06 a.m. UTC
  Add march & fallback march for Neoverse V2 to support build with older
compilers that doesn't support mcpu = 'neoverse-v2'.

Signed-off-by: Anoob Joseph <anoobj@marvell.com>
---

Depends-on: series-31402 ("config/arm: avoid mcpu and march conflicts")

 config/arm/meson.build | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)
  

Comments

Jerin Jacob March 14, 2024, 12:05 p.m. UTC | #1
On Thu, Mar 7, 2024 at 1:36 PM Anoob Joseph <anoobj@marvell.com> wrote:
>
> Add march & fallback march for Neoverse V2 to support build with older
> compilers that doesn't support mcpu = 'neoverse-v2'.
>
> Signed-off-by: Anoob Joseph <anoobj@marvell.com>

Acked-by: Jerin Jacob <jerinj@marvell.com>


> ---
>
> Depends-on: series-31402 ("config/arm: avoid mcpu and march conflicts")
>
>  config/arm/meson.build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 3f5fb0f242..2e655ece05 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -106,8 +106,10 @@ part_number_config_arm = {
>          ]
>      },
>      '0xd4f': {
> +        'march': 'armv9-a',
>          'march_features': ['sve2'],
> -        'compiler_options': ['-mcpu=neoverse-v2'],
> +        'mcpu': 'neoverse-v2',
> +        'fallback_march': 'armv8.5-a',
>          'flags': [
>              ['RTE_MACHINE', '"neoverse-v2"'],
>              ['RTE_ARM_FEATURE_ATOMICS', true],
> --
> 2.25.1
>
  
Thomas Monjalon March 15, 2024, 11:22 a.m. UTC | #2
14/03/2024 13:05, Jerin Jacob:
> On Thu, Mar 7, 2024 at 1:36 PM Anoob Joseph <anoobj@marvell.com> wrote:
> >
> > Add march & fallback march for Neoverse V2 to support build with older
> > compilers that doesn't support mcpu = 'neoverse-v2'.
> >
> > Signed-off-by: Anoob Joseph <anoobj@marvell.com>
> 
> Acked-by: Jerin Jacob <jerinj@marvell.com>

Applied, thanks.

> > Depends-on: series-31402 ("config/arm: avoid mcpu and march conflicts")
[...]
> > +        'march': 'armv9-a',
> >          'march_features': ['sve2'],
> > -        'compiler_options': ['-mcpu=neoverse-v2'],
> > +        'mcpu': 'neoverse-v2',
> > +        'fallback_march': 'armv8.5-a',

After latest Pavan's patches, only fallback is added by this patch.
  

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 3f5fb0f242..2e655ece05 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -106,8 +106,10 @@  part_number_config_arm = {
         ]
     },
     '0xd4f': {
+        'march': 'armv9-a',
         'march_features': ['sve2'],
-        'compiler_options': ['-mcpu=neoverse-v2'],
+        'mcpu': 'neoverse-v2',
+        'fallback_march': 'armv8.5-a',
         'flags': [
             ['RTE_MACHINE', '"neoverse-v2"'],
             ['RTE_ARM_FEATURE_ATOMICS', true],