From patchwork Thu Feb 29 22:58:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Stephen Hemminger X-Patchwork-Id: 137635 X-Patchwork-Delegate: thomas@monjalon.net Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3BADC43BAE; Fri, 1 Mar 2024 00:07:49 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 71C614343B; Fri, 1 Mar 2024 00:02:03 +0100 (CET) Received: from mail-pj1-f46.google.com (mail-pj1-f46.google.com [209.85.216.46]) by mails.dpdk.org (Postfix) with ESMTP id 1381C432DE for ; Fri, 1 Mar 2024 00:00:53 +0100 (CET) Received: by mail-pj1-f46.google.com with SMTP id 98e67ed59e1d1-29b10d73630so866864a91.0 for ; Thu, 29 Feb 2024 15:00:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1709247652; x=1709852452; darn=dpdk.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4KvcmbAp4rw+Hg/wEBF72T3gPI9/7RJ07Bv1mlS/fhs=; b=PGICq3QwRIMYHIy9PswUuE3ERvhLPDyu2imV6oZELHBzJxPnaX5W3qCW0IQKoiFIrW 5P1LPs/AbxGQESXK9qjcVutT+y4Wko0JyTaa/Umud2xwNaNdMWBQA1Avs6e7b+Dx2rhe cya7fvpu59YRzvejzyz2d9MTgN4xU1srWYUdrRZ8TNT1XMQf7DTkO1LeVpsqfyYG0QjE dqJ0s8balO/Bt48YR7GxaF4HTlMB5BOTfbpE/yS4/ziSbEAgBSHng/zN6imcMiBA0Xo5 X7fe3a0rjUv7klwHl8nKskyrHlsR84j50WAJrEm4Cvucdtg87ROBr4ZUQfQfFqETY72T Xykg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709247652; x=1709852452; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=4KvcmbAp4rw+Hg/wEBF72T3gPI9/7RJ07Bv1mlS/fhs=; b=HKJbtFVT/DTlBcEha5015ZKkEuUBfN4P0tEDvTwbjeufcHZE6DCwCjW1oCZzE/CBz5 QskEKPY41YU0ZU4+/An06y0TfbnI+VE5kEAjgpLxv/3xtM18Ifl9z74k1MPBTrtpFVx6 ieP00M9JfPBd+YkotWH6NLTKy1Ph42DdyKmCetcOdyFbf/qhFbRbkU+uSGppcN9hHBD+ 16JnqpTi1kDZZacYeRV8QgBadr78laTUShiO6GnbFCG0G0WSEIL4NT870FhMfaeR3MEk yXxu6NEPih/F2N/KNaUCrAu2kEidfZKLraCg87he7Z2oFkLPf8GjSVqdZ2C87y1uYN2q 4wTg== X-Gm-Message-State: AOJu0YxhfpMcX4evvzztfycDkXFr+SLeljzrSdSs0l8gFj5hVI1bP9s/ nADUC+HiejXgagUfeWlDwiUR2+lbl/WzwpMqibHJ3rAd94XfqgBdltZUgxoEMPv0W8RChDLEimp h X-Google-Smtp-Source: AGHT+IHAVUS7D6XrQ0doo363XkJDeioImSeezY687ySQb/PAxMdCK0pN7eZuHLn6LbBAZMBtO3ST7Q== X-Received: by 2002:a17:90b:1e51:b0:29b:6a1:4036 with SMTP id pi17-20020a17090b1e5100b0029b06a14036mr70979pjb.0.1709247652431; Thu, 29 Feb 2024 15:00:52 -0800 (PST) Received: from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141]) by smtp.gmail.com with ESMTPSA id l22-20020a17090b079600b0029a8e5355fcsm1965578pjz.53.2024.02.29.15.00.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 15:00:52 -0800 (PST) From: Stephen Hemminger To: dev@dpdk.org Cc: Stephen Hemminger Subject: [PATCH 61/71] net/e1000: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:48 -0800 Message-ID: <20240229225936.483472-62-stephen@networkplumber.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Automatically generated by devtools/cocci/rte_memcpy.cocci Signed-off-by: Stephen Hemminger --- drivers/net/e1000/igb_flow.c | 22 ++++++++++------------ drivers/net/e1000/igb_pf.c | 6 +++--- 2 files changed, 13 insertions(+), 15 deletions(-) diff --git a/drivers/net/e1000/igb_flow.c b/drivers/net/e1000/igb_flow.c index ea9b290e1cb5..8bca48496035 100644 --- a/drivers/net/e1000/igb_flow.c +++ b/drivers/net/e1000/igb_flow.c @@ -1484,9 +1484,9 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&ntuple_filter_ptr->filter_info, - &ntuple_filter, - sizeof(struct rte_eth_ntuple_filter)); + memcpy(&ntuple_filter_ptr->filter_info, + &ntuple_filter, + sizeof(struct rte_eth_ntuple_filter)); TAILQ_INSERT_TAIL(&igb_filter_ntuple_list, ntuple_filter_ptr, entries); flow->rule = ntuple_filter_ptr; @@ -1511,9 +1511,9 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(ðertype_filter_ptr->filter_info, - ðertype_filter, - sizeof(struct rte_eth_ethertype_filter)); + memcpy(ðertype_filter_ptr->filter_info, + ðertype_filter, + sizeof(struct rte_eth_ethertype_filter)); TAILQ_INSERT_TAIL(&igb_filter_ethertype_list, ethertype_filter_ptr, entries); flow->rule = ethertype_filter_ptr; @@ -1536,9 +1536,8 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&syn_filter_ptr->filter_info, - &syn_filter, - sizeof(struct rte_eth_syn_filter)); + memcpy(&syn_filter_ptr->filter_info, &syn_filter, + sizeof(struct rte_eth_syn_filter)); TAILQ_INSERT_TAIL(&igb_filter_syn_list, syn_filter_ptr, entries); @@ -1562,9 +1561,8 @@ igb_flow_create(struct rte_eth_dev *dev, goto out; } - rte_memcpy(&flex_filter_ptr->filter_info, - &flex_filter, - sizeof(struct igb_flex_filter)); + memcpy(&flex_filter_ptr->filter_info, &flex_filter, + sizeof(struct igb_flex_filter)); TAILQ_INSERT_TAIL(&igb_filter_flex_list, flex_filter_ptr, entries); flow->rule = flex_filter_ptr; diff --git a/drivers/net/e1000/igb_pf.c b/drivers/net/e1000/igb_pf.c index c7588ea57eaa..7e2ea3bdbcc1 100644 --- a/drivers/net/e1000/igb_pf.c +++ b/drivers/net/e1000/igb_pf.c @@ -290,7 +290,7 @@ igb_vf_reset(struct rte_eth_dev *dev, uint16_t vf, uint32_t *msgbuf) /* reply to reset with ack and vf mac address */ msgbuf[0] = E1000_VF_RESET | E1000_VT_MSGTYPE_ACK; - rte_memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); + memcpy(new_mac, vf_mac, RTE_ETHER_ADDR_LEN); e1000_write_mbx(hw, msgbuf, 3, vf); return 0; @@ -308,8 +308,8 @@ igb_vf_set_mac_addr(struct rte_eth_dev *dev, uint32_t vf, uint32_t *msgbuf) if (rte_is_unicast_ether_addr((struct rte_ether_addr *)new_mac)) { if (!rte_is_zero_ether_addr((struct rte_ether_addr *)new_mac)) - rte_memcpy(vfinfo[vf].vf_mac_addresses, new_mac, - sizeof(vfinfo[vf].vf_mac_addresses)); + memcpy(vfinfo[vf].vf_mac_addresses, new_mac, + sizeof(vfinfo[vf].vf_mac_addresses)); hw->mac.ops.rar_set(hw, new_mac, rar_entry); rah = E1000_READ_REG(hw, E1000_RAH(rar_entry)); rah |= (0x1 << (E1000_RAH_POOLSEL_SHIFT + vf));