diff mbox series

[55/71] net/bnxt: replace use of fixed size rte_memcpy

Message ID	20240229225936.483472-56-stephen@networkplumber.org (mailing list archive)
State	Superseded, archived
Delegated to:	Thomas Monjalon
Headers	From: Stephen Hemminger <stephen@networkplumber.org> To: dev@dpdk.org Cc: Stephen Hemminger <stephen@networkplumber.org>, Ajit Khaparde <ajit.khaparde@broadcom.com>, Somnath Kotur <somnath.kotur@broadcom.com> Subject: [PATCH 55/71] net/bnxt: replace use of fixed size rte_memcpy Date: Thu, 29 Feb 2024 14:58:42 -0800 Message-ID: <20240229225936.483472-56-stephen@networkplumber.org> In-Reply-To: <20240229225936.483472-1-stephen@networkplumber.org> References: <20240229225936.483472-1-stephen@networkplumber.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: list Errors-To: dev-bounces@dpdk.org
Series	replace use of fixed size rte_memcpy \| [00/71] replace use of fixed size rte_memcpy [01/71] cocci/rte_memcpy: add script to eliminate fixed size rte_memcpy [02/71] eal: replace use of fixed size rte_memcpy [03/71] ethdev: replace use of fixed size rte_memcpy [04/71] eventdev: replace use of fixed size rte_memcpy [05/71] cryptodev: replace use of fixed size rte_memcpy [06/71] ip_frag: replace use of fixed size rte_memcpy [07/71] net: replace use of fixed size rte_memcpy [08/71] lpm: replace use of fixed size rte_memcpy [09/71] node: replace use of fixed size rte_memcpy [10/71] pdcp: replace use of fixed size rte_memcpy [11/71] pipeline: replace use of fixed size rte_memcpy [12/71] rib: replace use of fixed size rte_memcpy [13/71] security: replace use of fixed size rte_memcpy [14/71] net/mlx5: replace use of fixed size rte_memcpy [15/71] net/nfp: replace use of fixed size rte_memcpy [16/71] net/ngbe: replace use of fixed size rte_memcpy [17/71] net/null: replace use of fixed size rte_memcpy [18/71] net/pcap: replace use of fixed size rte_memcpy [19/71] net/sfc: replace use of fixed size rte_memcpy [20/71] net/tap: replace use of fixed size rte_memcpy [21/71] net/txgbe: replace use of fixed size rte_memcpy [22/71] raw/ifpga: replace use of fixed size rte_memcpy [23/71] raw/skeleton: replace use of fixed size rte_memcpy [24/71] net/hns3: replace use of fixed size rte_memcpy [25/71] net/i40e: replace use of fixed size rte_memcpy [26/71] net/iavf: replace use of fixed size rte_memcpy [27/71] net/ice: replace use of fixed size rte_memcpy [28/71] net/idpf: replace use of fixed size rte_memcpy [29/71] net/ipn3ke: replace use of fixed size rte_memcpy [30/71] net/ixgbe: replace use of fixed size rte_memcpy [31/71] net/memif: replace use of fixed size rte_memcpy [32/71] net/qede: replace use of fixed size rte_memcpy [33/71] baseband/acc: replace use of fixed size rte_memcpy [34/71] baseband/la12xx: replace use of fixed size rte_memcpy [35/71] common/idpf: replace use of fixed size rte_memcpy [36/71] common/qat: replace use of fixed size rte_memcpy [37/71] compress/qat: replace use of fixed size rte_memcpy [38/71] crypto/ccp: replace use of fixed size rte_memcpy [39/71] crypto/cnxk: replace use of fixed size rte_memcpy [40/71] crypto/dpaa_sec: replace use of fixed size rte_memcpy [41/71] crypto/ipsec_mb: replace use of fixed size rte_memcpy [42/71] crypto/qat: replace use of fixed size rte_memcpy [43/71] crypto/scheduler: replace use of fixed size rte_memcpy [44/71] event/cnxk: replace use of fixed size rte_memcpy [45/71] event/dlb2: replace use of fixed size rte_memcpy [46/71] event/dpaa2: replace use of fixed size rte_memcpy [47/71] event/octeontx: replace use of fixed size rte_memcpy [48/71] mempool/dpaa: replace use of fixed size rte_memcpy [49/71] mempool/dpaa2: replace use of fixed size rte_memcpy [50/71] ml/cnxk: replace use of fixed size rte_memcpy [51/71] net/af_xdp: replace use of fixed size rte_memcpy [52/71] net/avp: replace use of fixed size rte_memcpy [53/71] net/axgbe: replace use of fixed size rte_memcpy [54/71] net/bnx2x: replace use of fixed size rte_memcpy [55/71] net/bnxt: replace use of fixed size rte_memcpy [56/71] net/bonding: replace use of fixed size rte_memcpy [57/71] net/cnxk: replace use of fixed size rte_memcpy [58/71] net/cpfl: replace use of fixed size rte_memcpy [59/71] net/cxgbe: replace use of fixed size rte_memcpy [60/71] net/dpaa2: replace use of fixed size rte_memcpy [61/71] net/e1000: replace use of fixed size rte_memcpy [62/71] net/enic: replace use of fixed size rte_memcpy [63/71] net/failsafe: replace use of fixed size rte_memcpy [64/71] net/gve/base: replace use of fixed size rte_memcpy [65/71] net/hinic: replace use of fixed size rte_memcpy [66/71] net/mvpp2: replace use of fixed size rte_memcpy [67/71] app/test-pmd: replace use of fixed size rte_memcpy [68/71] app/graph: replace use of fixed size rte_memcpy [69/71] app/test-eventdev: replace use of fixed size rte_memcpy [70/71] app/test: replace use of fixed size rte_memcpy [71/71] examples: replace use of fixed size rte_memcpy

Checks

Context	Check	Description
ci/checkpatch	success	coding style OK

Commit Message

Stephen Hemminger Feb. 29, 2024, 10:58 p.m. UTC

  Automatically generated by devtools/cocci/rte_memcpy.cocci

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/bnxt/bnxt_flow.c | 34 ++++++++++++++++++----------------
 1 file changed, 18 insertions(+), 16 deletions(-)

Comments

Somnath Kotur March 1, 2024, 2:54 a.m. UTC | #1

On Fri, Mar 1, 2024 at 4:30 AM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Automatically generated by devtools/cocci/rte_memcpy.cocci
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
>  drivers/net/bnxt/bnxt_flow.c | 34 ++++++++++++++++++----------------
>  1 file changed, 18 insertions(+), 16 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
> index f25bc6ff78c7..6466aa394af1 100644
> --- a/drivers/net/bnxt/bnxt_flow.c
> +++ b/drivers/net/bnxt/bnxt_flow.c
> @@ -233,8 +233,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
>                                                     "DMAC is invalid!\n");
>                                         return -rte_errno;
>                                 }
> -                               rte_memcpy(filter->dst_macaddr,
> -                                          &eth_spec->hdr.dst_addr, RTE_ETHER_ADDR_LEN);
> +                               memcpy(filter->dst_macaddr,
> +                                      &eth_spec->hdr.dst_addr,
> +                                      RTE_ETHER_ADDR_LEN);
>                                 en |= use_ntuple ?
>                                         NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR :
>                                         EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR;
> @@ -257,8 +258,9 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
>                                                     "SMAC is invalid!\n");
>                                         return -rte_errno;
>                                 }
> -                               rte_memcpy(filter->src_macaddr,
> -                                          &eth_spec->hdr.src_addr, RTE_ETHER_ADDR_LEN);
> +                               memcpy(filter->src_macaddr,
> +                                      &eth_spec->hdr.src_addr,
> +                                      RTE_ETHER_ADDR_LEN);
>                                 en |= use_ntuple ?
>                                         NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR :
>                                         EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR;
> @@ -423,23 +425,23 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
>                                 en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
>                                         EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
>
> -                       rte_memcpy(filter->src_ipaddr,
> -                                  ipv6_spec->hdr.src_addr, 16);
> -                       rte_memcpy(filter->dst_ipaddr,
> -                                  ipv6_spec->hdr.dst_addr, 16);
> +                       memcpy(filter->src_ipaddr, ipv6_spec->hdr.src_addr,
> +                              16);
> +                       memcpy(filter->dst_ipaddr, ipv6_spec->hdr.dst_addr,
> +                              16);
>
>                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr,
>                                                    16)) {
> -                               rte_memcpy(filter->src_ipaddr_mask,
> -                                          ipv6_mask->hdr.src_addr, 16);
> +                               memcpy(filter->src_ipaddr_mask,
> +                                      ipv6_mask->hdr.src_addr, 16);
>                                 en |= !use_ntuple ? 0 :
>                                     NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
>                         }
>
>                         if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr,
>                                                    16)) {
> -                               rte_memcpy(filter->dst_ipaddr_mask,
> -                                          ipv6_mask->hdr.dst_addr, 16);
> +                               memcpy(filter->dst_ipaddr_mask,
> +                                      ipv6_mask->hdr.dst_addr, 16);
>                                 en |= !use_ntuple ? 0 :
>                                      NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
>                         }
> @@ -591,8 +593,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
>                                         return -rte_errno;
>                                 }
>
> -                               rte_memcpy(((uint8_t *)&tenant_id_be + 1),
> -                                          vxlan_spec->hdr.vni, 3);
> +                               memcpy(((uint8_t *)&tenant_id_be + 1),
> +                                      vxlan_spec->hdr.vni, 3);
>                                 filter->vni =
>                                         rte_be_to_cpu_32(tenant_id_be);
>                                 filter->tunnel_type =
> @@ -645,8 +647,8 @@ bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
>                                                  "Invalid TNI mask");
>                                         return -rte_errno;
>                                 }
> -                               rte_memcpy(((uint8_t *)&tenant_id_be + 1),
> -                                          nvgre_spec->tni, 3);
> +                               memcpy(((uint8_t *)&tenant_id_be + 1),
> +                                      nvgre_spec->tni, 3);
>                                 filter->vni =
>                                         rte_be_to_cpu_32(tenant_id_be);
>                                 filter->tunnel_type =
> --
> 2.43.0
>
Acked-by: Somnath Kotur <somnath.kotur@broadcom.com>

diff mbox series

Patch

diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
index f25bc6ff78c7..6466aa394af1 100644
--- a/drivers/net/bnxt/bnxt_flow.c
+++ b/drivers/net/bnxt/bnxt_flow.c
@@ -233,8 +233,9 @@  bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
 						    "DMAC is invalid!\n");
 					return -rte_errno;
 				}
-				rte_memcpy(filter->dst_macaddr,
-					   &eth_spec->hdr.dst_addr, RTE_ETHER_ADDR_LEN);
+				memcpy(filter->dst_macaddr,
+				       &eth_spec->hdr.dst_addr,
+				       RTE_ETHER_ADDR_LEN);
 				en |= use_ntuple ?
 					NTUPLE_FLTR_ALLOC_INPUT_EN_DST_MACADDR :
 					EM_FLOW_ALLOC_INPUT_EN_DST_MACADDR;
@@ -257,8 +258,9 @@  bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
 						    "SMAC is invalid!\n");
 					return -rte_errno;
 				}
-				rte_memcpy(filter->src_macaddr,
-					   &eth_spec->hdr.src_addr, RTE_ETHER_ADDR_LEN);
+				memcpy(filter->src_macaddr,
+				       &eth_spec->hdr.src_addr,
+				       RTE_ETHER_ADDR_LEN);
 				en |= use_ntuple ?
 					NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_MACADDR :
 					EM_FLOW_ALLOC_INPUT_EN_SRC_MACADDR;
@@ -423,23 +425,23 @@  bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
 				en |= EM_FLOW_ALLOC_INPUT_EN_SRC_IPADDR |
 					EM_FLOW_ALLOC_INPUT_EN_DST_IPADDR;
 
-			rte_memcpy(filter->src_ipaddr,
-				   ipv6_spec->hdr.src_addr, 16);
-			rte_memcpy(filter->dst_ipaddr,
-				   ipv6_spec->hdr.dst_addr, 16);
+			memcpy(filter->src_ipaddr, ipv6_spec->hdr.src_addr,
+			       16);
+			memcpy(filter->dst_ipaddr, ipv6_spec->hdr.dst_addr,
+			       16);
 
 			if (!bnxt_check_zero_bytes(ipv6_mask->hdr.src_addr,
 						   16)) {
-				rte_memcpy(filter->src_ipaddr_mask,
-					   ipv6_mask->hdr.src_addr, 16);
+				memcpy(filter->src_ipaddr_mask,
+				       ipv6_mask->hdr.src_addr, 16);
 				en |= !use_ntuple ? 0 :
 				    NTUPLE_FLTR_ALLOC_INPUT_EN_SRC_IPADDR_MASK;
 			}
 
 			if (!bnxt_check_zero_bytes(ipv6_mask->hdr.dst_addr,
 						   16)) {
-				rte_memcpy(filter->dst_ipaddr_mask,
-					   ipv6_mask->hdr.dst_addr, 16);
+				memcpy(filter->dst_ipaddr_mask,
+				       ipv6_mask->hdr.dst_addr, 16);
 				en |= !use_ntuple ? 0 :
 				     NTUPLE_FLTR_ALLOC_INPUT_EN_DST_IPADDR_MASK;
 			}
@@ -591,8 +593,8 @@  bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
 					return -rte_errno;
 				}
 
-				rte_memcpy(((uint8_t *)&tenant_id_be + 1),
-					   vxlan_spec->hdr.vni, 3);
+				memcpy(((uint8_t *)&tenant_id_be + 1),
+				       vxlan_spec->hdr.vni, 3);
 				filter->vni =
 					rte_be_to_cpu_32(tenant_id_be);
 				filter->tunnel_type =
@@ -645,8 +647,8 @@  bnxt_validate_and_parse_flow_type(const struct rte_flow_attr *attr,
 						 "Invalid TNI mask");
 					return -rte_errno;
 				}
-				rte_memcpy(((uint8_t *)&tenant_id_be + 1),
-					   nvgre_spec->tni, 3);
+				memcpy(((uint8_t *)&tenant_id_be + 1),
+				       nvgre_spec->tni, 3);
 				filter->vni =
 					rte_be_to_cpu_32(tenant_id_be);
 				filter->tunnel_type =