From patchwork Wed Feb 28 18:57:07 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 137456 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0EEAA43C28; Wed, 28 Feb 2024 19:57:46 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id E1FDF410F2; Wed, 28 Feb 2024 19:57:45 +0100 (CET) Received: from NAM12-DM6-obe.outbound.protection.outlook.com (mail-dm6nam12on2082.outbound.protection.outlook.com [40.107.243.82]) by mails.dpdk.org (Postfix) with ESMTP id D27B240EE4; Wed, 28 Feb 2024 19:57:43 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=h8ZoB12nAcnzWNDVf+1NOsqZUfN+j4CZZSiH/sD+ANTOGRsQ+ltOWMbeiqbS3GjmnC/9mrEKyJVNd2tx8vt9cFnIla5ecgJlnb/d9+1IxNi6UwsXefwQjr9/2DJOG8ZO/XTXRuK4+6eqAi4PHcNmqlq56RPoLeBqyoJvI5zXa7MlvVnnWIp8xe2YnVkD7SDkEX4AmZZkO+MKCa77EVDRhX9QeL+kIRvgdbdck1E3YNtuRXLiL4c4F5fp+xQ5dEA+P25sLZrve7uBJz1MW5feTu03cbkt6P3jab93XW+GtMZBU4f1STElePAiH5HI0I2Dl0dnmpXMFMhIHxhGajBuJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Wmok4neUykcQsQdu6RvGOYPNWHlWbKdIM8NWrP0CUM8=; b=fXeadvqXgpkxH/KkgpYEESwdgHBbvBfyl1tEzCgqCQJltDnTYAZTiTX9yLTsaUJDaTAD/ACI1ZC3eb+ZjPrcVA2RHnfXoet0phAFzTrJrRPaYt61YDlpzfTXey9u5JUnAw8C8HBV+Jix9hEZeeJE3EZ+nAIcVvNy3M6/yALCIvottSXjnalXTo4VotFMR/fSybavhf7cZ3q0pZsB5or85csNcTj7HvC+Vun8s+i0MHmrvSqNaoCWsojFCXNEEeSgoX7qzV01dcNRF6HMQCnPaU2cyGIaO8ZpQrxUgpclkZmVEl+9P0cN40/OMTcf9C0zxVCc6EbwIA8FOZvTQzaFYA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=intel.com smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Wmok4neUykcQsQdu6RvGOYPNWHlWbKdIM8NWrP0CUM8=; b=T5Ieek1a/sEUzh7o4O6Z3SgRwJskq2JGRIodYjLEfmSEMWjghcV5xu1ZSm3zrRJZoHWG0J9U4NNEO21iiN30pnX5yb/IKZ7SpKIbyDo9CZTbHIsXIDfx9tEBccjjpJAlt5Jeupw77BS94gGesAGgnx693kcqTDWaRFrg0gXz7T6BoIOqPZH0Dslpc8vww6q1RtMLfhC2pwohSG2rSG/SPA7zSrOAM6Z556GV4h2XZLpLn08H9+1uNVg4ZbM/p2kXf5bJjJSKNoCvlF7v044Q9ZqSzSxIJHjmV6iyrfHoEZ0Qvlr5eNBF+20RH4S5SqOmkBDC4CXc6U+3C9+SVz0nFw== Received: from BN0PR07CA0017.namprd07.prod.outlook.com (2603:10b6:408:141::31) by SJ1PR12MB6076.namprd12.prod.outlook.com (2603:10b6:a03:45d::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.33; Wed, 28 Feb 2024 18:57:41 +0000 Received: from BN1PEPF00004682.namprd03.prod.outlook.com (2603:10b6:408:141:cafe::e2) by BN0PR07CA0017.outlook.office365.com (2603:10b6:408:141::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.28 via Frontend Transport; Wed, 28 Feb 2024 18:57:40 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by BN1PEPF00004682.mail.protection.outlook.com (10.167.243.88) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Wed, 28 Feb 2024 18:57:40 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 28 Feb 2024 10:57:25 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Wed, 28 Feb 2024 10:57:23 -0800 From: Dariusz Sosnowski To: Aman Singh , Yuying Zhang , Ori Kam , Alexander Kozyrev CC: , Subject: [PATCH] app/testpmd: fix async flow create failure handling Date: Wed, 28 Feb 2024 19:57:07 +0100 Message-ID: <20240228185707.186522-1-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.39.2 MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail201.nvidia.com (10.129.68.8) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BN1PEPF00004682:EE_|SJ1PR12MB6076:EE_ X-MS-Office365-Filtering-Correlation-Id: b12ba4df-3da2-4234-9da3-08dc388f2396 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mcTNa3C0pqrHG5t4NThVbCbsLxp4s8AFdz+pORb/5zkuvShNELejP9tlp4nfT5xh/zvEQEGQluacGkqkyg5OEERj3GreSIKRhODKl7T2bQxbKz6Lf0joMADYH8rkJKfKiChZbmfc1SDkBRGMFsuVzuukmBcm5vBUiS5g6gY3JyU3NcJWwWYo8hXMFUO3vjHO+adFozddGUFqeLmp49hdsapX2nqzYQkF0ksEbFshCHXh6BxZAvgQjTz7OtShdnyWNvl77lCuMUzz36gUNoA2GY+BKYrh5w3OGsOF5l63JazaJRHejjKzpgs9tdKoIyoiQDtPqMibMAXExdtjSsPoD7hB3rXpmkApAbY/LF/sbO1DsjIX1mRcbLU6/htHgIGkarFOzUotvqAFSoIp3s+mUN48NlExky/d2a9y6bs/Rl1+H8XcEzL7N8nDLxWMlAu2esLQyVewuTwwLFalRC7QssqLzR0t67YhkfN/ROAYs2RLCp/H/VUtC6hFSLT4ix2/A26hVE3hgcliIBEEZiIgnwPQ9TeajckQ7j5wPD0xyPfmF/dCy3fUJ8Wu7gAL87FPAa7P4/yrNz4xvaau3hQlxlSNu4g5VRTtX/zjgwcmjWbrjMRTIpEeWM+yjsMLftV9wUbw4dEq/jpz699psSImCxKHJgNC3+WtwZkhAD9LHRX5el9+sRiEk7o5AQJ5WDKaiLYy7Lit2vM5/Zljoc9/eF4+J84qY5qqo7LnTdvqDJbx6pSMAK2xMiyy+3KSP28+ X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 18:57:40.5507 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b12ba4df-3da2-4234-9da3-08dc388f2396 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: BN1PEPF00004682.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ1PR12MB6076 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In case of an error when an asynchronous flow create operation was enqueued, test-pmd attempted to enqueue a flow destroy operation of that flow rule. However, this was incorrect because: - Flow rule index was used to enqueue a flow destroy operation. This flow rule index was not yet initialized, so flow rule number 0 was always destroyed as a result. - Since rte_flow_async_create() does not return a handle on error, then there is no flow rule to destroy. test-pmd only needs to free internal memory allocated for storing a flow rule. Any flow destroy operation is not needed in this case. Fixes: ecdc927b99f2 ("app/testpmd: add async flow create/destroy operations") Cc: akozyrev@nvidia.com Cc: stable@dpdk.org Signed-off-by: Dariusz Sosnowski Acked-by: Ori Kam --- app/test-pmd/config.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/app/test-pmd/config.c b/app/test-pmd/config.c index 08d7d0e2f8..8bf2e411b5 100644 --- a/app/test-pmd/config.c +++ b/app/test-pmd/config.c @@ -2856,8 +2856,7 @@ port_queue_flow_create(portid_t port_id, queueid_t queue_id, flow = rte_flow_async_create_by_index(port_id, queue_id, &op_attr, pt->table, rule_idx, actions, actions_idx, job, &error); if (!flow) { - uint64_t flow_id = pf->id; - port_queue_flow_destroy(port_id, queue_id, true, 1, &flow_id); + free(pf); free(job); return port_flow_complain(&error); }