From patchwork Wed Feb 28 17:00:46 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dariusz Sosnowski X-Patchwork-Id: 137448 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D9DE543C2C; Wed, 28 Feb 2024 18:02:59 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9874842FD3; Wed, 28 Feb 2024 18:01:57 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2044.outbound.protection.outlook.com [40.107.94.44]) by mails.dpdk.org (Postfix) with ESMTP id E187742F4F; Wed, 28 Feb 2024 18:01:54 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Cr2VLoOYbpEVu4j4koiySppKNLcH0xfxBFBMIvxRtKIvWJ9oIvpxIUv4MGtWgPg74Kh6ZgyboXQZ+uzDW4Xe2DM1D54dbSXmiX2oIH6bsj4UlamroDGEgAo8beCNuArjcsGAUr0FeNn1JKcxGoyA8Ip16SQWG0FFwb90omEMzIq1cdp3VH7DUvtli9Pc+xj9MAqAneOyU/CncgzIN2nVI9Ivyt/5sR/XELGLepwNY9djSM1Bjlg92xL/UVkLsBxcwQ6xOBzOZyaCHdkNTYxoDIIQnSZzTgexT5OMAFl+I2C+sOUrms3Lt3+QfODOhft4etqSp+DoPkU4Cwi3iB6f/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Aqow6mCtzCw9FOBqPbkdQXtGrJ1boJW2x/thcxnMak8=; b=W5GWdbHqc5dZDvFqK48vA9wC2x2bq/jY8z2bkO7zCdFdoMj2zoCVG3gwzI6aBgTBXZNWGjjl5+m1Bkw9JCq2dkspabMU+bW3b0y44G3EdSpN2rP9lofw3/uTrF0SvZqcz60n/3T5UA70ZEOMn0yw5EEl6pioZLFyzlDgh743tfgsLZGzI4VI4Q5S3sNQnaIVBYjvpDKMJ8CzKg8Wi/LAjzfUDumMe9u/bXhjLonMqBgvgSRKfggKao3UR4xqKwmj35U1XAHkp4DaKHrhJZP3uAYzE8CzRr91AZHu6ByKRpfkY1k/Qgdl8UcR6MT9Io9XwaQxakDnSakRu1ak+44Fpw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Aqow6mCtzCw9FOBqPbkdQXtGrJ1boJW2x/thcxnMak8=; b=gi5Oo0UZ9oWmHQbPmVC09gycibSvU2NXjqFjmnyhc9YkN7ACurLAKZMZ3rkfxeb6W8DblPAIx4V9Ru20acxwYJ/51KMzYUdHPGDRrDQ7BH47ykbVeDWq2fCwodNlzjrLhHMu54aELynG86ZlBluvHY5be/IBucWrAkU62qTXS7RJVv9QVPJhqcackPsnP9W5iBDeBbOwdEPntVgUDjZPdn9YJD+rJGHUXuCQqvR0CTXZn63I0tlfqeTTk+lFoA2cBaZjUZu0v8zB3CL1HFssDxtXBvVSWNxvW+j/DdaC+8PjW16mTED+ufviaPZHrptJyNv6QI1KrFZVQrK7Rydf3A== Received: from SJ0PR03CA0232.namprd03.prod.outlook.com (2603:10b6:a03:39f::27) by BN9PR12MB5274.namprd12.prod.outlook.com (2603:10b6:408:11f::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7316.39; Wed, 28 Feb 2024 17:01:51 +0000 Received: from SJ1PEPF00001CE2.namprd05.prod.outlook.com (2603:10b6:a03:39f:cafe::6b) by SJ0PR03CA0232.outlook.office365.com (2603:10b6:a03:39f::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7339.28 via Frontend Transport; Wed, 28 Feb 2024 17:01:51 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by SJ1PEPF00001CE2.mail.protection.outlook.com (10.167.242.10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Wed, 28 Feb 2024 17:01:50 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Wed, 28 Feb 2024 09:01:28 -0800 Received: from nvidia.com (10.126.230.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1258.12; Wed, 28 Feb 2024 09:01:26 -0800 From: Dariusz Sosnowski To: Viacheslav Ovsiienko , Ori Kam , Suanming Mou , Matan Azrad CC: , Raslan Darawsheh , Bing Zhao , Subject: [PATCH 11/11] net/mlx5: remove unneeded device status checking Date: Wed, 28 Feb 2024 18:00:46 +0100 Message-ID: <20240228170046.176600-12-dsosnowski@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240228170046.176600-1-dsosnowski@nvidia.com> References: <20240228170046.176600-1-dsosnowski@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.230.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ1PEPF00001CE2:EE_|BN9PR12MB5274:EE_ X-MS-Office365-Filtering-Correlation-Id: f6e53a73-c84c-414a-476a-08dc387ef524 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: m66k8AXy0dLnWc88qQam4lajKMxlNzSk3Rdn2UM/4uR7S8JyCMSjwd4m78ysCzKiG1XElDqqBY+6ZV9kMlu3mFTGZBWiDv27oIzydQtQZK3IHz1Cx13+EYkpqiLX9IikXvzd5p+A4NHXzWuEwUNg90jjaI7akuk8AUsmopP8OGg2q4oGn8Mhr09iRtbApBmsPyJo1JH55GdPRLgTF7iT3Y4t3/FonIoZi7FPI7XQIGdTfEtjP6nL8Ur09CoSszt7gjhvTYGasZEq7ndbMjuc+1bkJYhhFxcYUHjUbJS4aTCU8RTRQV8W5rubq9fN7pxdSPR77aEJfc+vV51ffDbpl77aRY5/F5DEfVQqa/Q3zHuhtZ7nYtKgchYe2DRCaf0TB3S3sRtCDw4SNem9A8j1JW7uzzWAq6UyECvztC8FQhonBdipUXebJgP8ONEvCNKlzTkb+AilkPKprgaBQ1E8Ih/xOyUz/7/c/oyqCwkEcvSG/obiDwvygYrOQpH6m6fHs9TziER4ZUygpWnL8eawxAncq9aQPX+UzVcNRf9grrlH02JS1dp6yA1Fscp+HGpDN0HH6tPNBjaPZg5iFp1bJ6fHtD6E2XsP4vNgHHe1SaAYoCmkb7SLRiRW0Mq9q65pRMVU9dtxRzq6AiojeRZU6vaUQGn3buRbom+ksZhxCtbr3X4+g15BYMIWAM1z4xfYQUKxMS22NeH/oAO5A6oYTT8rczO5XUswZbaat3GY+lxlP8tdWtq1QE2OEmYIroZu X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(82310400014)(36860700004); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Feb 2024 17:01:50.8660 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: f6e53a73-c84c-414a-476a-08dc387ef524 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: SJ1PEPF00001CE2.namprd05.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN9PR12MB5274 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Bing Zhao The flow rule can be inserted even before the device started. The only exception is for a queue or RSS action. For the other interfaces of template API, the start status is not checked. The checking would cause some cache miss or eviction since the flag locates on some other cache line. Fixes: f1fecffa88df ("net/mlx5: support Direct Rules action template API") Cc: stable@dpdk.org Signed-off-by: Bing Zhao --- drivers/net/mlx5/mlx5_flow_hw.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index 4e4beb4428..8481a9b7f0 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -3501,11 +3501,6 @@ flow_hw_async_flow_create(struct rte_eth_dev *dev, uint32_t res_idx = 0; int ret; - if (unlikely((!dev->data->dev_started))) { - rte_flow_error_set(error, EINVAL, RTE_FLOW_ERROR_TYPE_UNSPECIFIED, NULL, - "Port must be started before enqueueing flow operations"); - return NULL; - } flow = mlx5_ipool_malloc(table->flow, &flow_idx); if (!flow) goto error;