From patchwork Wed Feb 21 21:20:41 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 136983 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 87EE143B67; Wed, 21 Feb 2024 22:21:50 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 4C12540DD8; Wed, 21 Feb 2024 22:21:14 +0100 (CET) Received: from mail-ot1-f46.google.com (mail-ot1-f46.google.com [209.85.210.46]) by mails.dpdk.org (Postfix) with ESMTP id C396040A76 for ; Wed, 21 Feb 2024 22:21:11 +0100 (CET) Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6e2dfc98664so583800a34.2 for ; Wed, 21 Feb 2024 13:21:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1708550471; x=1709155271; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=uFn7Uy5+vrzbKAsBpXX5g7Ycj/Mf6GSOY0NvKW5cSko=; b=a7yptpivOtMhzGSj8NCd+wO+cnbJQq5VVfYSXX1pcC4/kRQZPyiWJzZF/8NK899kQg AmTjcKLgini0MDaSP52WtYmL/IsiXbovjK2c+5qswbvtPR9x5q68T+n8DCNRpGpDYlnF Mdoqd3K8uFtz4rv16FFomJZpHdmvaOkLRDTt4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708550471; x=1709155271; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=uFn7Uy5+vrzbKAsBpXX5g7Ycj/Mf6GSOY0NvKW5cSko=; b=nsNH3O8bAtetg95QWaZi8jbNPFGkc4MYCd5gaoaG3UuZqa/5TRbdfT0AfhsOaMnnx3 K3WzVIwU9WVyXLK+E9Ot7Irky+XsgKyv5iWN0svIk2TwR7DT74yCHiBYVZcBQ3j3gtrL siy6npu1N4vUJ+1skTpKtXtJ4B3pNKBi8n30MC242vLqdqqzCJD5Vz1PN53YvQRvx3El iECiBd2BOiMVM3U8cH8qhHhLi66todUQEhY4dbl/rwVF9OPdE81zUMZThUI+8EojvLgO DggbBQzDGPhN0aeFQ9v8BqcCYJ9mTdU5EElxEry+RgSPe/5wFVu1Jtb48wLNzYdhuD/Q tDMw== X-Gm-Message-State: AOJu0YywetGLzjYUpBOrNKA+uKGZIk4KaXLz7Orz7XE5NQ05pAHJhm8e mrNtrRYoRaydpxuu2KQLICYD75WeTDXftQ0Rg59ryt+mX/GeaiWTTMNUw3docnOtc4AQRCodx7H p21A9In92idCAhkwpzcaHXvdzjhShwYu1QpM+fi/72HPqDyNbGU7xuGywnavj+d9qF0r6R8hkq+ 0snkC8wDAf5VfiB0AgCaNBttXoMX+k X-Google-Smtp-Source: AGHT+IErcQXCmcxoNPZc1mDrFBcIYpwTjhjvYHzTanuzION6Loy939u3FNhZ/R4cwT8i1aTp7XbksQ== X-Received: by 2002:a05:6870:3118:b0:21f:1f78:adc9 with SMTP id v24-20020a056870311800b0021f1f78adc9mr6586240oaa.29.1708550470770; Wed, 21 Feb 2024 13:21:10 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id 20-20020ac84e94000000b0042bff97d9a3sm4743467qtp.40.2024.02.21.13.21.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 21 Feb 2024 13:21:10 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: ferruh.yigit@amd.com, thomas@monjalon.net Subject: [PATCH 06/10] net/bnxt: handle UDP GSO Tx Date: Wed, 21 Feb 2024 13:20:41 -0800 Message-Id: <20240221212044.27209-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20240221212044.27209-1-ajit.khaparde@broadcom.com> References: <20240221212044.27209-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The UDP GSO capability is not being detected and reported correctly. This is causing UDP GSO to not happen in some cases. This patch fixes the issue. Signed-off-by: Ajit Khaparde --- drivers/net/bnxt/bnxt_hwrm.c | 3 ++- drivers/net/bnxt/bnxt_txr.c | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index 7923d4cbd2..7f49b4b40e 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -1141,6 +1141,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) bp->max_ring_grps = rte_le_to_cpu_32(resp->max_hw_ring_grps); flags = rte_le_to_cpu_32(resp->flags); + flags_ext2 = rte_le_to_cpu_32(resp->flags_ext2); + if (BNXT_PF(bp)) { bp->pf->port_id = resp->port_id; bp->pf->first_vf_id = rte_le_to_cpu_16(resp->first_vf_id); @@ -1225,7 +1227,6 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) PMD_DRV_LOG(DEBUG, "Tunnel parsing capability is disabled, flags : %#x\n", bp->tunnel_disable_flag); - flags_ext2 = rte_le_to_cpu_32(resp->flags_ext2); if (flags_ext2 & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT2_RX_ALL_PKTS_TIMESTAMPS_SUPPORTED) bp->fw_cap |= BNXT_FW_CAP_RX_ALL_PKT_TS; if (flags_ext2 & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT2_UDP_GSO_SUPPORTED) diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 7cbb2104a0..83c003d258 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -116,7 +116,8 @@ bnxt_xmit_need_long_bd(struct rte_mbuf *tx_pkt, struct bnxt_tx_queue *txq) RTE_MBUF_F_TX_VLAN | RTE_MBUF_F_TX_OUTER_IP_CKSUM | RTE_MBUF_F_TX_TUNNEL_GRE | RTE_MBUF_F_TX_TUNNEL_VXLAN | RTE_MBUF_F_TX_TUNNEL_GENEVE | RTE_MBUF_F_TX_IEEE1588_TMST | - RTE_MBUF_F_TX_QINQ | RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE) || + RTE_MBUF_F_TX_QINQ | RTE_MBUF_F_TX_TUNNEL_VXLAN_GPE | + RTE_MBUF_F_TX_UDP_SEG) || (BNXT_TRUFLOW_EN(txq->bp) && (txq->bp->tx_cfa_action || txq->vfr_tx_cfa_action))) return true;