diff mbox series

[v1,1/2] app/testpmd: fix modify tag typo

Message ID 20240221071043.3309205-2-rongweil@nvidia.com (mailing list archive)
State Changes Requested, archived
Delegated to: Ferruh Yigit
Headers
Series fix flex item modify error |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation warning apply patch failure
ci/iol-testing warning apply patch failure

Commit Message

Rongwei Liu Feb. 21, 2024, 7:10 a.m. UTC 
  Update the name to the right one: "src_tag_index"

Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
Fixes: 7ea38955b ("ethdev: update MPLS header modification API")
Cc: michaelba@nvidia.com
Cc: stable@dpdk.org
Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>
---
 app/test-pmd/cmdline_flow.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ferruh Yigit Feb. 21, 2024, 4:33 p.m. UTC | #1 
On 2/21/2024 7:10 AM, Rongwei Liu wrote:
> Update the name to the right one: "src_tag_index"
> 
> Fixes: 7ea38955b ("ethdev: update MPLS header modification API")
> Cc: stable@dpdk.org
>
> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>>

Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
Ferruh Yigit Feb. 21, 2024, 4:42 p.m. UTC | #2 
On 2/21/2024 4:33 PM, Ferruh Yigit wrote:
> On 2/21/2024 7:10 AM, Rongwei Liu wrote:
>> Update the name to the right one: "src_tag_index"
>>
>> Fixes: 7ea38955b ("ethdev: update MPLS header modification API")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Rongwei Liu <rongweil@nvidia.com>
>> Acked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>>
> 
> Acked-by: Ferruh Yigit <ferruh.yigit@amd.com>
> 

btw, fixes commit is wrong, it should be [1], I guess this is related to
the tree you are using as other patch has similar issue.


[1]
Fixes: c23626f27b09 ("ethdev: add MPLS header modification")
Rongwei Liu Feb. 22, 2024, 3:06 a.m. UTC | #3 
I am using the master-net-mlx branch as base to verify.
And cross-checked the main and master-net-mlx branch diverage now.
Patch 1 was good and patch 2 failed to apply on the main branch.

[rongweil@gen-l-vrt-290 mlnx_dpdk]$ patch -d ./ -p 1 < 1.patch
patching file app/test-pmd/cmdline_flow.c
Hunk #1 succeeded at 7283 (offset -186 lines).
[rongweil@gen-l-vrt-290 mlnx_dpdk]$ patch -d ./ -p 1 < 2.patch
patching file drivers/net/mlx5/mlx5_flow.c
Hunk #1 succeeded at 2384 with fuzz 1 (offset 15 lines).
patching file drivers/net/mlx5/mlx5_flow_hw.c
Hunk #1 FAILED at 6104.
Hunk #2 FAILED at 6129.
2 out of 2 hunks FAILED -- saving rejects to file drivers/net/mlx5/mlx5_flow_hw.c.rej

@Raslan Darawsheh<mailto:rasland@nvidia.com>Do I need to switch to main branch when sending patches to community?


BR

Rongwei
diff mbox series

Patch

diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c
index c6ea9d9be0..929bf18119 100644
--- a/app/test-pmd/cmdline_flow.c
+++ b/app/test-pmd/cmdline_flow.c
@@ -7469,7 +7469,7 @@  static const struct token token_list[] = {
 		.comp = comp_none,
 	},
 	[ACTION_MODIFY_FIELD_SRC_TAG_INDEX] = {
-		.name = "stc_tag_index",
+		.name = "src_tag_index",
 		.help = "source field tag array",
 		.next = NEXT(action_modify_field_src,
 			     NEXT_ENTRY(COMMON_UNSIGNED)),