From patchwork Tue Feb 13 09:50:36 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Itamar Gozlan X-Patchwork-Id: 136630 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C174843B05; Tue, 13 Feb 2024 10:52:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 12ABC42830; Tue, 13 Feb 2024 10:51:31 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2071.outbound.protection.outlook.com [40.107.244.71]) by mails.dpdk.org (Postfix) with ESMTP id 64526427DB for ; Tue, 13 Feb 2024 10:51:29 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TsUIDnT4m84G9UJl7mFe5GPXORHm8Hz99KTOlJXDB8ZxbIVazO2QVGIZvepuAnBNsZ8q8mk8l+a3OSP1iFZdkJUsI+eMC9vPE5dNjIN+s4YyiQhhZKiaJd5sOS25a30ehV0zioNbcxJXiU1UOfpk8CaRAfCVb8hL+00OU15khwK7bxCafF9O6uFj0vESA96b866etlcVO714VGNMgRHZCBnyLoZgH+toYv3zTujy8Pvdu6pL7gNj98aVcm+jJAk5lX40JeqYwQyICZcezqDXCKO5Qa7u0KjU/ZhmCyoDf8SAypK+57bah2Mu63TaY6sdFvv6O3svLT6NZcd06FZtbA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=LBslI7knY85sqF7mprdQZRd5utpuknqU4scH30NkDOc=; b=Wnfe8GBSl7Uta8UB9D0N9f6182F/udjtCnhIedh9XUan0r5l38iXe7Xbl69wIOt1XPpn2/dEv7CVF4Lre1gnEbynU2zUbDXAdHlEZHpsFAhMLXVlffKeNwtsBiB8m9TLtiQXHTPATiU9GbGT1DaHwUK47nZ1YqD9PHMeMfA2Dbjvf1pHaf5kKnWut3xYlOvpgkU0VZA34VAwufQauo+GjbLxBV3Xx6frEvBklLWJ/6P2M81LThTU61rSunRCMUSUpuEeTgbBvvLXzKvZqhdNkGz74ftojB+0rNxC1EItnFEZjrt1hqx3x9aBVUmFC652oWnJJ17AXu8vnkzfqQTujg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.160) smtp.rcpttodomain=monjalon.net smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=LBslI7knY85sqF7mprdQZRd5utpuknqU4scH30NkDOc=; b=JhtWOTCN5O6fUc9wGHsABuIeVnljV8Obv2KlRDJfR/1a8q2MBkWaplXsJmnxyVzywT7NhY+fc+jsImchW+lpqf/gT4tdr+7+zD23LoJ+5kSsJpFVK/d8O9pfHKwywkdNfYQtLPAFeQPFy3JnSIPp++2GbRXTMvN5Ohm6UfKGjlsDYQN7+Nt9AJz2s1J++jS1cJTAa4ZOEG2RrsrlF5kaLHcqDeEzUZwIOHKY0QuXNDPQPLfuxfjWCKxWabEJCX0UVDjbGYld3iTQfe2X767WLRmBlyp5lk+5ZB9XwULQBdia85OWYghm3sxyj1bpdUyOls9INPIDX5IVc64217FMXQ== Received: from CH2PR19CA0001.namprd19.prod.outlook.com (2603:10b6:610:4d::11) by CH2PR12MB4118.namprd12.prod.outlook.com (2603:10b6:610:a4::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25; Tue, 13 Feb 2024 09:51:26 +0000 Received: from CH2PEPF0000009A.namprd02.prod.outlook.com (2603:10b6:610:4d:cafe::55) by CH2PR19CA0001.outlook.office365.com (2603:10b6:610:4d::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.40 via Frontend Transport; Tue, 13 Feb 2024 09:51:26 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.160) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.160 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.160) by CH2PEPF0000009A.mail.protection.outlook.com (10.167.244.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7292.25 via Frontend Transport; Tue, 13 Feb 2024 09:51:26 +0000 Received: from rnnvmail203.nvidia.com (10.129.68.9) by mail.nvidia.com (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 13 Feb 2024 01:51:14 -0800 Received: from rnnvmail203.nvidia.com (10.129.68.9) by rnnvmail203.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Tue, 13 Feb 2024 01:51:14 -0800 Received: from nvidia.com (10.127.8.12) by mail.nvidia.com (10.129.68.9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend Transport; Tue, 13 Feb 2024 01:51:11 -0800 From: Itamar Gozlan To: , , , , , , , Dariusz Sosnowski , Ori Kam , Matan Azrad CC: Subject: [PATCH 8/9] net/mlx5/hws: add missing actions STE limitation Date: Tue, 13 Feb 2024 11:50:36 +0200 Message-ID: <20240213095038.451299-8-igozlan@nvidia.com> X-Mailer: git-send-email 2.39.3 In-Reply-To: <20240213095038.451299-1-igozlan@nvidia.com> References: <20240213095038.451299-1-igozlan@nvidia.com> MIME-Version: 1.0 X-NV-OnPremToCloud: ExternallySecured X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF0000009A:EE_|CH2PR12MB4118:EE_ X-MS-Office365-Filtering-Correlation-Id: 20d3c9cf-4afe-41e9-edc3-08dc2c79589b X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rPo25j1FBXGSWM33wlB/yA3S86S7Gv+DlMwIvoUjM4IZkX5vTsHg6Jrle5qu/RpaXNLwJe0winc7k5jWQBL9cL3Zm+wnkxdO2TxslRnxmSf951n+kX0sm86HjEXOS2t4IMiK9iHcS0Ca0Qk9hDEOBKo2Rm/VvnoLCqaPcaFFkVeRPB0UGTa/DljKSxbyazsrac4ZcJPvDgSRKEm6pQRrWuV4gzbPKRPeaXMLcUzvO1VQgje/4piV9yEL90x7Kaf68Q3aUGkllS9OP7A9yvF8vQOUqnoYqqpsfqk3In/IJLuKy/aE4TTwA7ElfgZmR2XE0YiBSM3PzpIkZog4lcU9R9dUanAjU07fn9Ekl2qlcZFQaI0aAFU6nSnC4COyQT/6ALp/dVnDY/22qZ1KvzPxSwECKWGBm+AbjB8x8pyB4cmSzkpo3n0c40nX4/oylZmlVG9r8IC2kc1YxYIPkXYvrFVd20LWT48YVgVEbIFeBP+Ea0TSB4Wz5DCKLY3nScGwSizPjirAt/WTHU/Z5Cx8k7XSxLtV9nIqiL/qabGKJUH1AIl70IT9qzMZHA5JiknOSyqjuF83yi3KiCBeagw1Cjg/+wTKr2/flwJlyOsUY0s9q0W7/hp4RUatKrGc41QFCvP44geWgteftYf7EsduFw== X-Forefront-Antispam-Report: CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(136003)(396003)(39860400002)(346002)(376002)(230922051799003)(1800799012)(82310400011)(186009)(451199024)(64100799003)(40470700004)(46966006)(36840700001)(2906002)(55016003)(5660300002)(41300700001)(2616005)(426003)(6286002)(1076003)(336012)(83380400001)(26005)(8676002)(8936002)(4326008)(7696005)(70206006)(70586007)(921011)(110136005)(6636002)(316002)(6666004)(356005)(82740400003)(7636003)(86362001)(478600001)(36756003); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Feb 2024 09:51:26.7484 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20d3c9cf-4afe-41e9-edc3-08dc2c79589b X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF0000009A.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4118 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Hamdan Igbaria Today if we pass a remove header action and after it an insert header action then our action template builder will set two different STE setters, because it won't allow insert header in same STE as remove header. But if we have the opposite order of insert header and then remove header actions, then the setter will set both of them on the same STE since the opposite check was missing. This patch added the missing opposite limitation. Signed-off-by: Hamdan Igbaria Acked-by: Matan Azrad --- drivers/net/mlx5/hws/mlx5dr_action.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/mlx5/hws/mlx5dr_action.c b/drivers/net/mlx5/hws/mlx5dr_action.c index 370886907f..8589de5557 100644 --- a/drivers/net/mlx5/hws/mlx5dr_action.c +++ b/drivers/net/mlx5/hws/mlx5dr_action.c @@ -3308,7 +3308,8 @@ int mlx5dr_action_template_process(struct mlx5dr_action_template *at) case MLX5DR_ACTION_TYP_REMOVE_HEADER: case MLX5DR_ACTION_TYP_REFORMAT_TNL_L2_TO_L2: /* Single remove header to header */ - setter = mlx5dr_action_setter_find_first(last_setter, ASF_SINGLE1 | ASF_MODIFY); + setter = mlx5dr_action_setter_find_first(last_setter, + ASF_SINGLE1 | ASF_MODIFY | ASF_INSERT); setter->flags |= ASF_SINGLE1 | ASF_REMOVE; setter->set_single = &mlx5dr_action_setter_single; setter->idx_single = i;