From patchwork Tue Feb 6 10:34:20 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Marchand X-Patchwork-Id: 136417 X-Patchwork-Delegate: bruce.richardson@intel.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2F9BF43A99; Tue, 6 Feb 2024 11:34:30 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B412640ECF; Tue, 6 Feb 2024 11:34:29 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 90052402C8 for ; Tue, 6 Feb 2024 11:34:28 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1707215668; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LV5vdeqcFn4NIsSmUVPGgAc1tqp7F81dIEBcFoh9iZk=; b=fBAO+2Fe6hLggHIB6YbLzVzQ5BLBo1q5z5aWAUdmVdR2OT/y2X4lSpwq2HsynNCceGQzTw K/kP6csnbhqtQPlACE1+XtJORWHTVIXB/ZlzsL99c6LbcY1uQBnMyUE9I+gpKdI1JF6IaB pCWp2Pu0aLJjlNrmxRnxyuKv0+/u+x0= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-615-Lkr_p7IoNbeB9ZlSvoI2nA-1; Tue, 06 Feb 2024 05:34:25 -0500 X-MC-Unique: Lkr_p7IoNbeB9ZlSvoI2nA-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9364C185A781; Tue, 6 Feb 2024 10:34:24 +0000 (UTC) Received: from dmarchan.redhat.com (unknown [10.45.224.193]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2CCFD2166B31; Tue, 6 Feb 2024 10:34:23 +0000 (UTC) From: David Marchand To: dev@dpdk.org Cc: bruce.richardson@intel.com, stable@dpdk.org, Jingjing Wu , Qiming Yang , Qi Zhang , Haiyue Wang Subject: [PATCH v2] net/iavf: remove error logs for vlan offloading Date: Tue, 6 Feb 2024 11:34:20 +0100 Message-ID: <20240206103420.341328-1-david.marchand@redhat.com> In-Reply-To: <20240206095607.339410-1-david.marchand@redhat.com> References: <20240206095607.339410-1-david.marchand@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This was reported by RH QE. When a vlan is enforced on a VF via an administrative configuration on the PF side, the net/iavf driver logs two error messages. Those error messages have no consequence on the rest of the port initialisation and packet processing works fine. [root@toto ~] # ip l set enp94s0 vf 0 vlan 2 [root@toto ~] # dpdk-testpmd -a 0000:5e:02.0 -- -i ... Configuring Port 0 (socket 0) iavf_dev_init_vlan(): Failed to update vlan offload iavf_dev_configure(): configure VLAN failed: -95 iavf_set_rx_function(): request RXDID[1] in Queue[0] is legacy, set rx_pkt_burst as legacy for all queues The first change is to remove the error log in iavf_dev_init_vlan(). This log is unneeded since all error path are covered by a dedicated log message already. Then, in iavf_dev_init_vlan(), requesting all possible VLAN offloading must not trigger an ERROR level log message. This is simply confusing, as the application may not have requested such vlan offloading. The reason why the driver requests all offloading is unclear so keep it as is. Instead, rephrase the log message and lower its level to INFO. Fixes: 1c301e8c3cff ("net/iavf: support new VLAN capabilities") Cc: stable@dpdk.org Signed-off-by: David Marchand Acked-by: Bruce Richardson --- Changes since v1: - updated log message, --- drivers/net/iavf/iavf_ethdev.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/net/iavf/iavf_ethdev.c b/drivers/net/iavf/iavf_ethdev.c index 1fb876e827..3532e379a1 100644 --- a/drivers/net/iavf/iavf_ethdev.c +++ b/drivers/net/iavf/iavf_ethdev.c @@ -631,7 +631,8 @@ iavf_dev_init_vlan(struct rte_eth_dev *dev) RTE_ETH_VLAN_FILTER_MASK | RTE_ETH_VLAN_EXTEND_MASK); if (err) { - PMD_DRV_LOG(ERR, "Failed to update vlan offload"); + PMD_DRV_LOG(INFO, + "VLAN offloading is not supported, or offloading was refused by the PF"); return err; } @@ -707,9 +708,7 @@ iavf_dev_configure(struct rte_eth_dev *dev) vf->max_rss_qregion = IAVF_MAX_NUM_QUEUES_DFLT; } - ret = iavf_dev_init_vlan(dev); - if (ret) - PMD_DRV_LOG(ERR, "configure VLAN failed: %d", ret); + iavf_dev_init_vlan(dev); if (vf->vf_res->vf_cap_flags & VIRTCHNL_VF_OFFLOAD_RSS_PF) { if (iavf_init_rss(ad) != 0) {