From patchwork Fri Feb 2 19:32:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Boyer X-Patchwork-Id: 136342 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 08EF343A53; Fri, 2 Feb 2024 20:33:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3190542E50; Fri, 2 Feb 2024 20:33:18 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2041.outbound.protection.outlook.com [40.107.223.41]) by mails.dpdk.org (Postfix) with ESMTP id 5261042DC5 for ; Fri, 2 Feb 2024 20:33:16 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=irQx2oDbFmM1q1zkJ4JrGXdBefHlS9UJgJOOurTQ/ibtDq2HOhUgNnSy7HA3DyNaayIzliotSdKLlCqUD7dQ9wEFwFN1Ka+OEpTQCU+mFrq8l5md7Kx19K0zdJ2Y927hTUtWIE5nLkojzll+zZrFr8CXlRGhH8EB3Q4MNBnFsP2vnmyWDl9GIE4Rdzpvu0nyAdSE/lSOaJvxKRIlDUi7D5wnC3uI4etg1PEZ1GrmyxyBGVUMJBE8dHQEt5xjXEUuL1ddmOdjcZkeQTf1/N2W8SfObLvk2Y0vcFLTNZx8US/XXNILDe17EdLS8321t9SkkTG8ecvyuJFdJgekRIZ9AQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=KZ6oICy5KqkhfY18QjOol/NtvCNsb3uhrZVW/XHP7vw=; b=gbsmC7MP05yXnE/c0dN6bXVO6d4BjznFX+gCoAH6tNs5XIsn4We5H0xO9HY2Zq2SC6klKQ7fFTeZ/q2g+omEupLrh+QryjNk61iwOP/ocRAx1QWb8XnXoCYRr3roCNB40qqe2iC606TMmMwnM/7sLbSbG/+cSYaDMPThv6uHx3WBuaC9RlzRXVAaY3+DAvp4z+CHKKvfcilL8AwieXgXo5tai3UjNYdpaGQXkgxcVIW21s1Voaoxd8HW6WBpzkUJiMTVkr4Q4YyvtpFWG8IshCUUeadUZALEemwFtkip/a/wtAJ9rZgJpSTDqvjPhIy392sPF1R/pIHKKxjKFnGPiw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=KZ6oICy5KqkhfY18QjOol/NtvCNsb3uhrZVW/XHP7vw=; b=BURQ0QG1RCykA0IMTXdGY79MBp9PJVlDPVh6a1Lcr9OgEnMdJbWl39x0vxuARF+rgwGz6QuaUNYz1YdqL80zuvExZVWIoAX6rs90eqyIeJ417binMZTUZht8jPtwVtFKuAyp0ll4TA85xsv9sBZoFbOrJceSvcVF+4ZbG+z3G/E= Received: from DS7PR03CA0266.namprd03.prod.outlook.com (2603:10b6:5:3b3::31) by IA0PR12MB8374.namprd12.prod.outlook.com (2603:10b6:208:40e::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.14; Fri, 2 Feb 2024 19:33:12 +0000 Received: from DS1PEPF00017090.namprd03.prod.outlook.com (2603:10b6:5:3b3:cafe::5a) by DS7PR03CA0266.outlook.office365.com (2603:10b6:5:3b3::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7228.35 via Frontend Transport; Fri, 2 Feb 2024 19:33:12 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS1PEPF00017090.mail.protection.outlook.com (10.167.17.132) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7249.19 via Frontend Transport; Fri, 2 Feb 2024 19:33:11 +0000 Received: from driver-dev1.pensando.io (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.34; Fri, 2 Feb 2024 13:33:10 -0600 From: Andrew Boyer To: CC: Andrew Boyer Subject: [PATCH 03/13] net/ionic: don't auto-enable Rx scatter-gather a second time Date: Fri, 2 Feb 2024 11:32:28 -0800 Message-ID: <20240202193238.62669-4-andrew.boyer@amd.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20240202193238.62669-1-andrew.boyer@amd.com> References: <20240202193238.62669-1-andrew.boyer@amd.com> MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB04.amd.com (10.181.40.145) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS1PEPF00017090:EE_|IA0PR12MB8374:EE_ X-MS-Office365-Filtering-Correlation-Id: b803c0f5-1b2a-4ddb-c0dd-08dc2425cb1b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: msgyGq+B/x7IhagZyYU8W2MS/GDoXS3f5AnjRX7zvjg4EaYM3hcTptTxaYLdjgdIzKRGVU+mzejww9yPK7ZaZAYMuC8weiiLJNherAggiqhxIM2OwAVBo7QMOt7hTbpsSzQ6zg52LFmgUDXeesCqcisc8sdEk/BFWjnF79gYiSz/N8sNRUuGZRlntdC9KFbFkU/6m8iKYLjCpPVgl0WNoS72JP721hxchJDTk2Ch6dmQlxn7OkYpto5o7WtoRwlVRj91lsnxlX7tHvMV7OVfXtdRhOI0fpI7TcA0BWucqjtza9KxYY8g5APusZI+yp4ViopLbL1yQngNUbW8YRseQgvb2MR9cj2vW2U279yL4YSMWbRC8UQ+Vbeg1LKhWHiovq9qd6G7h3//+5lVLdFY1nZOh4U711P4MpB62mfx43Lx6J8SzYpbaubU0D9Tpr8/uwXoWZ6ZHy3p0hCCaNf9eH5YFFCTdLrzJlq7/RZE1dy+Gzu6qhkT9ZIA36AmnYOx42cYvgEVT7KF/LQBDOYdlm/gQ1IZ8eCMV4CRjl60BZyp3L8WH85XElcxJ0dDV2SqyXBlpwzLVw4DlzZwY3FEkfQzhutJ0d5rG6w7qWFt5RTRwYfakamwC1BNbCAmDG6Cmf1TKL9CrlUNnxJGtWMWWdmeeVBRCEdMZeQQ+BXDBvdlxkpmpyCBY7PcbkVLqCBi9QIbF6ofGvKZ0a3pYNBNEQrY2FLr5wU0j4qBpYTbyKoOLwm9eSh2MnxMJTeCLglXpjWW+oywIaxD6MfBcufAFA== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(39860400002)(346002)(136003)(396003)(376002)(230922051799003)(82310400011)(186009)(64100799003)(451199024)(1800799012)(36840700001)(40470700004)(46966006)(82740400003)(47076005)(81166007)(36756003)(356005)(8936002)(6666004)(8676002)(6916009)(316002)(83380400001)(36860700001)(40460700003)(40480700001)(2906002)(4744005)(336012)(426003)(86362001)(44832011)(4326008)(478600001)(5660300002)(26005)(16526019)(70586007)(2616005)(70206006)(41300700001)(1076003)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 19:33:11.8970 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b803c0f5-1b2a-4ddb-c0dd-08dc2425cb1b X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS1PEPF00017090.namprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR12MB8374 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The receive side will enable scatter-gather if required based on the mbuf size. If the client already enabled it in the config, it does not need to be enabled again. This reduces log output. Signed-off-by: Andrew Boyer --- drivers/net/ionic/ionic_lif.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ionic/ionic_lif.c b/drivers/net/ionic/ionic_lif.c index 25b490deb6..fe2112c057 100644 --- a/drivers/net/ionic/ionic_lif.c +++ b/drivers/net/ionic/ionic_lif.c @@ -768,7 +768,8 @@ ionic_rx_qcq_alloc(struct ionic_lif *lif, uint32_t socket_id, uint32_t index, max_mtu = rte_le_to_cpu_32(lif->adapter->ident.lif.eth.max_mtu); /* If mbufs are too small to hold received packets, enable SG */ - if (max_mtu > hdr_seg_size) { + if (max_mtu > hdr_seg_size && + !(lif->features & IONIC_ETH_HW_RX_SG)) { IONIC_PRINT(NOTICE, "Enabling RX_OFFLOAD_SCATTER"); lif->eth_dev->data->dev_conf.rxmode.offloads |= RTE_ETH_RX_OFFLOAD_SCATTER;