From patchwork Fri Feb 2 11:56:09 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gregory Etelson X-Patchwork-Id: 136316 X-Patchwork-Delegate: rasland@nvidia.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2175C43A4F; Fri, 2 Feb 2024 12:56:56 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 9C03C40A7A; Fri, 2 Feb 2024 12:56:52 +0100 (CET) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2056.outbound.protection.outlook.com [40.107.220.56]) by mails.dpdk.org (Postfix) with ESMTP id 0A68640A70 for ; Fri, 2 Feb 2024 12:56:51 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=L9/IQOtEtd59zD3u9wcRttpwmsBx4GXd5WglsHSssrsJtqCV4CwKLnKOedd55apn5bBwSP/qE4xJHg6G5T7KXx9B4Ub87zXlr/ZWsfPb9CuJ84SEIFEgTbcSA3w9bL3veRD659MVgNCZ1y0MtnL65GcCShEwMLpl3hs9mGKGcoH/jZNzbwMXaJrcnYsnkgFCoV+zv+qUfNnWN9t/PO2tOZeTk2s7KXxLWuvxFc6eO+EOQ2Jp6pQ7Utx+MFro5tzlRCSYSJUMowHcjv40bb3bUee3rFaqp5b3DiOBQ05pLywuHhpJ5LGp/hF/AABOBVge93BwOeFAkB04CHpHTGTvPA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=B3B3etSkVAQ+HPI1OE4VhEc0+MqqVZ0OPbXZcKsx/QQ=; b=Uy2dbtY0hTKUOKoABahFUC2LFpdfHsNtiolGEXmh3EAl1rNGGf7G1XgKFUd+IbUDeTQyRVEXdYiBF7XzB1GxMNV8u3EW2CB3Cxs/Dni5/H9fBuMz7Nx2ZzS/C+p85xODB/H0TqFooTqDHAKL9kYWUENJtWCg2w+GZhKv81SAPXvJmExFjmqRBYUvAFh7jFdOoMD/sYRGdqIFp8sz0aW8N+4sL/yVRUqgOOlJWWKRm4KSJpcieLfDB+KfOT2Z8ouGKs2CDO4e9IPa6yvW9lSnV2CbAs/5j4Fn9F6spqAkaq7UE8Dvk9jlJtbZfbKQjnf5CoWPXOcVjRLG0ajYIe30Uw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com; dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=B3B3etSkVAQ+HPI1OE4VhEc0+MqqVZ0OPbXZcKsx/QQ=; b=o5d9vo8UeBHt6S4NU3az5jQvAlizjwL58KOyO45nGL787zu4t+nHzr2HFV2DHSRNhyQWRToPpkWQBOtefLZZ8vuRFdk69bfs+uAv/+nR5UYLY3F6IytDKP9z80idqK+oQ88lWaP0cD1OdvV0BvV5qkqqIrVrzz5g8BygtFiOdSOnb/aAa+TuCDDIGlxrITYqS9hhp5bkb74d9N8zF5O2BeNgIgn30yjMnwYg6luokZ2UP7OtyPNBoWwwUUxy6N4PkiPF+daBEfEnsP8o6HEeAOoq5r1wLJ7yfwfcYWss574M1YQ/rLxB2luBpGq22SpsQZjjH/4zeM/zBfl0/lvgqg== Received: from CH0PR03CA0432.namprd03.prod.outlook.com (2603:10b6:610:10e::20) by CY5PR12MB9055.namprd12.prod.outlook.com (2603:10b6:930:35::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7270.9; Fri, 2 Feb 2024 11:56:47 +0000 Received: from CH2PEPF00000099.namprd02.prod.outlook.com (2603:10b6:610:10e:cafe::a6) by CH0PR03CA0432.outlook.office365.com (2603:10b6:610:10e::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.29 via Frontend Transport; Fri, 2 Feb 2024 11:56:47 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 216.228.117.161) smtp.mailfrom=nvidia.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=nvidia.com; Received-SPF: Pass (protection.outlook.com: domain of nvidia.com designates 216.228.117.161 as permitted sender) receiver=protection.outlook.com; client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C Received: from mail.nvidia.com (216.228.117.161) by CH2PEPF00000099.mail.protection.outlook.com (10.167.244.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7249.19 via Frontend Transport; Fri, 2 Feb 2024 11:56:46 +0000 Received: from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 2 Feb 2024 03:56:38 -0800 Received: from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Fri, 2 Feb 2024 03:56:34 -0800 From: Gregory Etelson To: CC: , =?utf-8?b?wqA=?= , , , Dariusz Sosnowski , Viacheslav Ovsiienko , "Ori Kam" , Suanming Mou , Matan Azrad , Rongwei Liu Subject: [PATCH 3/5] net/mlx5: fix parameters verification in HWS table create Date: Fri, 2 Feb 2024 13:56:09 +0200 Message-ID: <20240202115611.288892-4-getelson@nvidia.com> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240202115611.288892-1-getelson@nvidia.com> References: <20240202115611.288892-1-getelson@nvidia.com> MIME-Version: 1.0 X-Originating-IP: [10.126.231.35] X-ClientProxiedBy: rnnvmail202.nvidia.com (10.129.68.7) To rnnvmail201.nvidia.com (10.129.68.8) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PEPF00000099:EE_|CY5PR12MB9055:EE_ X-MS-Office365-Filtering-Correlation-Id: b66e7f38-7e05-450a-2b83-08dc23e60848 X-LD-Processed: 43083d15-7273-40c1-b7db-39efd9ccc17a,ExtAddr X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: mC/pJKR7D2/UhpdM12Kd5WI0k2bruZ8zv39WuRelGHFV1y2Ywo7Wa/UYKYJ/PdIPm7w761IxdT7gqoJEwSofbIg/Ih2GKUfq5FFUTl7ogvKCgRjjtNxNtAANoY8z9YfdHSxm2AlB7GTMfL6myCtxDkG6M/FDEvaF9jTun7aFS6MW5ZfNn7Vr84CgAwyVkdPsrzORKxSase/LZxtoevmD90LsoBryQ+IIasULdwd37nayMb1RJWrC2LvxjuYw+p0J5WfIP62yLC4X+1J6u2hMAV7t6SpMbHPh2bd+DByMeS5jtTrAth11TAWzHzJDhuYPrv/N5TAJuLelLt+W6Mz77nrld0a9eQ60C0YyAXA2h2riVi+G9J4OyC5RD1FU3uDxeyjmOgVBQA1MjdnGvBUTB5RHznhPG36qxQKJsOA/f2YiqRzoJACvkZV4HMibgRhtNN/17PTDMHNfbzvn4RPm77y5Gdw7A5wj4WXfrtttQr3Dt4WBhOOMT63o9y+OjWAOB5Ld0B89ieiN06uJkd7sYEOp+G1Smp/BlB/PUuuv/TyM6y3fc/b6Vic4trXV970xWTmwqHNAqbITxynXekd9/lAOu8E0+xW/HroX3yMmIVgxSevTITmAWS9PC79BHy1MmEyLvgwrfaQbrt+l48PKVzeDmTrtxApzRnbNKFqY46ReicLzfH+AmtNS/vsNdFsWZHwA9izRwAgfIrxe03zaC+uycJB5+VUwX4zegT8ep4VCG1KUD3OsiITdUO2Y3AO6 X-Forefront-Antispam-Report: CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE; SFS:(13230031)(4636009)(376002)(136003)(346002)(396003)(39860400002)(230922051799003)(186009)(451199024)(82310400011)(64100799003)(1800799012)(46966006)(40470700004)(36840700001)(41300700001)(82740400003)(70586007)(8676002)(70206006)(4326008)(8936002)(2906002)(5660300002)(86362001)(36756003)(316002)(54906003)(6916009)(36860700001)(356005)(6666004)(7696005)(478600001)(7636003)(47076005)(83380400001)(336012)(6286002)(426003)(16526019)(2616005)(26005)(40460700003)(1076003)(55016003)(107886003)(40480700001); DIR:OUT; SFP:1101; X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Feb 2024 11:56:46.6603 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: b66e7f38-7e05-450a-2b83-08dc23e60848 X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161]; Helo=[mail.nvidia.com] X-MS-Exchange-CrossTenant-AuthSource: CH2PEPF00000099.namprd02.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB9055 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Modified the conditionals in `flow_hw_table_create()` to use bitwise AND instead of equality checks when assessing `table_cfg->attr->specialize` bitmask. This will allow for greater flexibility as the bitmask may encapsulate multiple flags. The patch maintains the previous behavior with single flag values, while providing support for multiple flags. Fixes: 592d5367b5e4 ("net/mlx5: enable hint in async flow table") Signed-off-by: Gregory Etelson --- drivers/net/mlx5/mlx5_flow_hw.c | 23 +++++++++++++++++------ 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c index da873ae2e2..3125500641 100644 --- a/drivers/net/mlx5/mlx5_flow_hw.c +++ b/drivers/net/mlx5/mlx5_flow_hw.c @@ -4368,12 +4368,23 @@ flow_hw_table_create(struct rte_eth_dev *dev, matcher_attr.rule.num_log = rte_log2_u32(nb_flows); /* Parse hints information. */ if (attr->specialize) { - if (attr->specialize == RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_WIRE_ORIG) - matcher_attr.optimize_flow_src = MLX5DR_MATCHER_FLOW_SRC_WIRE; - else if (attr->specialize == RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_VPORT_ORIG) - matcher_attr.optimize_flow_src = MLX5DR_MATCHER_FLOW_SRC_VPORT; - else - DRV_LOG(INFO, "Unsupported hint value %x", attr->specialize); + uint32_t val = RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_WIRE_ORIG | + RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_VPORT_ORIG; + + if ((attr->specialize & val) == val) { + DRV_LOG(INFO, "Invalid hint value %x", + attr->specialize); + rte_errno = EINVAL; + goto it_error; + } + if (attr->specialize & + RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_WIRE_ORIG) + matcher_attr.optimize_flow_src = + MLX5DR_MATCHER_FLOW_SRC_WIRE; + else if (attr->specialize & + RTE_FLOW_TABLE_SPECIALIZE_TRANSFER_VPORT_ORIG) + matcher_attr.optimize_flow_src = + MLX5DR_MATCHER_FLOW_SRC_VPORT; } /* Build the item template. */ for (i = 0; i < nb_item_templates; i++) {