From patchwork Thu Feb 1 10:02:19 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Harman Kalra X-Patchwork-Id: 136254 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E372843A35; Thu, 1 Feb 2024 11:02:39 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4D2042DED; Thu, 1 Feb 2024 11:02:39 +0100 (CET) Received: from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com [67.231.148.174]) by mails.dpdk.org (Postfix) with ESMTP id 0456F42DEC for ; Thu, 1 Feb 2024 11:02:38 +0100 (CET) Received: from pps.filterd (m0045849.ppops.net [127.0.0.1]) by mx0a-0016f401.pphosted.com (8.17.1.24/8.17.1.24) with ESMTP id 4117LFl0027003 for ; Thu, 1 Feb 2024 02:02:38 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-type; s=pfpt0220; bh=YvV5PGqsmVJ7UO7Ed00VS W9ZPTNyEyrnq8a/MnrLb6Y=; b=gA1JoPfTioDzAUZ/XC+AI7gmfMWksLUCIanDa 7NzdOJDCn2sHJYJZvsgyjtd+19+mYjrUXt39bfSiPThJeBWwigFA2Ut5v00mxJUg 29YgwiUBkkROrLjKk7jX1ky7b97jFcdysA+xUgOgJJcI0bSGZB6t6Q+oOuzVeHUz wDTdTQDlvGXktt0ztYtZa50f7YVYJeXbV7gSSzVxfMGMSW/3oSFnRB+PmS/Ofhwf C8A5u387m1Zs+E1iI53AXUWJIcM+GvPyiGM/u+EP+IiI4OIBMRaOZ0tcAbq6G1do bEwyNEfzn48Lb9TLVRczkQXFd1U9y0Z7kqzY5y7+LFW6nkXZQ== Received: from dc5-exch01.marvell.com ([199.233.59.181]) by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3w06u8gf2r-2 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT) for ; Thu, 01 Feb 2024 02:02:38 -0800 (PST) Received: from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48; Thu, 1 Feb 2024 02:02:35 -0800 Received: from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend Transport; Thu, 1 Feb 2024 02:02:35 -0800 Received: from localhost.localdomain (unknown [10.29.52.211]) by maili.marvell.com (Postfix) with ESMTP id BFDD23F7044; Thu, 1 Feb 2024 02:02:34 -0800 (PST) From: Harman Kalra To: CC: , Harman Kalra Subject: [PATCH v5 2/2] test/devargs: add eth devargs parse cases Date: Thu, 1 Feb 2024 15:32:19 +0530 Message-ID: <20240201100219.26677-3-hkalra@marvell.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20240201100219.26677-1-hkalra@marvell.com> References: <20240111064432.193119-1-hkalra@marvell.com> <20240201100219.26677-1-hkalra@marvell.com> MIME-Version: 1.0 X-Proofpoint-GUID: TIQaDdfYb9-LTjkLOadOD_AGYKFuo7xp X-Proofpoint-ORIG-GUID: TIQaDdfYb9-LTjkLOadOD_AGYKFuo7xp X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26 definitions=2024-01-31_10,2024-01-31_01,2023-05-22_02 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Adding new eth devargs parsing test cases which can demonstrate valid and invalid usage of devargs patterns. Signed-off-by: Harman Kalra --- app/test/test_devargs.c | 107 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 107 insertions(+) diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c index f977d44448..4166b2bea2 100644 --- a/app/test/test_devargs.c +++ b/app/test/test_devargs.c @@ -6,6 +6,7 @@ #include #include +#include #include #include #include @@ -201,6 +202,106 @@ test_invalid_devargs(void) return fail; } +struct devargs_parse_case { + const char *devargs; + uint8_t devargs_count; +}; + +static int +test_valid_devargs_parsing(void) +{ + static const struct devargs_parse_case list[] = { + /* Single representors patterns */ + {"representor=1", 1}, + {"representor=[1,2,3]", 1}, + {"representor=[0-3,5,7]", 1}, + {"representor=vf[0-1]", 1}, + {"representor=sf[0-1]", 1}, + {"representor=pf1vf[0-1]", 1}, + {"representor=pf[0-1]vf[1-2]", 1}, + {"representor=pf[0-1]sf[1-2]", 1}, + {"representor=c0pf[0-1]", 1}, + {"representor=sf[1,2]vf[2]", 1}, /* Only SF ports will be represented */ + {"representor=vf2sf[1-2]", 1}, /* Only VF ports will be represented */ + {"representor=c[0-1]pf[0-1]vf[1-2]", 1}, + /* Single devarg inside multiple representor pattern */ + {"representor=[c[0-1]pf[0-1]vf[1-2]]", 1}, + /* Multiple representors patterns */ + {"representor=[vf0,3]", 2}, + {"representor=[vf0,vf1]", 2}, + {"representor=[vf[0],vf[1]]", 2}, + {"representor=[vf[0,1],3]", 2}, + {"representor=[vf[0,1],[3]]", 2}, + {"representor=[pf1vf[0-1],3]", 2}, + {"representor=[pf1vf[0-1],pf[0-1]]", 2}, + {"representor=[pf1,pf3,pf1vf[0-1],vf[0],vf[1],vf0,vf1,vf2]", 8}, + {"representor=[1,3,5,pf1,pf2,pf3,pf1vf[0-1],vf[0],vf[1],vf0,vf1,vf2]", 12}, + {"representor=[[1,3,5],pf1,pf2,pf3,pf1vf[0-1],vf[0],vf[1],vf0,vf1,vf2]", 10}, + {"representor=[c[0,2-4]pf[1,6]vf[0-1],vf[0],vf4,[3-5,7],pf1vf[0-1,6],pf[2,4,6]]", 6} + }; + struct rte_eth_devargs eth_da[RTE_MAX_ETHPORTS]; + uint32_t i; + int ret; + int fail = 0; + + for (i = 0; i < RTE_DIM(list); i++) { + memset(eth_da, 0, RTE_MAX_ETHPORTS * sizeof(*eth_da)); + ret = rte_eth_devargs_parse(list[i].devargs, eth_da, RTE_MAX_ETHPORTS); + if (ret <= 0) { + printf("rte_devargs_parse(%s) returned %d (but should not)\n", + list[i].devargs, ret); + fail = ret; + break; + } + + /* Check the return value, count should be equivalent to no of devargs. */ + if (ret != list[i].devargs_count) { + printf("Devargs returned count %d != expected count %d\n", ret, + list[i].devargs_count); + fail = -1; + break; + } + } + return fail; +} + +static int +test_invalid_devargs_parsing(void) +{ + static const char * const list[] = { + "representor=1,2,3,4", /* Out [] missing */ + "representor=[1 2 3]", /* , missing */ + "representor=c[1,2]", /* Only controller no valid */ + "representor=c0vf[0-1]", /* Controller with vf alone not valid */ + "representor=c0sf[0-1]", /* Controller with sf alone not valid */ + "representor=vf[0-1],vf3", /* Out [] missing */ + "representor=[[vf0,3]]", /* Double [] is invalid */ + "representor=pfvf[1-2]", /* No PF index provided */ + "representor=pf1[vf[1-2]]", /* Additional [] across vf */ + "representor=c0[pf1vf[1-2]]", /* Additional [] across pfvf */ + "representor=c0[pf1[vf[1-2]]]", /* Additional [] across pfvf */ + "representor=[pf1vf[0-1], pf[0-1]]", /* Space between two devargs is invalid */ + "representor=[pf1vf[0-1], 3]", /* Space between two devargs is invalid */ + "representor=pf1vf[1-2],representor=1", /* Multiple representor keys */ + }; + struct rte_eth_devargs eth_da[RTE_MAX_ETHPORTS]; + uint32_t i; + int ret; + int fail = 0; + + for (i = 0; i < RTE_DIM(list); i++) { + memset(eth_da, 0, RTE_MAX_ETHPORTS * sizeof(*eth_da)); + ret = rte_eth_devargs_parse(list[i], eth_da, RTE_MAX_ETHPORTS); + if (ret > 0) { + printf("rte_devargs_parse(%s) returned %d (but should not)\n", + list[i], ret); + fail = ret; + break; + } + } + return fail; +} + static int test_devargs(void) { @@ -210,6 +311,12 @@ test_devargs(void) printf("== test invalid case ==\n"); if (test_invalid_devargs() < 0) return -1; + printf("== test devargs parsing valid case ==\n"); + if (test_valid_devargs_parsing() < 0) + return -1; + printf("== test devargs parsing invalid case ==\n"); + if (test_invalid_devargs_parsing() < 0) + return -1; return 0; }