[v4,6/7] net/gve: update gve.ini with RSS capabilities

Message ID 20240126173317.2779230-7-joshwash@google.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series [v4,1/7] net/gve: fully expose RSS offload support in dev_info |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Joshua Washington Jan. 26, 2024, 5:33 p.m. UTC
  This patch updates the DPDK feature matrix to expose that the GVE driver
supports RSS hash, RSS key update, and RSS reta update.

Signed-off-by: Joshua Washington <joshwash@google.com>
---
 doc/guides/nics/features/gve.ini | 3 +++
 1 file changed, 3 insertions(+)
  

Comments

Ferruh Yigit Jan. 31, 2024, 2:48 p.m. UTC | #1
On 1/26/2024 5:33 PM, Joshua Washington wrote:
> This patch updates the DPDK feature matrix to expose that the GVE driver
> supports RSS hash, RSS key update, and RSS reta update.
> 
> Signed-off-by: Joshua Washington <joshwash@google.com>
> ---
>  doc/guides/nics/features/gve.ini | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/features/gve.ini
> index 838edd456a..bc08648dbc 100644
> --- a/doc/guides/nics/features/gve.ini
> +++ b/doc/guides/nics/features/gve.ini
> @@ -15,3 +15,6 @@ Linux                = Y
>  x86-32               = Y
>  x86-64               = Y
>  Usage doc            = Y
> +RSS hash             = Y
> +RSS key update       = Y
> +RSS reta update      = Y

Please distribute this patch to other patches, each update can go to the
patch that adds the support.

Please keep the order of capabilities above same as order in default.ini
  
Ferruh Yigit Jan. 31, 2024, 2:55 p.m. UTC | #2
On 1/31/2024 2:48 PM, Ferruh Yigit wrote:
> On 1/26/2024 5:33 PM, Joshua Washington wrote:
>> This patch updates the DPDK feature matrix to expose that the GVE driver
>> supports RSS hash, RSS key update, and RSS reta update.
>>
>> Signed-off-by: Joshua Washington <joshwash@google.com>
>> ---
>>  doc/guides/nics/features/gve.ini | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/features/gve.ini
>> index 838edd456a..bc08648dbc 100644
>> --- a/doc/guides/nics/features/gve.ini
>> +++ b/doc/guides/nics/features/gve.ini
>> @@ -15,3 +15,6 @@ Linux                = Y
>>  x86-32               = Y
>>  x86-64               = Y
>>  Usage doc            = Y
>> +RSS hash             = Y
>> +RSS key update       = Y
>> +RSS reta update      = Y
> 
> Please distribute this patch to other patches, each update can go to the
> patch that adds the support.
> 
> Please keep the order of capabilities above same as order in default.ini
>

btw, "RSS hash" seems duplicated.
  

Patch

diff --git a/doc/guides/nics/features/gve.ini b/doc/guides/nics/features/gve.ini
index 838edd456a..bc08648dbc 100644
--- a/doc/guides/nics/features/gve.ini
+++ b/doc/guides/nics/features/gve.ini
@@ -15,3 +15,6 @@  Linux                = Y
 x86-32               = Y
 x86-64               = Y
 Usage doc            = Y
+RSS hash             = Y
+RSS key update       = Y
+RSS reta update      = Y