[1/2] drivers: remove unnecessary RTE_LOG_DP macros

Message ID 20240124162917.59851-2-stephen@networkplumber.org (mailing list archive)
State Accepted, archived
Delegated to: David Marchand
Headers
Series RTE_LOG_DP cleanups |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Jan. 24, 2024, 4:28 p.m. UTC
  Several drivers did copy/paste of log macros for datapath
but are not using them, so remove them.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/bus/cdx/cdx_logs.h                | 11 -----------
 drivers/bus/fslmc/fslmc_logs.h            | 11 -----------
 drivers/common/dpaax/dpaax_logs.h         | 11 -----------
 drivers/event/dpaa2/dpaa2_eventdev_logs.h | 11 -----------
 4 files changed, 44 deletions(-)
  

Comments

Tyler Retzlaff Jan. 24, 2024, 6:07 p.m. UTC | #1
On Wed, Jan 24, 2024 at 08:28:34AM -0800, Stephen Hemminger wrote:
> Several drivers did copy/paste of log macros for datapath
> but are not using them, so remove them.
> 
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---

Acked-by: Tyler Retzlaff <roretzla@linux.microsoft.com>
  
David Marchand Feb. 1, 2024, 9:33 a.m. UTC | #2
On Wed, Jan 24, 2024 at 5:29 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> Several drivers did copy/paste of log macros for datapath
> but are not using them, so remove them.
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>

I applied this first patch for now.
Thanks.
  

Patch

diff --git a/drivers/bus/cdx/cdx_logs.h b/drivers/bus/cdx/cdx_logs.h
index a1046ce544a6..0ec39e9dd489 100644
--- a/drivers/bus/cdx/cdx_logs.h
+++ b/drivers/bus/cdx/cdx_logs.h
@@ -23,15 +23,4 @@  extern int cdx_logtype_bus;
 #define CDX_BUS_WARN(fmt, args...) \
 	CDX_BUS_LOG(WARNING, fmt, ## args)
 
-/* DP Logs, toggled out at compile time if level lower than current level */
-#define CDX_BUS_DP_LOG(level, fmt, args...) \
-	RTE_LOG_DP(level, PMD, fmt, ## args)
-
-#define CDX_BUS_DP_DEBUG(fmt, args...) \
-	CDX_BUS_DP_LOG(DEBUG, fmt, ## args)
-#define CDX_BUS_DP_INFO(fmt, args...) \
-	CDX_BUS_DP_LOG(INFO, fmt, ## args)
-#define CDX_BUS_DP_WARN(fmt, args...) \
-	CDX_BUS_DP_LOG(WARNING, fmt, ## args)
-
 #endif /* CDX_LOGS_H */
diff --git a/drivers/bus/fslmc/fslmc_logs.h b/drivers/bus/fslmc/fslmc_logs.h
index a1e14dd84e9a..e15c603426b2 100644
--- a/drivers/bus/fslmc/fslmc_logs.h
+++ b/drivers/bus/fslmc/fslmc_logs.h
@@ -25,15 +25,4 @@  extern int dpaa2_logtype_bus;
 #define DPAA2_BUS_WARN(fmt, args...) \
 	DPAA2_BUS_LOG(WARNING, fmt, ## args)
 
-/* DP Logs, toggled out at compile time if level lower than current level */
-#define DPAA2_BUS_DP_LOG(level, fmt, args...) \
-	RTE_LOG_DP(level, PMD, fmt, ## args)
-
-#define DPAA2_BUS_DP_DEBUG(fmt, args...) \
-	DPAA2_BUS_DP_LOG(DEBUG, fmt, ## args)
-#define DPAA2_BUS_DP_INFO(fmt, args...) \
-	DPAA2_BUS_DP_LOG(INFO, fmt, ## args)
-#define DPAA2_BUS_DP_WARN(fmt, args...) \
-	DPAA2_BUS_DP_LOG(WARNING, fmt, ## args)
-
 #endif /* _FSLMC_LOGS_H_ */
diff --git a/drivers/common/dpaax/dpaax_logs.h b/drivers/common/dpaax/dpaax_logs.h
index 180476f6757c..f667aaff72fd 100644
--- a/drivers/common/dpaax/dpaax_logs.h
+++ b/drivers/common/dpaax/dpaax_logs.h
@@ -35,15 +35,4 @@  extern int dpaax_logger;
 #define DPAAX_WARN(fmt, args...) \
 	DPAAX_LOG(WARNING, fmt, ## args)
 
-/* DP Logs, toggled out at compile time if level lower than current level */
-#define DPAAX_DP_LOG(level, fmt, args...) \
-	RTE_LOG_DP(level, PMD, fmt, ## args)
-
-#define DPAAX_DP_DEBUG(fmt, args...) \
-	DPAAX_DP_LOG(DEBUG, fmt, ## args)
-#define DPAAX_DP_INFO(fmt, args...) \
-	DPAAX_DP_LOG(INFO, fmt, ## args)
-#define DPAAX_DP_WARN(fmt, args...) \
-	DPAAX_DP_LOG(WARNING, fmt, ## args)
-
 #endif /* _DPAAX_LOGS_H_ */
diff --git a/drivers/event/dpaa2/dpaa2_eventdev_logs.h b/drivers/event/dpaa2/dpaa2_eventdev_logs.h
index 66c8c772740d..b894fb32996a 100644
--- a/drivers/event/dpaa2/dpaa2_eventdev_logs.h
+++ b/drivers/event/dpaa2/dpaa2_eventdev_logs.h
@@ -24,17 +24,6 @@  extern int dpaa2_logtype_event;
 #define DPAA2_EVENTDEV_WARN(fmt, args...) \
 	DPAA2_EVENTDEV_LOG(WARNING, fmt, ## args)
 
-/* DP Logs, toggled out at compile time if level lower than current level */
-#define DPAA2_EVENTDEV_DP_LOG(level, fmt, args...) \
-	RTE_LOG_DP(level, PMD, fmt, ## args)
-
-#define DPAA2_EVENTDEV_DP_DEBUG(fmt, args...) \
-	DPAA2_EVENTDEV_DP_LOG(DEBUG, fmt, ## args)
-#define DPAA2_EVENTDEV_DP_INFO(fmt, args...) \
-	DPAA2_EVENTDEV_DP_LOG(INFO, fmt, ## args)
-#define DPAA2_EVENTDEV_DP_WARN(fmt, args...) \
-	DPAA2_EVENTDEV_DP_LOG(WARNING, fmt, ## args)
-
 #define dpaa2_evdev_info(fmt, ...) DPAA2_EVENTDEV_LOG(INFO, fmt, ##__VA_ARGS__)
 #define dpaa2_evdev_dbg(fmt, ...) DPAA2_EVENTDEV_LOG(DEBUG, fmt, ##__VA_ARGS__)
 #define dpaa2_evdev_err(fmt, ...) DPAA2_EVENTDEV_LOG(ERR, fmt, ##__VA_ARGS__)