diff mbox series

[v2,1/2] config/arm: allow WFE to be enabled config time

Message ID 20240117142600.1889-1-pbhagavatula@marvell.com (mailing list archive)
State Superseded, archived
Headers
Series [v2,1/2] config/arm: allow WFE to be enabled config time |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Pavan Nikhilesh Bhagavatula Jan. 17, 2024, 2:25 p.m. UTC 
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Allow RTE_ARM_USE_WFE to be enabled at meson configuration
time by passing it via c_args instead of modifying
`config/arm/meson.build`.

Example usage:
 meson build -Dc_args='-DRTE_ARM_USE_WFE' \
	--cross-file config/arm/arm64_cn10k_linux_gcc

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 config/arm/meson.build | 1 -
 1 file changed, 1 deletion(-)

Comments

Ruifeng Wang Jan. 18, 2024, 1:52 a.m. UTC | #1 
On 2024/1/17 10:25 PM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Allow RTE_ARM_USE_WFE to be enabled at meson configuration
> time by passing it via c_args instead of modifying
> `config/arm/meson.build`.
> 
> Example usage:
>   meson build -Dc_args='-DRTE_ARM_USE_WFE' \
> 	--cross-file config/arm/arm64_cn10k_linux_gcc
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>   config/arm/meson.build | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/config/arm/meson.build b/config/arm/meson.build
> index 36f21d2259..a63711e986 100644
> --- a/config/arm/meson.build
> +++ b/config/arm/meson.build
> @@ -17,7 +17,6 @@ flags_common = [
>           #    ['RTE_ARM64_MEMCPY_ALIGN_MASK', 0xF],
>           #    ['RTE_ARM64_MEMCPY_STRICT_ALIGN', false],
>   
> -        ['RTE_ARM_USE_WFE', false],

What about commenting this line out instead?
It will be easier to track the configurables.

>           ['RTE_ARCH_ARM64', true],
>           ['RTE_CACHE_LINE_SIZE', 128]
>   ]
diff mbox series

Patch

diff --git a/config/arm/meson.build b/config/arm/meson.build
index 36f21d2259..a63711e986 100644
--- a/config/arm/meson.build
+++ b/config/arm/meson.build
@@ -17,7 +17,6 @@  flags_common = [
         #    ['RTE_ARM64_MEMCPY_ALIGN_MASK', 0xF],
         #    ['RTE_ARM64_MEMCPY_STRICT_ALIGN', false],
 
-        ['RTE_ARM_USE_WFE', false],
         ['RTE_ARCH_ARM64', true],
         ['RTE_CACHE_LINE_SIZE', 128]
 ]