[1/2] config/arm: fix CN10K minimum march requirement

Message ID 20240104091830.3245-1-pbhagavatula@marvell.com (mailing list archive)
State Rejected, archived
Delegated to: Thomas Monjalon
Headers
Series [1/2] config/arm: fix CN10K minimum march requirement |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Pavan Nikhilesh Bhagavatula Jan. 4, 2024, 9:18 a.m. UTC
  From: Pavan Nikhilesh <pbhagavatula@marvell.com>

Meson selects march and mcpu based on compiler support and
partnumber, only the minimum required march should be defined
in cross compile configuration file.

Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K")
Cc: stable@dpdk.org

Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
---
 config/arm/arm64_cn10k_linux_gcc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
  

Comments

Ruifeng Wang Jan. 18, 2024, 2:02 a.m. UTC | #1
On 2024/1/4 5:18 PM, pbhagavatula@marvell.com wrote:
> From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> 
> Meson selects march and mcpu based on compiler support and
> partnumber, only the minimum required march should be defined
> in cross compile configuration file.
> 
> Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> ---
>   config/arm/arm64_cn10k_linux_gcc | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/config/arm/arm64_cn10k_linux_gcc b/config/arm/arm64_cn10k_linux_gcc
> index fa904af5d0..801a7ededd 100644
> --- a/config/arm/arm64_cn10k_linux_gcc
> +++ b/config/arm/arm64_cn10k_linux_gcc
> @@ -10,7 +10,7 @@ cmake = 'cmake'
>   [host_machine]
>   system = 'linux'
>   cpu_family = 'aarch64'
> -cpu = 'armv8.6-a'
> +cpu = 'armv8-a'
>   endian = 'little'
>   
>   [properties]

The host_machine.cpu in cross file doesn't take effect.
There is an effort to remove the confusion. Can you have a review?
https://patches.dpdk.org/project/dpdk/patch/20231205035259.3516625-3-joyce.kong@arm.com/
  
Pavan Nikhilesh Bhagavatula Jan. 19, 2024, 7:42 p.m. UTC | #2
> -----Original Message-----
> From: Ruifeng Wang <Ruifeng.Wang@arm.com>
> Sent: Thursday, January 18, 2024 7:32 AM
> To: Pavan Nikhilesh Bhagavatula <pbhagavatula@marvell.com>; Jerin Jacob
> <jerinj@marvell.com>; Bruce Richardson <bruce.richardson@intel.com>
> Cc: dev@dpdk.org; stable@dpdk.org; nd@arm.com
> Subject: [EXT] Re: [PATCH 1/2] config/arm: fix CN10K minimum march
> requirement
> 
> External Email
> 
> ----------------------------------------------------------------------
> 
> On 2024/1/4 5:18 PM, pbhagavatula@marvell.com wrote:
> > From: Pavan Nikhilesh <pbhagavatula@marvell.com>
> >
> > Meson selects march and mcpu based on compiler support and
> > partnumber, only the minimum required march should be defined
> > in cross compile configuration file.
> >
> > Fixes: 1b4c86a721c9 ("config/arm: add Marvell CN10K")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Pavan Nikhilesh <pbhagavatula@marvell.com>
> > ---
> >   config/arm/arm64_cn10k_linux_gcc | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/config/arm/arm64_cn10k_linux_gcc
> b/config/arm/arm64_cn10k_linux_gcc
> > index fa904af5d0..801a7ededd 100644
> > --- a/config/arm/arm64_cn10k_linux_gcc
> > +++ b/config/arm/arm64_cn10k_linux_gcc
> > @@ -10,7 +10,7 @@ cmake = 'cmake'
> >   [host_machine]
> >   system = 'linux'
> >   cpu_family = 'aarch64'
> > -cpu = 'armv8.6-a'
> > +cpu = 'armv8-a'
> >   endian = 'little'
> >
> >   [properties]
> 
> The host_machine.cpu in cross file doesn't take effect.
> There is an effort to remove the confusion. Can you have a review?

I tested the patchset with cross as cn10k and they look good, I will drop this patch.

Thanks,
Pavan.

> https://urldefense.proofpoint.com/v2/url?u=https-
> 3A__patches.dpdk.org_project_dpdk_patch_20231205035259.3516625-2D3-
> 2Djoyce.kong-
> 40arm.com_&d=DwICaQ&c=nKjWec2b6R0mOyPaz7xtfQ&r=1cjuAHrGh745jH
> Nmj2fD85sUMIJ2IPIDsIJzo6FN6Z0&m=kvQolwCYorBpQ4nTOcW2ScJHHijEJtn
> QojGz8R6F6mWPl4nA-
> gIVpBLkzjAFCIpR&s=Huq9MHONkc50v4UTZtcmyIwY2tD3iFSMrZGuo_PvWSU
> &e=
  

Patch

diff --git a/config/arm/arm64_cn10k_linux_gcc b/config/arm/arm64_cn10k_linux_gcc
index fa904af5d0..801a7ededd 100644
--- a/config/arm/arm64_cn10k_linux_gcc
+++ b/config/arm/arm64_cn10k_linux_gcc
@@ -10,7 +10,7 @@  cmake = 'cmake'
 [host_machine]
 system = 'linux'
 cpu_family = 'aarch64'
-cpu = 'armv8.6-a'
+cpu = 'armv8-a'
 endian = 'little'
 
 [properties]