From patchwork Wed Dec 27 04:21:07 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135594 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B514D437A1; Wed, 27 Dec 2023 05:22:20 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47F14406B4; Wed, 27 Dec 2023 05:21:39 +0100 (CET) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id 6A60E402E5 for ; Wed, 27 Dec 2023 05:21:34 +0100 (CET) Received: by mail-qt1-f175.google.com with SMTP id d75a77b69052e-427eae54dd3so3132351cf.1 for ; Tue, 26 Dec 2023 20:21:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703650893; x=1704255693; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=XlFgpTM/a1tDaGPVG6jGSu5fNth8/CiT4Ewyb9iY2fU=; b=KWMBlcnyrafjVwCqrr3GevdjGVtY/VXXYv/3zxBze25BflPIIxNhwAv5YoR2/kkXBP GYJYU9BRfZDxlUB0imZ1Z5BQ7BVwmAOqz+IQ9LGME1fwlsi8YktK4TbMYwueZTbISPOT nAjXyJdyRUhZmnmirE0qpuVTKc/jCWPEZHEXE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703650893; x=1704255693; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XlFgpTM/a1tDaGPVG6jGSu5fNth8/CiT4Ewyb9iY2fU=; b=KrnDcMbCGLie4qBIpbbzlUASYwRn5+hN3MKh1bcZKwF8E/f94oFBKE9iWZaOwKt2fb Dsucs6EdGMGhR3E7mNXWJnhD49d6kRiWV/E4CxsJkuJ7DLnXrkjytovWZPFZQsYLYJBP UpoTAaM1WZ0s7dxSIEnUHNjzG2/QdBghl9aKM11c7c8X/Bd5rtNp7dkVyVtBNkHIrhts jlbGqoqAs0cJyZTDke4K6x/vkAJjfkTPf5d5wp2bCVe+7fHUKINRTkVES2HE5u23EQ9V hlsoIhZju4whJrefVLNI01OqrbvfkiFdTNGvYtDv3275NxrR6f5RbaimpxXr0bRQ91zo vjfA== X-Gm-Message-State: AOJu0YzfcF9eUityzL9/n+FxpzffU3GRkqhvFBh/1r4RdQe64xmubpGn NuV7UDRxrz2anmZN130DYx7N7nzildNtLMN9vNzBlzijmyESrF+Lbvg1NEew8xfsxwpev7jYYWJ CGQpzKHbpvzcktC/PPG0bhOu4mWfRg9HXFDS1L8OtQXy3mU+2PcTnUbCP+xsrGQS4rnY9v/e+sL o= X-Google-Smtp-Source: AGHT+IGjltdzpC4LR6xDpD+q7TfecSL1ASs0/dXmRImwkAmzyKTxaqMmMo5Tl4lOupXF/1vV8yF8GQ== X-Received: by 2002:a05:622a:55:b0:427:8319:16fa with SMTP id y21-20020a05622a005500b00427831916famr11746137qtw.15.1703650893387; Tue, 26 Dec 2023 20:21:33 -0800 (PST) Received: from localhost.localdomain ([2605:a601:a780:1400:c066:75e3:74c8:50e6]) by smtp.gmail.com with ESMTPSA id bt7-20020ac86907000000b00427e120889bsm1415488qtb.91.2023.12.26.20.21.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 26 Dec 2023 20:21:32 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kalesh AP , stable@dpdk.org Subject: [PATCH v3 06/18] net/bnxt: support backward compatibility Date: Tue, 26 Dec 2023 20:21:07 -0800 Message-Id: <20231227042119.72469-7-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231227042119.72469-1-ajit.khaparde@broadcom.com> References: <20231227042119.72469-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kalesh AP On older firmware versions, HWRM_FUNC_QCAPS response is not returning the maximum number of multicast filters that can be supported by the function. As a result, memory allocation with size 0 fails. Bugzilla ID: 1309 Cc: stable@dpdk.org Signed-off-by: Kalesh AP Reviewed-by: Ajit Khaparde --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_hwrm.c | 2 ++ 2 files changed, 3 insertions(+) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index cfdbfd3f54..cd85a944e8 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -974,6 +974,7 @@ struct bnxt { struct rte_ether_addr *mcast_addr_list; rte_iova_t mc_list_dma_addr; uint32_t nb_mc_addr; +#define BNXT_DFLT_MAX_MC_ADDR 16 /* for compatibility with older firmware */ uint32_t max_mcast_addr; /* maximum number of mcast filters supported */ struct rte_eth_rss_conf rss_conf; /* RSS configuration. */ diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index a1f3a8251f..d649f217ec 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -901,6 +901,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) bp->max_l2_ctx, bp->max_vnics); bp->max_stat_ctx = rte_le_to_cpu_16(resp->max_stat_ctx); bp->max_mcast_addr = rte_le_to_cpu_32(resp->max_mcast_filters); + if (!bp->max_mcast_addr) + bp->max_mcast_addr = BNXT_DFLT_MAX_MC_ADDR; memcpy(bp->dsn, resp->device_serial_number, sizeof(bp->dsn)); if (BNXT_PF(bp))