diff mbox series

[v6,05/20] net/dpaa2: used dedicated logtype not PMD

Message ID 20231222171820.8778-6-stephen@networkplumber.org (mailing list archive)
State Superseded, archived
Delegated to: Thomas Monjalon
Headers
Series Remove uses of PMD logtype |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

Stephen Hemminger Dec. 22, 2023, 5:11 p.m. UTC 
  The driver has a logtype, but was not being used in one place.

Fixes: f023d059769f ("net/dpaa2: support recycle loopback port")
Fixes: 72ec7a678e70 ("net/dpaa2: add soft parser driver")

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/dpaa2/dpaa2_ethdev.c  | 2 +-
 drivers/net/dpaa2/dpaa2_sparser.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

Comments

Jun Yang Dec. 23, 2023, 12:53 a.m. UTC | #1 
What is the log level of DPAA2_PMD_INFO? I expect to print information by this as default.

获取 Outlook for iOS<https://aka.ms/o0ukef>
________________________________
发件人: Stephen Hemminger <stephen@networkplumber.org>
发送时间: 星期六, 十二月 23, 2023 01:18
收件人: dev@dpdk.org <dev@dpdk.org>
抄送: Stephen Hemminger <stephen@networkplumber.org>; Hemant Agrawal <hemant.agrawal@nxp.com>; Sachin Saxena <sachin.saxena@nxp.com>; Jun Yang <jun.yang@nxp.com>
主题: [EXT] [PATCH v6 05/20] net/dpaa2: used dedicated logtype not PMD

Caution: This is an external email. Please take care when clicking links or opening attachments. When in doubt, report the message using the 'Report this email' button


The driver has a logtype, but was not being used in one place.

Fixes: f023d059769f ("net/dpaa2: support recycle loopback port")
Fixes: 72ec7a678e70 ("net/dpaa2: add soft parser driver")

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/dpaa2/dpaa2_ethdev.c  | 2 +-
 drivers/net/dpaa2/dpaa2_sparser.c | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 8e610b6bba30..91846fcd2f23 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -2851,7 +2851,7 @@ dpaa2_dev_init(struct rte_eth_dev *eth_dev)
                        return ret;
                }
        }
-       RTE_LOG(INFO, PMD, "%s: netdev created, connected to %s\n",
+       DPAA2_PMD_INFO("%s: netdev created, connected to %s",
                eth_dev->data->name, dpaa2_dev->ep_name);

        return 0;
diff --git a/drivers/net/dpaa2/dpaa2_sparser.c b/drivers/net/dpaa2/dpaa2_sparser.c
index 63463c4fbfd6..36a14526a5c5 100644
--- a/drivers/net/dpaa2/dpaa2_sparser.c
+++ b/drivers/net/dpaa2/dpaa2_sparser.c
@@ -181,7 +181,7 @@ int dpaa2_eth_load_wriop_soft_parser(struct dpaa2_dev_priv *priv,

        priv->ss_iova = (uint64_t)(DPAA2_VADDR_TO_IOVA(addr));
        priv->ss_offset += sp_param.size;
-       RTE_LOG(INFO, PMD, "Soft parser loaded for dpni@%d\n", priv->hw_id);
+       DPAA2_PMD_INFO("Soft parser loaded for dpni@%d", priv->hw_id);

        rte_free(addr);
        return 0;
@@ -234,6 +234,6 @@ int dpaa2_eth_enable_wriop_soft_parser(struct dpaa2_dev_priv *priv,
        }

        rte_free(param_addr);
-       RTE_LOG(INFO, PMD, "Soft parser enabled for dpni@%d\n", priv->hw_id);
+       DPAA2_PMD_INFO("Soft parser enabled for dpni@%d", priv->hw_id);
        return 0;
 }
--
2.43.0
Stephen Hemminger Dec. 23, 2023, 2:27 a.m. UTC | #2 
On Sat, 23 Dec 2023 00:53:51 +0000
Jun Yang <jun.yang@nxp.com> wrote:

> What is the log level of DPAA2_PMD_INFO? I expect to print information by this as default.
> 
> 获取 Outlook for iOS<https://aka.ms/o0ukef>

The default log level of DPAA2 is NOTICE
RTE_LOG_REGISTER_DEFAULT(dpaa2_logtype_pmd, NOTICE);

But there is no reason for drivers to be so chatty.
Log messages are something developers seem to want a lot.
But at scale they just add up to more noise to wade through.
diff mbox series

Patch

diff --git a/drivers/net/dpaa2/dpaa2_ethdev.c b/drivers/net/dpaa2/dpaa2_ethdev.c
index 8e610b6bba30..91846fcd2f23 100644
--- a/drivers/net/dpaa2/dpaa2_ethdev.c
+++ b/drivers/net/dpaa2/dpaa2_ethdev.c
@@ -2851,7 +2851,7 @@  dpaa2_dev_init(struct rte_eth_dev *eth_dev)
 			return ret;
 		}
 	}
-	RTE_LOG(INFO, PMD, "%s: netdev created, connected to %s\n",
+	DPAA2_PMD_INFO("%s: netdev created, connected to %s",
 		eth_dev->data->name, dpaa2_dev->ep_name);
 
 	return 0;
diff --git a/drivers/net/dpaa2/dpaa2_sparser.c b/drivers/net/dpaa2/dpaa2_sparser.c
index 63463c4fbfd6..36a14526a5c5 100644
--- a/drivers/net/dpaa2/dpaa2_sparser.c
+++ b/drivers/net/dpaa2/dpaa2_sparser.c
@@ -181,7 +181,7 @@  int dpaa2_eth_load_wriop_soft_parser(struct dpaa2_dev_priv *priv,
 
 	priv->ss_iova = (uint64_t)(DPAA2_VADDR_TO_IOVA(addr));
 	priv->ss_offset += sp_param.size;
-	RTE_LOG(INFO, PMD, "Soft parser loaded for dpni@%d\n", priv->hw_id);
+	DPAA2_PMD_INFO("Soft parser loaded for dpni@%d", priv->hw_id);
 
 	rte_free(addr);
 	return 0;
@@ -234,6 +234,6 @@  int dpaa2_eth_enable_wriop_soft_parser(struct dpaa2_dev_priv *priv,
 	}
 
 	rte_free(param_addr);
-	RTE_LOG(INFO, PMD, "Soft parser enabled for dpni@%d\n", priv->hw_id);
+	DPAA2_PMD_INFO("Soft parser enabled for dpni@%d", priv->hw_id);
 	return 0;
 }