From patchwork Thu Dec 21 18:05:12 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135476 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id B814D43752; Thu, 21 Dec 2023 19:05:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5826A42E59; Thu, 21 Dec 2023 19:05:39 +0100 (CET) Received: from mail-pl1-f172.google.com (mail-pl1-f172.google.com [209.85.214.172]) by mails.dpdk.org (Postfix) with ESMTP id 37E87402F0 for ; Thu, 21 Dec 2023 19:05:37 +0100 (CET) Received: by mail-pl1-f172.google.com with SMTP id d9443c01a7336-1d3e6c86868so8948855ad.1 for ; Thu, 21 Dec 2023 10:05:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1703181936; x=1703786736; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=IUh3Te6/tlwemJimPty9FXbBu9kflpvRKAttC5o/7IY=; b=QnWP6dCB0LlPqlopt/C//yvBlWVq726RTDqCYIWDEajjBcxF38VyGlZfXqvM8ffOzI PIg7IxqNgJM92pKrwcXLTufKQ5DWiX0bTjI87Gqp39oDhyZ1c97rgtF0O0l+T1MZZ1gt grwEmpPFGafAFa/iFstvmBvTixLYNpEcRseVc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703181936; x=1703786736; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IUh3Te6/tlwemJimPty9FXbBu9kflpvRKAttC5o/7IY=; b=Q7VrtmByQjKiTuFhnMvSyQTGPeVmO14GKyfnRFTI/4Vr6zklJml2pAXE/pcNMFIb8O EBQb+FgeJuK4OBzn6Nfccm27s1MV4SV9RmyZnZz9Is4s+w1d1wE7UR8It51wSqjtJ50J U8qxXpRt51gMUm7na2HbR/bvjn5eppYu7SpgwhQ5LpGInIAOSaepj2neCnumfyB05P+w al+v3foVfeItleJrsavVPAglheo/RE5OV6AmIw3lrcFnNGVl0WNhEdgoUpK199ipguPM Igu5pWKqEpLEVYUo7tsp8IikElXBMIjtxrDbGU+9dV0OU38lLJ5rmH83huF5Dy2BCE5e ez3A== X-Gm-Message-State: AOJu0Ywv8U8vCFUXu3EmjKlSaKylwsjXEUPSeZ29fGAE1senWwHp3KJq DJYxlrHWw+62XnygZXE1GVWGjrDNRx4CE3Ny/YsA1VTCfM3tqg9hQj/Af0z29G0jxqUT8pni+wd jOC8bLbofiJHtE0VTxeaj4Or6t28Tnwxe45LvacdZtr6724A/N/8sp9jM3m9wYmdPNXv4o2+Wwr 8= X-Google-Smtp-Source: AGHT+IHm1Tc/cX6SjRt4xwdbyzg976w/ojlqPBarig+kVCJSxRagQUXfiK1jozBGA5Bv0i4bVJhg4w== X-Received: by 2002:a17:903:252:b0:1d3:f02c:e82a with SMTP id j18-20020a170903025200b001d3f02ce82amr35241plh.36.1703181935830; Thu, 21 Dec 2023 10:05:35 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id j17-20020a170902da9100b001d3b3ac2d7bsm1916379plx.245.2023.12.21.10.05.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 21 Dec 2023 10:05:34 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Damodharam Ammepalli Subject: [PATCH 01/18] net/bnxt: add support for UDP GSO Date: Thu, 21 Dec 2023 10:05:12 -0800 Message-Id: <20231221180529.18687-2-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231221180529.18687-1-ajit.khaparde@broadcom.com> References: <20231221180529.18687-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org UDP GSO aka UDP Fragmentation Offload allows an application or stack to provide a data payload larger than the MTU. The application then updates the mbuf ol_flags and sets the PKT_TX_UDP_SEG flag. Then based on the tso_segs and tso_mss fields in the mbuf the PMD can indicate the UDP GSO transmit request to the hardware. This feature is supported on Thor2 and will be enabled when the firmware sets the UDP GSO support via the HWRM_FUNC_QCAPS. Signed-off-by: Ajit Khaparde Reviewed-by: Damodharam Ammepalli --- drivers/net/bnxt/bnxt.h | 1 + drivers/net/bnxt/bnxt_hwrm.c | 2 ++ drivers/net/bnxt/bnxt_txq.c | 2 ++ drivers/net/bnxt/bnxt_txr.c | 7 ++++++- 4 files changed, 11 insertions(+), 1 deletion(-) diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h index 7aed4c3da3..4b5c2c4b8f 100644 --- a/drivers/net/bnxt/bnxt.h +++ b/drivers/net/bnxt/bnxt.h @@ -801,6 +801,7 @@ struct bnxt { (BNXT_CHIP_P5_P7((bp)) && \ (bp)->hwrm_spec_code >= HWRM_VERSION_1_9_2 && \ !BNXT_VF((bp))) +#define BNXT_FW_CAP_UDP_GSO BIT(13) #define BNXT_TRUFLOW_EN(bp) ((bp)->fw_cap & BNXT_FW_CAP_TRUFLOW_EN &&\ (bp)->app_id != 0xFF) diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c index e56f7693af..37cf179938 100644 --- a/drivers/net/bnxt/bnxt_hwrm.c +++ b/drivers/net/bnxt/bnxt_hwrm.c @@ -950,6 +950,8 @@ static int __bnxt_hwrm_func_qcaps(struct bnxt *bp) flags_ext2 = rte_le_to_cpu_32(resp->flags_ext2); if (flags_ext2 & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT2_RX_ALL_PKTS_TIMESTAMPS_SUPPORTED) bp->fw_cap |= BNXT_FW_CAP_RX_ALL_PKT_TS; + if (flags_ext2 & HWRM_FUNC_QCAPS_OUTPUT_FLAGS_EXT2_UDP_GSO_SUPPORTED) + bp->fw_cap |= BNXT_FW_CAP_UDP_GSO; unlock: HWRM_UNLOCK(); diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c index 4df4604975..f99ad211db 100644 --- a/drivers/net/bnxt/bnxt_txq.c +++ b/drivers/net/bnxt/bnxt_txq.c @@ -42,6 +42,8 @@ uint64_t bnxt_get_tx_port_offloads(struct bnxt *bp) tx_offload_capa |= RTE_ETH_TX_OFFLOAD_GENEVE_TNL_TSO; if (BNXT_TUNNELED_OFFLOADS_CAP_IPINIP_EN(bp)) tx_offload_capa |= RTE_ETH_TX_OFFLOAD_IPIP_TNL_TSO; + if (bp->fw_cap & BNXT_FW_CAP_UDP_GSO) + tx_offload_capa |= RTE_ETH_TX_OFFLOAD_UDP_TSO; return tx_offload_capa; } diff --git a/drivers/net/bnxt/bnxt_txr.c b/drivers/net/bnxt/bnxt_txr.c index 899986764f..38da2d2829 100644 --- a/drivers/net/bnxt/bnxt_txr.c +++ b/drivers/net/bnxt/bnxt_txr.c @@ -123,6 +123,10 @@ bnxt_xmit_need_long_bd(struct rte_mbuf *tx_pkt, struct bnxt_tx_queue *txq) return false; } +/* Used for verifying TSO segments during TCP Segmentation Offload or + * UDP Fragmentation Offload. tx_pkt->tso_segsz stores the number of + * segments or fragments in those cases. + */ static bool bnxt_zero_data_len_tso_segsz(struct rte_mbuf *tx_pkt, uint8_t data_len_chk) { @@ -308,7 +312,8 @@ static uint16_t bnxt_start_xmit(struct rte_mbuf *tx_pkt, else txbd1->cfa_action = txq->bp->tx_cfa_action; - if (tx_pkt->ol_flags & RTE_MBUF_F_TX_TCP_SEG) { + if (tx_pkt->ol_flags & RTE_MBUF_F_TX_TCP_SEG || + tx_pkt->ol_flags & RTE_MBUF_F_TX_UDP_SEG) { uint16_t hdr_size; /* TSO */