[1/2] baseband/acc: fix logtypes register

  This library was calling RTE_LOG_REGISTER_DEFAULT twice, which means that
all logs for both acc100 and vrb drivers would be emitted for
pmd.baseband.acc logtype.

It seems the intent was to have dedicated logtypes per driver, so
register one for each with a suffix.

Fixes: c2d93488c7c3 ("baseband/acc200: introduce ACC200")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 drivers/baseband/acc/rte_acc100_pmd.c | 4 ++--
 drivers/baseband/acc/rte_vrb_pmd.c    | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)
  

On Mon, 18 Dec 2023 16:43:06 +0100
David Marchand <david.marchand@redhat.com> wrote:

> This library was calling RTE_LOG_REGISTER_DEFAULT twice, which means that
> all logs for both acc100 and vrb drivers would be emitted for
> pmd.baseband.acc logtype.
> 
> It seems the intent was to have dedicated logtypes per driver, so
> register one for each with a suffix.
> 
> Fixes: c2d93488c7c3 ("baseband/acc200: introduce ACC200")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>


Acked-by: Stephen Hemminger <stephen@networkplumber.org>
  

On 12/18/23 16:43, David Marchand wrote:
> This library was calling RTE_LOG_REGISTER_DEFAULT twice, which means that
> all logs for both acc100 and vrb drivers would be emitted for
> pmd.baseband.acc logtype.
> 
> It seems the intent was to have dedicated logtypes per driver, so
> register one for each with a suffix.
> 
> Fixes: c2d93488c7c3 ("baseband/acc200: introduce ACC200")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   drivers/baseband/acc/rte_acc100_pmd.c | 4 ++--
>   drivers/baseband/acc/rte_vrb_pmd.c    | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/baseband/acc/rte_acc100_pmd.c b/drivers/baseband/acc/rte_acc100_pmd.c
> index 292537e24d..b837f7d7cd 100644
> --- a/drivers/baseband/acc/rte_acc100_pmd.c
> +++ b/drivers/baseband/acc/rte_acc100_pmd.c
> @@ -27,9 +27,9 @@
>   #endif
>   
>   #ifdef RTE_LIBRTE_BBDEV_DEBUG
> -RTE_LOG_REGISTER_DEFAULT(acc100_logtype, DEBUG);
> +RTE_LOG_REGISTER_SUFFIX(acc100_logtype, acc100, DEBUG);
>   #else
> -RTE_LOG_REGISTER_DEFAULT(acc100_logtype, NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(acc100_logtype, acc100, NOTICE);
>   #endif
>   
>   /* Calculate the offset of the enqueue register */
> diff --git a/drivers/baseband/acc/rte_vrb_pmd.c b/drivers/baseband/acc/rte_vrb_pmd.c
> index 686e086a5c..6a89f9d4b3 100644
> --- a/drivers/baseband/acc/rte_vrb_pmd.c
> +++ b/drivers/baseband/acc/rte_vrb_pmd.c
> @@ -22,9 +22,9 @@
>   #include "vrb_pmd.h"
>   
>   #ifdef RTE_LIBRTE_BBDEV_DEBUG
> -RTE_LOG_REGISTER_DEFAULT(vrb_logtype, DEBUG);
> +RTE_LOG_REGISTER_SUFFIX(vrb_logtype, vrb, DEBUG);
>   #else
> -RTE_LOG_REGISTER_DEFAULT(vrb_logtype, NOTICE);
> +RTE_LOG_REGISTER_SUFFIX(vrb_logtype, vrb, NOTICE);
>   #endif
>   
>   /* Calculate the offset of the enqueue register. */

Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Thanks,
Maxime
  

On 12/18/23 16:43, David Marchand wrote:
> This library was calling RTE_LOG_REGISTER_DEFAULT twice, which means that
> all logs for both acc100 and vrb drivers would be emitted for
> pmd.baseband.acc logtype.
> 
> It seems the intent was to have dedicated logtypes per driver, so
> register one for each with a suffix.
> 
> Fixes: c2d93488c7c3 ("baseband/acc200: introduce ACC200")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>   drivers/baseband/acc/rte_acc100_pmd.c | 4 ++--
>   drivers/baseband/acc/rte_vrb_pmd.c    | 4 ++--
>   2 files changed, 4 insertions(+), 4 deletions(-)
> 

Applied to next-baseband.

Thanks,
Maxime