diff mbox series

crytodev: make logtype internal

Message ID 20231212164118.61936-1-stephen@networkplumber.org (mailing list archive)
State Rejected, archived
Delegated to: akhil goyal
Headers
Series crytodev: make logtype internal |

Checks

Context Check Description
ci/checkpatch success coding style OK
ci/loongarch-compilation success Compilation OK
ci/loongarch-unit-testing success Unit Testing PASS
ci/github-robot: build success github build: passed
ci/Intel-compilation success Compilation OK
ci/intel-Testing success Testing PASS
ci/intel-Functional success Functional PASS
ci/iol-intel-Performance success Performance Testing PASS
ci/iol-mellanox-Performance success Performance Testing PASS
ci/iol-intel-Functional success Functional Testing PASS
ci/iol-broadcom-Functional success Functional Testing PASS
ci/iol-broadcom-Performance success Performance Testing PASS
ci/iol-abi-testing success Testing PASS
ci/iol-unit-amd64-testing success Testing PASS
ci/iol-unit-arm64-testing success Testing PASS
ci/iol-compile-arm64-testing success Testing PASS
ci/iol-compile-amd64-testing success Testing PASS
ci/iol-sample-apps-testing success Testing PASS

Commit Message

Stephen Hemminger Dec. 12, 2023, 4:41 p.m. UTC 
  The logtype does not need to be exported as API.

Fixes: be618b81545e ("cryptodev: convert to dynamic logtype")
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 lib/cryptodev/version.map | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

David Marchand Dec. 21, 2023, 9:28 a.m. UTC | #1 
On Tue, Dec 12, 2023 at 5:41 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> The logtype does not need to be exported as API.

The CDEV_* macros are exported in the public header.
If some external users use them and we take this patch, the user
binary will point at a symbol for which we have no safety barrier (wrt
symbol removal / changes).

Moving those macros to cryptodev_pmd.h is a prerequisite.
diff mbox series

Patch

diff --git a/lib/cryptodev/version.map b/lib/cryptodev/version.map
index 54360a5da538..bde369eb27a6 100644
--- a/lib/cryptodev/version.map
+++ b/lib/cryptodev/version.map
@@ -44,7 +44,6 @@  DPDK_24 {
 	rte_cryptodev_get_sec_ctx;
 	rte_cryptodev_info_get;
 	rte_cryptodev_is_valid_dev;
-	rte_cryptodev_logtype;
 	rte_cryptodev_name_get;
 	rte_cryptodev_queue_pair_count;
 	rte_cryptodev_queue_pair_setup;
@@ -91,6 +90,7 @@  INTERNAL {
 
 	cryptodev_fp_ops_reset;
 	cryptodev_fp_ops_set;
+	rte_cryptodev_logtype;
 	rte_cryptodev_allocate_driver;
 	rte_cryptodev_pmd_allocate;
 	rte_cryptodev_pmd_callback_process;