From patchwork Mon Dec 11 17:11:05 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 135037 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3A95B436C8; Mon, 11 Dec 2023 18:12:44 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 67D6D42DE8; Mon, 11 Dec 2023 18:11:40 +0100 (CET) Received: from mail-qk1-f175.google.com (mail-qk1-f175.google.com [209.85.222.175]) by mails.dpdk.org (Postfix) with ESMTP id 320E342DDF for ; Mon, 11 Dec 2023 18:11:39 +0100 (CET) Received: by mail-qk1-f175.google.com with SMTP id af79cd13be357-77f320ca2d5so347027885a.1 for ; Mon, 11 Dec 2023 09:11:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1702314698; x=1702919498; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=5UG0mnkI/Xses58D65ioT17ltUPruy8WdWEocbeTKN8=; b=Yx26G1wgioUvt/kQdDpuUHrbMgtLGV5xNqa5VyZBa5WGzQ/Tg64qAk/YX0DQ50+3gg l1gRkMq3Oi9/j2CqAtNwKLUEF9zG0lF4laKpD/2dAk26iaH87GpXDiFusCn9VtNjlJ/Q 5ys7TgC2gAMaMET3nI055Qak5xC0w0YECWVfg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702314698; x=1702919498; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=5UG0mnkI/Xses58D65ioT17ltUPruy8WdWEocbeTKN8=; b=GmE56EWL4sCnMYsP724tdb6pjIoJNzgKWYfkSM7TTMaH0zISoRqRll6dUAQjN405HG Z2imi85N0t4rqEaub21l5NMT3GGjb9yNii9bqoXsyUfJHveOnEcv+SQC3nDt99gtqxZw xJV4q0DxzFqD++7hJ4y02zLUBr+nY4FOVAGgRKJvFq/pfKgUym2a+bGLG9F8IEXa+FoU vyzGWCAkxO2vzAu/CaOjAPL2yGVX12GjWgGbc8nS9p7oo43w6sHwi3l40dEL7IiztP5N MH7rAZC4Gxk0ZkCw3WINCBWOD7PkyhhTCSnB5zDYopKFouv0jKhctecMsy7OYwiFSDhj RUXw== X-Gm-Message-State: AOJu0YxJaB+tWe323ZRDXVAOiw/d1+hLgoJrfsjMAD8n8xkLB9eVMmXg +P813b84h0IMoVcJgnCmL8NPWo7W5hDjuTVQCq4d4ros+ij9Yzp3ToJHupsGwZdQq7FLCGZwe5s iXKYsUqCxnCZcbwkhDQHwm/Clp1KUxJBY+oHNsFfIA9ptP+HmcRsBxpNCs/gnsy9XcvvL X-Google-Smtp-Source: AGHT+IHTwbyBhQmlxgUGuuWVtk/K54vp2R1jQ/rJdgqEralIoSYK45zC2cPxLyxWFwtY8AxIAqskPg== X-Received: by 2002:a05:620a:5591:b0:76c:ea67:38e4 with SMTP id vq17-20020a05620a559100b0076cea6738e4mr5603292qkn.12.1702314698199; Mon, 11 Dec 2023 09:11:38 -0800 (PST) Received: from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252]) by smtp.gmail.com with ESMTPSA id qz16-20020a05620a8c1000b0077efdfbd730sm3094581qkn.34.2023.12.11.09.11.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 09:11:36 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha , Mike Baucom Subject: [PATCH v3 10/14] net/bnxt: refactor the ulp initialization Date: Mon, 11 Dec 2023 09:11:05 -0800 Message-Id: <20231211171109.89716-11-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231211171109.89716-1-ajit.khaparde@broadcom.com> References: <20231211171109.89716-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kishore Padmanabha Add new method to consider all the conditions to check before the ulp could be initialized. Signed-off-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde Reviewed-by: Mike Baucom --- drivers/net/bnxt/bnxt_ethdev.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 004b2df4f4..81a30eb983 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -190,6 +190,7 @@ static void bnxt_dev_recover(void *arg); static void bnxt_free_error_recovery_info(struct bnxt *bp); static void bnxt_free_rep_info(struct bnxt *bp); static int bnxt_check_fw_ready(struct bnxt *bp); +static bool bnxt_enable_ulp(struct bnxt *bp); int is_bnxt_in_error(struct bnxt *bp) { @@ -1520,7 +1521,8 @@ static int bnxt_dev_stop(struct rte_eth_dev *eth_dev) return ret; /* delete the bnxt ULP port details */ - bnxt_ulp_port_deinit(bp); + if (bnxt_enable_ulp(bp)) + bnxt_ulp_port_deinit(bp); bnxt_cancel_fw_health_check(bp); @@ -1641,9 +1643,11 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) goto error; /* Initialize bnxt ULP port details */ - rc = bnxt_ulp_port_init(bp); - if (rc) - goto error; + if (bnxt_enable_ulp(bp)) { + rc = bnxt_ulp_port_init(bp); + if (rc) + goto error; + } eth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev); eth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev); @@ -3426,7 +3430,7 @@ bnxt_flow_ops_get_op(struct rte_eth_dev *dev, */ dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE; - if (BNXT_TRUFLOW_EN(bp)) + if (bnxt_enable_ulp(bp)) *ops = &bnxt_ulp_rte_flow_ops; else *ops = &bnxt_flow_ops; @@ -6666,6 +6670,20 @@ struct tf *bnxt_get_tfp_session(struct bnxt *bp, enum bnxt_session_type type) &bp->tfp[BNXT_SESSION_TYPE_REGULAR] : &bp->tfp[type]; } +/* check if ULP should be enabled or not */ +static bool bnxt_enable_ulp(struct bnxt *bp) +{ + /* truflow and MPC should be enabled */ + /* not enabling ulp for cli and no truflow apps */ + if (BNXT_TRUFLOW_EN(bp) && bp->app_id != 254 && + bp->app_id != 255) { + if (BNXT_CHIP_P7(bp)) + return false; + return true; + } + return false; +} + RTE_LOG_REGISTER_SUFFIX(bnxt_logtype_driver, driver, NOTICE); RTE_PMD_REGISTER_PCI(net_bnxt, bnxt_rte_pmd); RTE_PMD_REGISTER_PCI_TABLE(net_bnxt, bnxt_pci_id_map);