From patchwork Sun Dec 10 01:24:51 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ajit Khaparde X-Patchwork-Id: 134989 X-Patchwork-Delegate: ajit.khaparde@broadcom.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A7570436BE; Sun, 10 Dec 2023 02:33:03 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21D3240EAB; Sun, 10 Dec 2023 02:31:58 +0100 (CET) Received: from mail-pl1-f182.google.com (mail-pl1-f182.google.com [209.85.214.182]) by mails.dpdk.org (Postfix) with ESMTP id 6539940A70 for ; Sun, 10 Dec 2023 02:31:54 +0100 (CET) Received: by mail-pl1-f182.google.com with SMTP id d9443c01a7336-1d053c45897so29835405ad.2 for ; Sat, 09 Dec 2023 17:31:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1702171913; x=1702776713; darn=dpdk.org; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=Ww1Rr3TWTahpLRbUSw5W57uEgTck5iDRMbpQ8fzMI9o=; b=OCf5kUgwjwB1KIrIi4D0vhv8qBUuvIWSVlWVbEbv4L3aecTnPQpRcWJMykXbTP+wyY TBA5fnfAmv/ZY9BLnC3bilVyOtd9hm+QEImxS0IobBLrlix/fPQic4N/dmMXAgpOObFT MSrgW4rK1ZCO7PfOZQB3qpwiQA5T4UBiu7sFI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702171913; x=1702776713; h=mime-version:references:in-reply-to:message-id:date:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ww1Rr3TWTahpLRbUSw5W57uEgTck5iDRMbpQ8fzMI9o=; b=PVtlsvTh9V+kE6RrSktbnPrtZoSihKGukE+kpRfZma7B3J16baTLj5o+I6zNTDLd0E DWBzDn9xPnOr+RQIWRbaBwJfsz9YsSVODoM+0JlNc0IDjBWPtyHePEq11z8KIv3ZQ4Tb tj6yXV62iSUpgFJvCL0m8JCvNdGtzhD1bA+x8+JeahI/8NtpcMIheb5e6bufezjXcDYv 6RyIjWNEUfPdloA86vksCI7y853evwzmIlQQSaUb01lTYCbESpgke5UZ1RNycwzcJU5A +BO3eN/cmj4a2z5yzTZ4I3haNZiBgZwOr6RrWUZyXAYauk26FgYFvBzfOrPyUAHoZ7nO fMmA== X-Gm-Message-State: AOJu0YzWdoe75ep/GqBjeJC8cIuUIb7yKWr42bBVz8Xc/X+go84dGFFc ++CmYUpNMCfIMvBKwORjFAsvQPmD1l4pzWwelDQjXEB1DghXP7U7Vt+JxBcTh0WXJ6J+AsTZGLN OjYvGc245JJ0XhHliHlVfvDVB4Y4WzCbbPW+5Ky+lwI3sZvgGVXvX9xgR5v3IBGc/Ptz/ X-Google-Smtp-Source: AGHT+IFiTeETFdLfHXxPraOW+BWpqYu3R8yl+n7LpXm4cfnJYJMK6PO4cNOeRXk5o0R17VvAmAoa+g== X-Received: by 2002:a17:902:e74e:b0:1cf:9c44:62e with SMTP id p14-20020a170902e74e00b001cf9c44062emr2901342plf.34.1702171913113; Sat, 09 Dec 2023 17:31:53 -0800 (PST) Received: from localhost.localdomain ([2605:a601:a780:1400:6d20:fff:e413:282a]) by smtp.gmail.com with ESMTPSA id q3-20020a170902f78300b001d083fed5f3sm4006050pln.60.2023.12.09.17.31.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 Dec 2023 17:31:52 -0800 (PST) From: Ajit Khaparde To: dev@dpdk.org Cc: Kishore Padmanabha , Mike Baucom Subject: [PATCH v2 10/14] net/bnxt: refactor the ulp initialization Date: Sat, 9 Dec 2023 17:24:51 -0800 Message-Id: <20231210012455.20229-11-ajit.khaparde@broadcom.com> X-Mailer: git-send-email 2.39.2 (Apple Git-143) In-Reply-To: <20231210012455.20229-1-ajit.khaparde@broadcom.com> References: <20231210012455.20229-1-ajit.khaparde@broadcom.com> MIME-Version: 1.0 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org From: Kishore Padmanabha Add new method to consider all the conditions to check before the ulp could be initialized. Signed-off-by: Kishore Padmanabha Reviewed-by: Ajit Khaparde Reviewed-by: Mike Baucom --- drivers/net/bnxt/bnxt_ethdev.c | 28 +++++++++++++++++++++++----- 1 file changed, 23 insertions(+), 5 deletions(-) diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c index 5810e0a2a9..6282f16a7d 100644 --- a/drivers/net/bnxt/bnxt_ethdev.c +++ b/drivers/net/bnxt/bnxt_ethdev.c @@ -190,6 +190,7 @@ static void bnxt_dev_recover(void *arg); static void bnxt_free_error_recovery_info(struct bnxt *bp); static void bnxt_free_rep_info(struct bnxt *bp); static int bnxt_check_fw_ready(struct bnxt *bp); +static bool bnxt_enable_ulp(struct bnxt *bp); int is_bnxt_in_error(struct bnxt *bp) { @@ -1520,7 +1521,8 @@ static int bnxt_dev_stop(struct rte_eth_dev *eth_dev) return ret; /* delete the bnxt ULP port details */ - bnxt_ulp_port_deinit(bp); + if (bnxt_enable_ulp(bp)) + bnxt_ulp_port_deinit(bp); bnxt_cancel_fw_health_check(bp); @@ -1641,9 +1643,11 @@ int bnxt_dev_start_op(struct rte_eth_dev *eth_dev) goto error; /* Initialize bnxt ULP port details */ - rc = bnxt_ulp_port_init(bp); - if (rc) - goto error; + if (bnxt_enable_ulp(bp)) { + rc = bnxt_ulp_port_init(bp); + if (rc) + goto error; + } eth_dev->rx_pkt_burst = bnxt_receive_function(eth_dev); eth_dev->tx_pkt_burst = bnxt_transmit_function(eth_dev); @@ -3426,7 +3430,7 @@ bnxt_flow_ops_get_op(struct rte_eth_dev *dev, */ dev->data->dev_flags |= RTE_ETH_DEV_FLOW_OPS_THREAD_SAFE; - if (BNXT_TRUFLOW_EN(bp)) + if (bnxt_enable_ulp(bp)) *ops = &bnxt_ulp_rte_flow_ops; else *ops = &bnxt_flow_ops; @@ -6666,6 +6670,20 @@ struct tf *bnxt_get_tfp_session(struct bnxt *bp, enum bnxt_session_type type) &bp->tfp[BNXT_SESSION_TYPE_REGULAR] : &bp->tfp[type]; } +/* check if ULP should be enabled or not */ +static bool bnxt_enable_ulp(struct bnxt *bp) +{ + /* truflow and MPC should be enabled */ + /* not enabling ulp for cli and no truflow apps */ + if (BNXT_TRUFLOW_EN(bp) && bp->app_id != 254 && + bp->app_id != 255) { + if (BNXT_CHIP_P7(bp)) + return false; + return true; + } + return false; +} + RTE_LOG_REGISTER_SUFFIX(bnxt_logtype_driver, driver, NOTICE); RTE_PMD_REGISTER_PCI(net_bnxt, bnxt_rte_pmd); RTE_PMD_REGISTER_PCI_TABLE(net_bnxt, bnxt_pci_id_map);