[1/3] net/nfb: remove unused device args
Checks
Commit Message
The driver has no entries in VALID_KEYS array so there are
no device args. And after parsing it just frees the result.
Looks like it was copy/pasted from some other driver.
Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
drivers/net/nfb/nfb.h | 2 --
drivers/net/nfb/nfb_ethdev.c | 16 ----------------
2 files changed, 18 deletions(-)
@@ -36,8 +36,6 @@
#define RTE_NFB_DRIVER_NAME net_nfb
-/* Device arguments */
-static const char * const VALID_KEYS[] = {NULL};
struct pmd_internals {
uint16_t max_rxmac;
@@ -518,7 +518,6 @@ nfb_eth_dev_init(struct rte_eth_dev *dev)
struct rte_pci_device *pci_dev = RTE_ETH_DEV_TO_PCI(dev);
struct rte_pci_addr *pci_addr = &pci_dev->addr;
struct rte_ether_addr eth_addr_init;
- struct rte_kvargs *kvlist;
RTE_LOG(INFO, PMD, "Initializing NFB device (" PCI_PRI_FMT ")\n",
pci_addr->domain, pci_addr->bus, pci_addr->devid,
@@ -529,21 +528,6 @@ nfb_eth_dev_init(struct rte_eth_dev *dev)
pci_addr->domain, pci_addr->bus, pci_addr->devid,
pci_addr->function);
- /* Check validity of device args */
- if (dev->device->devargs != NULL &&
- dev->device->devargs->args != NULL &&
- strlen(dev->device->devargs->args) > 0) {
- kvlist = rte_kvargs_parse(dev->device->devargs->args,
- VALID_KEYS);
- if (kvlist == NULL) {
- RTE_LOG(ERR, PMD, "Failed to parse device arguments %s",
- dev->device->devargs->args);
- rte_kvargs_free(kvlist);
- return -EINVAL;
- }
- rte_kvargs_free(kvlist);
- }
-
/*
* Get number of available DMA RX and TX queues, which is maximum
* number of queues that can be created and store it in private device