diff mbox series

[02/11] doc: add Traffic Manager feature for iavf

Message ID 20231128060934.2446-3-lihuisong@huawei.com (mailing list archive)
State Superseded, archived
Delegated to: Ferruh Yigit
Headers
Series add Traffic Manager feature |

Checks

Context Check Description
ci/checkpatch success coding style OK

Commit Message

lihuisong (C) Nov. 28, 2023, 6:09 a.m. UTC 
  Add Traffic Manager feature for iavf.

Cc: stable@dpdk.org

Signed-off-by: Huisong Li <lihuisong@huawei.com>
---
 doc/guides/nics/features/iavf.ini | 1 +
 1 file changed, 1 insertion(+)

Comments

Ferruh Yigit Nov. 28, 2023, 10:35 a.m. UTC | #1 
On 11/28/2023 6:09 AM, Huisong Li wrote:
> Add Traffic Manager feature for iavf.
> 
> Cc: stable@dpdk.org
> 
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> ---
>  doc/guides/nics/features/iavf.ini | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
> index db4f92ce71..385799c650 100644
> --- a/doc/guides/nics/features/iavf.ini
> +++ b/doc/guides/nics/features/iavf.ini
> @@ -35,6 +35,7 @@ Inner L4 checksum    = Y
>  Packet type parsing  = Y
>  Rx descriptor status = Y
>  Tx descriptor status = Y
> +Traffic manager      = Y
>  Inline crypto        = Y
>  Basic stats          = Y
>  Multiprocess aware   = Y

Can you please keep the order in the default.ini and other files same,
here 'Inline crypto' seems put into wrong order that is causing the
confusion,
but new fields seems need to go between 'VLAN filter' & 'CRC offload'.
lihuisong (C) Nov. 28, 2023, 11:33 a.m. UTC | #2 
在 2023/11/28 18:35, Ferruh Yigit 写道:
> On 11/28/2023 6:09 AM, Huisong Li wrote:
>> Add Traffic Manager feature for iavf.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>>   doc/guides/nics/features/iavf.ini | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
>> index db4f92ce71..385799c650 100644
>> --- a/doc/guides/nics/features/iavf.ini
>> +++ b/doc/guides/nics/features/iavf.ini
>> @@ -35,6 +35,7 @@ Inner L4 checksum    = Y
>>   Packet type parsing  = Y
>>   Rx descriptor status = Y
>>   Tx descriptor status = Y
>> +Traffic manager      = Y
>>   Inline crypto        = Y
>>   Basic stats          = Y
>>   Multiprocess aware   = Y
> Can you please keep the order in the default.ini and other files same,
> here 'Inline crypto' seems put into wrong order that is causing the
> confusion,
> but new fields seems need to go between 'VLAN filter' & 'CRC offload'.
Yes, I also find that the order of some driver's ini file is different 
from the one of default.ini.
Fix the order in this patch?
> .
lihuisong (C) Nov. 28, 2023, 11:47 a.m. UTC | #3 
在 2023/11/28 18:35, Ferruh Yigit 写道:
> On 11/28/2023 6:09 AM, Huisong Li wrote:
>> Add Traffic Manager feature for iavf.
>>
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>> ---
>>   doc/guides/nics/features/iavf.ini | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
>> index db4f92ce71..385799c650 100644
>> --- a/doc/guides/nics/features/iavf.ini
>> +++ b/doc/guides/nics/features/iavf.ini
>> @@ -35,6 +35,7 @@ Inner L4 checksum    = Y
>>   Packet type parsing  = Y
>>   Rx descriptor status = Y
>>   Tx descriptor status = Y
>> +Traffic manager      = Y
>>   Inline crypto        = Y
>>   Basic stats          = Y
>>   Multiprocess aware   = Y
> Can you please keep the order in the default.ini and other files same,
> here 'Inline crypto' seems put into wrong order that is causing the
> confusion,
> but new fields seems need to go between 'VLAN filter' & 'CRC offload'.
> .
Hi Ferruh,

I find that there are many place which is different from the order of 
default.ini.
And other drivers also have this problem.
I want to do it for all drivers after this series.
What do you think of that?
Ferruh Yigit Nov. 28, 2023, 11:55 a.m. UTC | #4 
On 11/28/2023 11:47 AM, lihuisong (C) wrote:
> 
> 在 2023/11/28 18:35, Ferruh Yigit 写道:
>> On 11/28/2023 6:09 AM, Huisong Li wrote:
>>> Add Traffic Manager feature for iavf.
>>>
>>> Cc: stable@dpdk.org
>>>
>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>>> ---
>>>   doc/guides/nics/features/iavf.ini | 1 +
>>>   1 file changed, 1 insertion(+)
>>>
>>> diff --git a/doc/guides/nics/features/iavf.ini
>>> b/doc/guides/nics/features/iavf.ini
>>> index db4f92ce71..385799c650 100644
>>> --- a/doc/guides/nics/features/iavf.ini
>>> +++ b/doc/guides/nics/features/iavf.ini
>>> @@ -35,6 +35,7 @@ Inner L4 checksum    = Y
>>>   Packet type parsing  = Y
>>>   Rx descriptor status = Y
>>>   Tx descriptor status = Y
>>> +Traffic manager      = Y
>>>   Inline crypto        = Y
>>>   Basic stats          = Y
>>>   Multiprocess aware   = Y
>> Can you please keep the order in the default.ini and other files same,
>> here 'Inline crypto' seems put into wrong order that is causing the
>> confusion,
>> but new fields seems need to go between 'VLAN filter' & 'CRC offload'.
>> .
> Hi Ferruh,
> 
> I find that there are many place which is different from the order of
> default.ini.
> And other drivers also have this problem.
> I want to do it for all drivers after this series.
> What do you think of that?
>

Agree to fix the order later with a separate patch, and keep the order
as best as possible in this series.
lihuisong (C) Nov. 28, 2023, 12:11 p.m. UTC | #5 
在 2023/11/28 19:55, Ferruh Yigit 写道:
> On 11/28/2023 11:47 AM, lihuisong (C) wrote:
>> 在 2023/11/28 18:35, Ferruh Yigit 写道:
>>> On 11/28/2023 6:09 AM, Huisong Li wrote:
>>>> Add Traffic Manager feature for iavf.
>>>>
>>>> Cc: stable@dpdk.org
>>>>
>>>> Signed-off-by: Huisong Li <lihuisong@huawei.com>
>>>> ---
>>>>    doc/guides/nics/features/iavf.ini | 1 +
>>>>    1 file changed, 1 insertion(+)
>>>>
>>>> diff --git a/doc/guides/nics/features/iavf.ini
>>>> b/doc/guides/nics/features/iavf.ini
>>>> index db4f92ce71..385799c650 100644
>>>> --- a/doc/guides/nics/features/iavf.ini
>>>> +++ b/doc/guides/nics/features/iavf.ini
>>>> @@ -35,6 +35,7 @@ Inner L4 checksum    = Y
>>>>    Packet type parsing  = Y
>>>>    Rx descriptor status = Y
>>>>    Tx descriptor status = Y
>>>> +Traffic manager      = Y
>>>>    Inline crypto        = Y
>>>>    Basic stats          = Y
>>>>    Multiprocess aware   = Y
>>> Can you please keep the order in the default.ini and other files same,
>>> here 'Inline crypto' seems put into wrong order that is causing the
>>> confusion,
>>> but new fields seems need to go between 'VLAN filter' & 'CRC offload'.
>>> .
>> Hi Ferruh,
>>
>> I find that there are many place which is different from the order of
>> default.ini.
>> And other drivers also have this problem.
>> I want to do it for all drivers after this series.
>> What do you think of that?
>>
> Agree to fix the order later with a separate patch, and keep the order
> as best as possible in this series.

ok，will adjust the order of this file a little bit.

> .
diff mbox series

Patch

diff --git a/doc/guides/nics/features/iavf.ini b/doc/guides/nics/features/iavf.ini
index db4f92ce71..385799c650 100644
--- a/doc/guides/nics/features/iavf.ini
+++ b/doc/guides/nics/features/iavf.ini
@@ -35,6 +35,7 @@  Inner L4 checksum    = Y
 Packet type parsing  = Y
 Rx descriptor status = Y
 Tx descriptor status = Y
+Traffic manager      = Y
 Inline crypto        = Y
 Basic stats          = Y
 Multiprocess aware   = Y