From patchwork Thu Nov 16 17:21:55 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ferruh Yigit X-Patchwork-Id: 134430 X-Patchwork-Delegate: ferruh.yigit@amd.com Return-Path: X-Original-To: patchwork@inbox.dpdk.org Delivered-To: patchwork@inbox.dpdk.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 622B743347; Thu, 16 Nov 2023 18:22:35 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2E099402CD; Thu, 16 Nov 2023 18:22:35 +0100 (CET) Received: from NAM04-BN8-obe.outbound.protection.outlook.com (mail-bn8nam04on2082.outbound.protection.outlook.com [40.107.100.82]) by mails.dpdk.org (Postfix) with ESMTP id 591CD40150 for ; Thu, 16 Nov 2023 18:22:33 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=NqQJX3mpu3RO68F2k9JPT6YtnAdU5tU5Ima7InldD3ifOdqZfSepFBN8OYHYAA9lIdeDQY+tInftYGSvofdrdyDrSbu9JtupofmUjX1x3ncWqeQ1zGyeFBzEjWrqe7lk7YWKspVOLzg239tOaqVfXgm72PsE0rPcYkL+V2t4DQh9c3EIRraniD8VbVpHz6jV5y5fJrhjR10W8/39RMycHRUF7FGKw1ez/OiD3o2mpYm8kJ7N6ueNzn4NmEN5Cpt2fF9+XvYRGO7DmlKiEg+KbkVnkfhjJP53aSA/dZ1oyC0BaTIqcOQy8IiqPUB9zPMnJt6pAc6dv11F7oCpH57ABg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=dm1yRRg2EJ1w7DS7nJTPKQsPE+kCE//6I0oYDO6oCOI=; b=JBCBLUKF9hElUysK33oQX/GvFGWA5z/C+4kxyEObrhlEvXjs8ZDx77AAHc4fm5pSI+FPErFVdQL1cHGgeZf3QKixoNWCzjxHEa3HzOZ1g4e2aV7bkAfuz3yW0L9z6vBIG7YdIN+i2I+J002ZevfRG2LnoeUVgfjF5HbRrDa+pBSdnutVRxzpYliiXKfti/gdo+Vc/5vXTp7HFXLrS/T9S4lxV9CdWfC1FdPAQy4byC/7zZNd5KFu6pBf1kt2+sVInrDBiGmXlEbHfP7rj9hiKvBfZdT5AuTjTqFPbbdK6OfMIl64rCwGcQt9M4xn5oCOyEIbzdrOvju/S6kbEUqZ6A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=intel.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=dm1yRRg2EJ1w7DS7nJTPKQsPE+kCE//6I0oYDO6oCOI=; b=w712QZIQC3EjDcPv/f/jZchGFXDDTxHIBPsVMVJMZ5wK1/U0PlwSR2evdvkPjVt/QYkDHC2kGmJgrzUJ6bsku1ZjEvLMAnsgaoSdkcNziUNthIX8p7jR4uOwt4rDBZlS+kBQUpsLOreHE4NViJFT+lE9KqYEFwok2CC8Qg4yZTk= Received: from CH0PR03CA0254.namprd03.prod.outlook.com (2603:10b6:610:e5::19) by DM4PR12MB7671.namprd12.prod.outlook.com (2603:10b6:8:104::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.23; Thu, 16 Nov 2023 17:22:31 +0000 Received: from DS3PEPF000099E1.namprd04.prod.outlook.com (2603:10b6:610:e5:cafe::88) by CH0PR03CA0254.outlook.office365.com (2603:10b6:610:e5::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.20 via Frontend Transport; Thu, 16 Nov 2023 17:22:30 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C Received: from SATLEXMB04.amd.com (165.204.84.17) by DS3PEPF000099E1.mail.protection.outlook.com (10.167.17.196) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.7002.20 via Frontend Transport; Thu, 16 Nov 2023 17:22:30 +0000 Received: from telcodpdk.amd.com (10.180.168.240) by SATLEXMB04.amd.com (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.32; Thu, 16 Nov 2023 11:22:28 -0600 From: Ferruh Yigit To: Aman Singh , Yuying Zhang , Chengwen Feng , Dengdui Huang , Huisong Li CC: , Song Jiale , Zhimin Huang Subject: [PATCH] app/testpmd: fix set Tx offload command Date: Thu, 16 Nov 2023 17:21:55 +0000 Message-ID: <20231116172155.951084-1-ferruh.yigit@amd.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 X-Originating-IP: [10.180.168.240] X-ClientProxiedBy: SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com (10.181.40.145) X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DS3PEPF000099E1:EE_|DM4PR12MB7671:EE_ X-MS-Office365-Filtering-Correlation-Id: 24cb9621-e376-4e28-e96f-08dbe6c89d2f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ERP3sVMQeiSlb3WQsISHul2qqrfiU9GxXzYHnNOVjlg/OYyNfUJ/AZYLUW6vmiz3NY+HrZrH08NKfiupQC/bIzQvl3pqoEzbS75dNIAhmoqy9iWu8MISYNkYiuWnBAURmXb3mjOD+TGIDdsbZ3kFS+9lH4c7PAxYKvNMBzmzGgi2hsiwfM39/1YbPLFu8yfVh6UWNSPH5qKMUkuP01MTSUEK1NS69slE91N4hmYSRi/y9hiufyNpciIIgPeEgaH4XV4jT0K0jD2d/gTDZMi6o7l7R2DyYuti7JWphgk3gOgcH+whs10gDZu0hFKr23I2Y7qnZF7jwrndsCgWqQ4Xh6iaHu52OUBL2XfJWny//MyJTo7KUpEos8l+0pJLVszvCx9xom13jun5w/Y8D5ckmXgpqx6vwE+/q0A6rFAsyEGETq26YmQvJZ6BIeWNhHpdYHBm4TNnlwljDeu+GICZ4Ce5ZqX5R1B8fysE7iO50+JQ8JPxQhy+NlrgT7k0QSQSTXkQDFf/ajYVIjqq0HlstSgspdIYI6eGmJZ8O7Tr/voJjmUhk38y0p4APqo4QuXEcDPvHjOANxViF4FdKlJWxYG0XSxJaiQ7dJc21FW1+9xetFfG+0rXjLYygeNTMdSe27iXk13jbEwZSXovdjqCjIZxa9vyb4ZJiptrtnvmRZZhlrlWubjBlQZuLt7jj9X0fCQ1+F+leGpP3IMemeSgL/rlVV4lUp2qLaEEJ8WmawNWAZmJqkLep62UETYAnPVWy11yrlie0d4i5MjB4mG4tg== X-Forefront-Antispam-Report: CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE; SFS:(13230031)(4636009)(396003)(346002)(39860400002)(136003)(376002)(230922051799003)(82310400011)(64100799003)(451199024)(1800799009)(186009)(46966006)(36840700001)(40470700004)(2906002)(4744005)(5660300002)(86362001)(40460700003)(36860700001)(81166007)(7696005)(356005)(6666004)(47076005)(41300700001)(8676002)(8936002)(4326008)(1076003)(426003)(54906003)(70206006)(70586007)(316002)(336012)(2616005)(82740400003)(110136005)(83380400001)(478600001)(16526019)(26005)(36756003)(44832011)(40480700001)(36900700001); DIR:OUT; SFP:1101; X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Nov 2023 17:22:30.7286 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 24cb9621-e376-4e28-e96f-08dbe6c89d2f X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17]; Helo=[SATLEXMB04.amd.com] X-MS-Exchange-CrossTenant-AuthSource: DS3PEPF000099E1.namprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7671 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org In command to set Tx offload: "port config tx_offload on|off", there is a defect in "on|off" comparison, so command does opposite of what is intended. Fixed comparison. Fixes: 6280fe565b44 ("app/testpmd: allow offload config for all ports") Signed-off-by: Ferruh Yigit Reviewed-by: Chengwen Feng Acked-by: Huisong Li --- Cc: huangdengdui@huawei.com Cc: lihuisong@huawei.com Cc: Song Jiale Cc: Zhimin Huang --- app/test-pmd/cmdline.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c index c040de7a7991..9369d3b4c526 100644 --- a/app/test-pmd/cmdline.c +++ b/app/test-pmd/cmdline.c @@ -11737,7 +11737,7 @@ cmd_config_per_port_tx_offload_parsed(void *parsed_result, struct cmd_config_per_port_tx_offload_result *res = parsed_result; bool on; - on = strcmp(res->on_off, "on"); + on = strcmp(res->on_off, "on") == 0; config_port_tx_offload(res->port_id, res->offload, on); }